From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6DC627BF7D for ; Thu, 15 Jan 2026 05:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768456738; cv=none; b=r3gTcvnS26QnJstSpNQ2qAhIW0hJ2lGO3SzZINhu2Y818jnZcP5va8P006Yw+6sMXqNTRdpLOw6LnRr7JqD9Pc72VIdkR1E9SyZaLNkPOd4PsQQQKW6bXCUbN1qspBPxO5neSI7sWYiyQspwa2uAMvncuqYexzWqfgYIHdBWMCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768456738; c=relaxed/simple; bh=KqSyi3BUbCDJufy9qCRTQlPXoTvU86tAvsNHvB4kGnI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f57FfiAk0LuNtDVGC5oK7klxmeSyOf9e+TqKBtkLiXur4wyU9eVWuT2osa899TQe89QvTR4WEfzM7kO+AO2EnN5db9cW0O5ZKjj9P087XHfq9lscGI1AbStJviT+FMNVowOVk41Hkud8nnsNA8mIqsEGnWVo6no6g9+3uIhkabU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=T3TjUoj8; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="T3TjUoj8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768456736; x=1799992736; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KqSyi3BUbCDJufy9qCRTQlPXoTvU86tAvsNHvB4kGnI=; b=T3TjUoj8ksF28x8kzoB7Uv85cc5GpTXXRS30piQkyk8HCtLADBcLRoEJ mmcKpgwCPlOnDXftP1LBDKwM+klb60BVFbnzVTFR5kx88hR3NVU0OrzIW 5Dmr7zhTxKvmk/K4sQtqgbUNhJO0IMA+D1lXNoZsTc45e4dDbqgk7Xo9G T/PMBUOr8uVCYLp0abjqe0MyHmrQym1qBPwcdpen19RdFelXF2AhwsTM8 YQ+bZWLrTpLGcumXJCyAxsMW9LnIxfST4azdfX2Jgjag/+gBUMC4E5KSr 0Gw0R/E0l9ehY32Pr/e8qAz7VOqfX+eDzIAtyy9UJYNPQ6rlCAqPrJA/W w==; X-CSE-ConnectionGUID: 1EE+CKM3QbKltvqZzBtDKQ== X-CSE-MsgGUID: zAVGG4K5Sb6jsHH+vuAOrg== X-IronPort-AV: E=McAfee;i="6800,10657,11671"; a="92430653" X-IronPort-AV: E=Sophos;i="6.21,226,1763452800"; d="scan'208";a="92430653" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2026 21:58:56 -0800 X-CSE-ConnectionGUID: FCJbDYugRk6NPGu6GkTExQ== X-CSE-MsgGUID: btfR36TDSmeBQo+/LxLX/w== X-ExtLoop1: 1 Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2026 21:58:54 -0800 Date: Thu, 15 Jan 2026 06:58:51 +0100 From: Raag Jadav To: Alexander Usyskin Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Reuven Abliyev , "Gustavo A . R . Silva" , Jani Partanen , Lucas De Marchi Subject: Re: [PATCH] mtd: intel-dg: Fix accessing regions before setting nregions Message-ID: References: <20260115052237.1149027-1-alexander.usyskin@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260115052237.1149027-1-alexander.usyskin@intel.com> On Thu, Jan 15, 2026 at 07:22:37AM +0200, Alexander Usyskin wrote: > The regions array is counted by nregions, but it's set only after > accessing it: > > [] UBSAN: array-index-out-of-bounds in drivers/mtd/devices/mtd_intel_dg.c:750:15 > [] index 0 is out of range for type ' [*]' > > Fix it by also fixing an undesired behavior: the loop silently ignores > ENOMEM and continues setting the other entries. > > CC: Gustavo A. R. Silva > CC: Raag Jadav > Reported-by: Jani Partanen > Closes: https://lore.kernel.org/all/caca6c67-4f1d-49f1-948f-e63b6b937b29@sotapeli.fi > Fixes: ceb5ab3cb646 ("mtd: add driver for intel graphics non-volatile memory device") > Signed-off-by: Lucas De Marchi > Signed-off-by: Alexander Usyskin Reviewed-by: Raag Jadav > --- > drivers/mtd/devices/mtd_intel_dg.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/devices/mtd_intel_dg.c b/drivers/mtd/devices/mtd_intel_dg.c > index 2bab30dcd35f..7f751c48a76d 100644 > --- a/drivers/mtd/devices/mtd_intel_dg.c > +++ b/drivers/mtd/devices/mtd_intel_dg.c > @@ -770,6 +770,7 @@ static int intel_dg_mtd_probe(struct auxiliary_device *aux_dev, > > kref_init(&nvm->refcnt); > mutex_init(&nvm->lock); > + nvm->nregions = nregions; > > for (n = 0, i = 0; i < INTEL_DG_NVM_REGIONS; i++) { > if (!invm->regions[i].name) > @@ -777,13 +778,15 @@ static int intel_dg_mtd_probe(struct auxiliary_device *aux_dev, > > char *name = kasprintf(GFP_KERNEL, "%s.%s", > dev_name(&aux_dev->dev), invm->regions[i].name); > - if (!name) > - continue; > + if (!name) { > + ret = -ENOMEM; > + goto err; > + } > + > nvm->regions[n].name = name; > nvm->regions[n].id = i; > n++; > } > - nvm->nregions = n; /* in case where kasprintf fail */ > > ret = devm_pm_runtime_enable(device); > if (ret < 0) { > -- > 2.43.0 >