From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55E2422CBD9 for ; Thu, 15 Jan 2026 06:15:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768457747; cv=none; b=RMNzdOklJQvJ8uPjmxvRgHhDrUYIg27qIhW/Vy/ac1/9k2BHfGK1yywoPr6UsummNkATBcSKeKqOH+LXvrqmD6e5ax3wYGP6x7DOB2rolVpIDF6emb1NmDgzgruxbAJPE+w5SAH8uv2rOGEw6GF8tOZ8DXUGfw+JeoXW5VB5MAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768457747; c=relaxed/simple; bh=xuYDqmlOXdV6M+f9LMPEInQe4YGVV3/NVgJwk7BAxnw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fUhrubpnu/6O69O41NHGrAQRJP/wQ+IgEyt/9Im+IpqgpufTn+1dl5gsmtGyH0eppKh/GOQJLk01LM5GlxL48Io5jO9DM2xad2V4c0RShICmAwqJxnxhxYNX93EpH60qwbmk3YQTkjftfKSndGug+LnlIot0cUV/nZmEuDQ8tfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DKwniacV; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DKwniacV" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-34e90f7b49cso255522a91.3 for ; Wed, 14 Jan 2026 22:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768457742; x=1769062542; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LjxQx55L3HFhzEsrPSzupy5cs4/k1InHSQSDwivVXVQ=; b=DKwniacVWxzbvE77W7Jw+zibkKCLP8WFkWQqQtiIrSZna8Gv2ioa1vYVpH/7fxr0qE PSSR71km0nRz8YlkRSv6hhD9SZAaqvYQKTVD3y/tCFvwCnY1g/++L+LRi9o7aY774ytw jufy+1OvW/bqKsZ3YYjTFrxCk2OgsAZy1cokguq6DOeC1yfcYlkVZ+ZEpyk0Z+u6jnHk E+9Uydlaj19QRu9mbpu0x8bx5hvlB6euvky2/WvG0SrKEUTKstDARadc3r1p8byrfx6r RvC/ZQp7XMfiskYGVhEpbLqcrgC4uEb/sRk/+7syHw26phHyhP2NO5V7IRdFIVucSmmO Nd6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768457742; x=1769062542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LjxQx55L3HFhzEsrPSzupy5cs4/k1InHSQSDwivVXVQ=; b=Zo4T517RbfcV0C11IWss33THu7p7ABzqi1Y+0Qp65jeYHtxI60MlnyC2GM8fjODDXS n+Jv68y9y77BLL0jznWkj/cISz+bM6L/9U862dHInrth1XGCoNzVLuJHX4vgWfRWszHQ pkhZLwOQBhBXqj7k1xWXgrkgO/jq8sxBiAi+EzRlMuBvFNopPOq5lgu+Jf65RWnAq0Yx GxfbycCsmzYE/X4HOHu9Qjf3RKDUvllo5i8A2ysE8QZPPUTM89TwwVx9539vqalzoeSQ yNK5DgURqN2wqZbIyROuwQ5ngd7gUVpxAhDTW2Rxp2HQEisvHVYItZOsvBhx6O3E+GLO Uv6g== X-Forwarded-Encrypted: i=1; AJvYcCW47y/Jaa6jWuE2CE7vnwkBlO4hARvXJXF8HtqNiJ9DJ8IMZHH5phlatZObhTRxdpVtn8LI5UMJOSGlSAM=@vger.kernel.org X-Gm-Message-State: AOJu0YzqRZ9tDjJuhoZvZCXSmQHEA8pR9TlHAEAEYdxo7qv8o1r5Vvdq mmyksKZHPfJKJFkrP5WG0qX+lciW3asUvzxW7Kx+hA9XqI1A/730kL0nOvy1JA== X-Gm-Gg: AY/fxX7JvS+mZINuwt6yvG1Cwz6D/f5d7vty/ObnZoneB79LBh6I4ZS5NPcoXkoxkDd CpHbu+bZw1hNLdVnbkyu/9i2fJvaL5s/BLZRWeFr/htHVf/n4CpuwUIjSgCAgpVdVKYYsdsKKDb PgKmsgwGZ5X0qIhCFZc24AON5UJl57r8BOk2s87qlZTyP7u8RoVTUxVG1gWr4QoO2NGWNOCZK99 rExlSQXDXnNJg9CQtz2XBLQaUd8Gl/DghFt6+m//eTl7vFe1MPJB6A0AvYMdmJ9R9GEBJnHy4y7 Ek76G0rTmELLi4qbDz9PpJOQ59fO5RXOcTYkTskbHHXpR9/v6YrsIhTHaeRwFtiWdssESt3XFeH MB6/EEI3KT5I3cL8omnTrjtZGO9zROX5KdjpQLysrIZeXXVBzr39CJmS/Yf4sqUjVkRdHW6g4bO 31HR/MUh6Os/YZlHH0y1bNo+Yd X-Received: by 2002:a17:90b:350b:b0:34a:8c77:d37b with SMTP id 98e67ed59e1d1-351090da11amr6037803a91.16.1768457741930; Wed, 14 Jan 2026 22:15:41 -0800 (PST) Received: from google.com ([2402:7500:568:57ed:f859:ae8b:d60b:53d6]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-352677ba62csm1059931a91.2.2026.01.14.22.15.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 22:15:41 -0800 (PST) Date: Thu, 15 Jan 2026 14:15:37 +0800 From: Kuan-Wei Chiu To: Daniel Palmer Cc: geert@linux-m68k.org, sre@kernel.org, jserv@ccns.ncku.edu.tw, eleanor15x@gmail.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 1/2] power: reset: Add QEMU virt-ctrl driver Message-ID: References: <20260112182258.1851769-1-visitorckw@gmail.com> <20260112182258.1851769-2-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Daniel, On Wed, Jan 14, 2026 at 07:01:58PM +0900, Daniel Palmer wrote: > Hi Kuan-Wei, > > On Tue, 13 Jan 2026 at 03:27, Kuan-Wei Chiu wrote: > > > > Add a new driver for the 'virt-ctrl' device found on QEMU virt machines > > (e.g. m68k). This device provides a simple interface for system reset > > and power off [1]. > > > > This driver registers a restart handler for system reboot and sets the > > global pm_power_off callback for system shutdown. It is designed to be > > generic and can be reused by other architectures utilizing this QEMU > > device. > > > > Link: https://gitlab.com/qemu-project/qemu/-/blob/v10.2.0/hw/misc/virt_ctrl.c [1] > > Signed-off-by: Kuan-Wei Chiu > > FWIW: I have a driver for this in my "m68k with devicetree" tree. As > far as I could tell the virt_ctrl thing in QEMU might get more > features aside from power control. > So I made it a misc device instead. Thanks for the note. Just out of curious, are there currently specific plans to add non-power features to virt_ctrl? If new features are added, shouldn't they be exposed via separate drivers in their respective subsystems, rather than consolidating everything into a misc driver? Regards, Kuan-Wei