From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f74.google.com (mail-ej1-f74.google.com [209.85.218.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E22A733ADBE for ; Thu, 15 Jan 2026 08:41:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768466507; cv=none; b=QrFdjdhHjE9QN4V0+VkWINn4+hLyJ3WTF9n8TkBcDTYpfWb3we21OjvWveEdQ8K5De+WVzObjtLZVgAPcob+1efrPlaEMd+4ET6/WwViAAMv28MBKco5WwWw58MwdYAli4QB9zAxb589HcZHRRMcJ+mSQUAeLAc94TP5905nq6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768466507; c=relaxed/simple; bh=JaGMgKBJZj2jGdcVOYXhgaFess8nPZHWImAx8UQJHUY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=nKD3iAyRkqRJpOK7ecCgJDDSLXAZnwF6WCBcJUeVrQ5Y2eQ0dJqUgsbIgYrrXYWl1n6Vpp8syJQaNWAFq6+dM2b3elNI3aNpfesmoXz6Ttbyld5t5xhz31ColyHU6HT4kIHmdPLGvxl02i5JH5+ihEgMS72CZZdlDoUrfCu6YFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cOy6QGHm; arc=none smtp.client-ip=209.85.218.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cOy6QGHm" Received: by mail-ej1-f74.google.com with SMTP id a640c23a62f3a-b8715782415so85965066b.0 for ; Thu, 15 Jan 2026 00:41:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1768466504; x=1769071304; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vkN7c0yWhw/YjwLItSN25LYdHVBoE5BtsCY4v+35Tu8=; b=cOy6QGHmn5eEWUXa+rNK2Tv6/5qWHOWqjgesJXIFGHx2BFrXXE7oDlvvxzuDCQbegQ vrAb1OR//1juDLEEgiYNuViUXKMogBXchIBIlnuNNpt31T3u/I4GuuL1whU3j2Hz/bVD Sy56UaVJ18iUpjORhDMeV+ARg2n6Qa3p3JqFy53BsVT68h62QA8CLSmToVbjnF32QTLg 5JaZOmKjtLqJXOFWtwAWixKePlzs9I2AW9YiB16UYBxDOBxjfbYanOl9ckKOqBXUKhnS lYYGqtJO/h6aUgsdcN7ODJSeGNlGKcriSjaCa2/JyZpVYaY2Mywwzbq8ts8UWtuWLHOd YJUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768466504; x=1769071304; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vkN7c0yWhw/YjwLItSN25LYdHVBoE5BtsCY4v+35Tu8=; b=j6pnCedN2cw7KXGrp/exHbt8qTNLnlUP4LuSfA2pTIjIGBrTQE8mrc2+21iPPZ7IjM 3C5/NCxX2gLFwc4AubMJXT1vMgmfwvJHH8JlwZ+jL+fsFsv43p/HhfRGWVD1YqtEbh1u 1nWGb+phVnbRkv5RCtdOCG+KhPrKR6kpr0q74Ap1qfGWvufNztcIwfDGOiZo7OB2S+Sf NHbXcc9K+D3XnWz17I+369by8u6p5XWt3vT4KO6/HL0wf8x1qKEN4L6ZQL+Wken42or0 lX+oiGXHwtaE5d6eLzGOR0Sq2Ybq3NgfrepqvL5YIkyNg5jlSlYWKfCG68NS0PLCVbZM pqqA== X-Forwarded-Encrypted: i=1; AJvYcCV3UcqvowqW1GM016RI0om1SMq1JCvcHrtRUopf9UbwG0qnMdQzWt5mkd7S1g4J4Cax7BmaaMFSi8qe02k=@vger.kernel.org X-Gm-Message-State: AOJu0YyNrsw/hjwnYkIEVNO1ZdN0WwKpHWDk3xiXN1lzY/kVCp0fQ/OV CkL/TFfk12Jh632HY9MSM1vKOravZVghfF5Sf1jMXVhRrrb3h0RPoPTca5HlQafqSGqpgFXVoBN 1NRGBODWSpdb/Kh7yYA== X-Received: from ejcti8.prod.google.com ([2002:a17:907:c208:b0:b87:635:835e]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a17:907:da7:b0:b76:49ae:6ee6 with SMTP id a640c23a62f3a-b8761029ae4mr483502466b.15.1768466504071; Thu, 15 Jan 2026 00:41:44 -0800 (PST) Date: Thu, 15 Jan 2026 08:41:42 +0000 In-Reply-To: <20260115080619.317006-1-jongan.kim@lge.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260115080619.317006-1-jongan.kim@lge.com> Message-ID: Subject: Re: [PATCH RESEND] binder: handle PID namespace conversion for freeze operation From: Alice Ryhl To: jongan.kim@lge.com Cc: gregkh@linuxfoundation.org, arve@android.com, brauner@kernel.org, cmllamas@google.com, ht.hong@lge.com, jungsu.hwang@lge.com, kernel-team@android.com, linux-kernel@vger.kernel.org, sanghun.lee@lge.com, seulgi.lee@lge.com, sunghoon.kim@lge.com, tkjos@android.com, heesu0025.kim@lge.com Content-Type: text/plain; charset="utf-8" On Thu, Jan 15, 2026 at 05:06:19PM +0900, jongan.kim@lge.com wrote: > As Alice mentioned, since only the freeze operation takes a pid as input, it > receives the local pid of the namespace. This patch converts this pid to the > global pid of the init namespace for matching pid of binder_procs properly. > (binder_procs has `task->group_leader->pid`). Are there any concerns or > problems for this logic? This isn't new with your changes ... but it does have a race where the target process dies and gets replaced by a new process with the same pid just before you invoke the freeze ioctl. Alice