From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: raskar.shree97@gmail.com
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
skhan@linuxfoundation.org, david.hunter.linux@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/5] iio: proximity: rfd77402: Add interrupt handling support
Date: Thu, 15 Jan 2026 10:42:10 +0200 [thread overview]
Message-ID: <aWioYpYPAPOGmnHD@smile.fi.intel.com> (raw)
In-Reply-To: <20260115-rfd77402_v5-v5-3-594eb57683e4@gmail.com>
On Thu, Jan 15, 2026 at 01:57:39PM +0530, Shrikant Raskar via B4 Relay wrote:
> Add interrupt handling support to enable event-driven data acquisition
> instead of continuous polling. This improves responsiveness, reduces
> CPU overhead, and supports low-power operation by allowing the system
> to remain idle until an interrupt occurs.
...
Also
+ bits.h // although it's preexisting problem, but you add a new user of it
> +#include <linux/completion.h>
> #include <linux/delay.h>
+ dev_printk.h
+ errno.h
> #include <linux/i2c.h>
> +#include <linux/interrupt.h>
> #include <linux/iopoll.h>
+ jiffies.h
> #include <linux/module.h>
+ types.h
All on the same grounds as above,
...
> mutex_init(&data->lock);
Conversion to devm_mutext_init() change should be before this patch.
...
> + i2c_set_clientdata(client, indio_dev);
Is it used?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-15 8:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 8:27 [PATCH v5 0/5] iio: proximity: Add interrupt support for RFD77402 Shrikant Raskar via B4 Relay
2026-01-15 8:27 ` [PATCH v5 1/5] iio: proximity: rfd77402: Reorder header includes Shrikant Raskar via B4 Relay
2026-01-15 8:27 ` [PATCH v5 2/5] iio: proximity: rfd77402: Use kernel helper for result polling Shrikant Raskar via B4 Relay
2026-01-15 8:37 ` Andy Shevchenko
2026-01-16 20:09 ` Jonathan Cameron
2026-01-15 8:27 ` [PATCH v5 3/5] iio: proximity: rfd77402: Add interrupt handling support Shrikant Raskar via B4 Relay
2026-01-15 8:42 ` Andy Shevchenko [this message]
2026-01-19 18:48 ` Shrikant
2026-01-19 18:59 ` Andy Shevchenko
2026-01-20 15:59 ` Shrikant
2026-01-20 16:14 ` Andy Shevchenko
2026-01-15 8:27 ` [PATCH v5 4/5] iio: proximity: rfd77402: Use devm-managed mutex initialization Shrikant Raskar via B4 Relay
2026-01-15 8:27 ` [PATCH v5 5/5] iio: proximity: rfd77402: Document device private data structure Shrikant Raskar via B4 Relay
2026-01-15 8:43 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWioYpYPAPOGmnHD@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=david.hunter.linux@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=raskar.shree97@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox