From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F5593A1CFA for ; Thu, 15 Jan 2026 14:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768486709; cv=none; b=Og1FDmXyPhL3W/puqa+lMtdKFbP3gIUg/y2r08yH2sTpTxGL9B46LgoYu7XJUvacVIC1Iyk2HzdZ/Jkaq3jGnTeZwBXy+iCArioWDPqEdI/TVEEoqs/Gh+qZCWFhMlRI5QVrBP3lf5Dmsim7Rb0/fMumNl8GD8Cd3FhhEqxqJQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768486709; c=relaxed/simple; bh=Jtc9sSjyX7Ms9NttRrBA88Rr+IN45iedh99EFmfPrDk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q6hPmG1qQV+bSv7NK/dy6Je5SUSU7XeScugRNqp4Uog1dVxHPdvjUI0AXxVLmFVYDAPOQlodpf3oHlruUftl6/ISRlw7aiJU6XUByFWkhJZcirUpnrG//Lwpnwmrxp2zH2ceE3RqJBhHr956hfi67NVVcGOuPUY1g/wMjzOun9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fy8gsD2w; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UkrXAQPT; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fy8gsD2w"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UkrXAQPT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768486707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t4RC+ObhpewYzGNMozpFt20pSaSgz2F7mC9Tp5X8J9U=; b=fy8gsD2w+z5xLnf92WOXkB1gvtxUeY/RJD+LZB8tO1rd81nFOWQLU9l4l2AT6y0L894fkQ F3DFArlFynf+wphMca/J0HhvFfTcqKqdOjklA8beQXTbNmW8HTh5siH/aatGbeFoyMZ/JN xwDBmHyIyJP8NdhP581sk9Owh957JIg= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-YRO2ObIxNCihVKwAkp3q-Q-1; Thu, 15 Jan 2026 09:18:26 -0500 X-MC-Unique: YRO2ObIxNCihVKwAkp3q-Q-1 X-Mimecast-MFC-AGG-ID: YRO2ObIxNCihVKwAkp3q-Q_1768486706 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-88a3929171bso21730286d6.3 for ; Thu, 15 Jan 2026 06:18:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768486706; x=1769091506; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=t4RC+ObhpewYzGNMozpFt20pSaSgz2F7mC9Tp5X8J9U=; b=UkrXAQPT3+h08I+oZdYFsk5V0jEaPc8+SAOqsfETANjrzJtcq5RirdO5+XbZnamDXR oxEFsCQYzk2sC897tAZO6NSSEOmHTF3fhYiYZpSVp3b5VlUEDz3dOUomxv+Qxs3pLlDE p64Yyv2cc13PmIz9FxP+TJQVg9wwuTQXWzu8nMDx0oq/2ehMoeVwIFj5dV6MS34N1Cv9 n2b1PsZauEEG9aJkaZAy2rZUjPRWueMHyZSOV8k1PVUab1h1PbBTlzgXXW5Kzk2rmGQH C4PM7iEjKcPAjDTasCRnfOg8eeqIV6LNXBXC09Umq/mQUyrrXi69i27XBYTUvNkWPfpf Qo6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768486706; x=1769091506; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=t4RC+ObhpewYzGNMozpFt20pSaSgz2F7mC9Tp5X8J9U=; b=jkz0BekHv1DhhByPXgYOZKS/3PrML05wx2SvSgNjiyKL9+I5wLuq8yEo8eJ2gNMaQm mpOHy43bf/iv/una9iROxAtJpxo4vEkRLu0W44yJ/YzxbczRlu3JIiz+ta+//IAmVsoJ cIoLMJSvjNqqq+1hFPuRpwDfTMYEN44xgpiBfq5zpufG53z/j1Srp4gvu5gsASKNoOJa y5tkINnIQUWuv+lGUUr3mteGoeuJt3REifW0TlmujZoF4qynbk3QfDo1inRSkkx5DckY AdH/VW5Qdpgub3nPtMUJUEofkb0EjibjJIn3rHXEg2xxg8PfTC2bXzv1PBOcSFxaYlaq tliQ== X-Forwarded-Encrypted: i=1; AJvYcCU91ZNQSHNzgJr0906ofiJnqFw0ADqsd5pvZ//dTkuwVQfmA7M2xGaltkGLAvIbomQEVS0bICsYB42my50=@vger.kernel.org X-Gm-Message-State: AOJu0Yxj6G/mumiqKtUKTsDtDDejeLqKhfnE7eXXqbbvC3lPL0pLHTWx ef2EDCSTcKrWyK2a9NBFwJn1G9p0hOyGNAqkvWKgXrpXQMjf0PRVnZ2oN4kCDTwlrwQL3BWZ+Pd 4xenkJut8xyxwO5ve+8dWOgpkCJdWVjwkg7d9mY5xgK1rCUB6BnQV3SsDw8Pu8K5fmw== X-Gm-Gg: AY/fxX5S9WfkPmR+ce91SpAZQ866+38B5nxxwc4t6ROId2Lm4v7YyvbRbFpxOTS0Ie/ qmnvxbjbDREOLC6mr4bFIO2JRvPRpMfmpiSBBgViGBlppKdB1+/eO7TIXR8OGmrOSRg2Bxr4Ugk HvFQAsmXL3FJVRYjBV0s6sGR0gppMBCIj95cAwjmHieWRnZ5gTjM2wW3G7MtTR6yBTspQCsESC3 DKPCuZ/1uRvvUTA5kaF0pwGDi7co8V2gelxqoE2FQsLl65HlYyqOQMhaOswM/4eFrKeCju/IbMn xYGbRKVm5LUxhdFz8HFSj0J2gY7pofH+SreRLsRmfvv9C8OmHTd4h/vOuFn75Tz/gRJ9cxr25/c 7r4pVMwM= X-Received: by 2002:a05:6214:508e:b0:880:38ba:a4d9 with SMTP id 6a1803df08f44-8927445deb6mr82451416d6.67.1768486705616; Thu, 15 Jan 2026 06:18:25 -0800 (PST) X-Received: by 2002:a05:6214:508e:b0:880:38ba:a4d9 with SMTP id 6a1803df08f44-8927445deb6mr82449266d6.67.1768486703308; Thu, 15 Jan 2026 06:18:23 -0800 (PST) Received: from redhat.com ([2600:382:8103:a511:9f9:74cd:13ab:4d59]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-890770e2a8fsm201085636d6.16.2026.01.15.06.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 06:18:22 -0800 (PST) Date: Thu, 15 Jan 2026 09:18:20 -0500 From: Brian Masney To: Vinod Koul Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , linux-phy@lists.infradead.org Subject: Re: [PATCH 25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate() Message-ID: References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> <20260108-clk-divider-round-rate-v1-25-535a3ed73bf3@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) Hi Vinod, On Wed, Jan 14, 2026 at 07:47:18PM +0530, Vinod Koul wrote: > On 08-01-26, 16:16, Brian Masney wrote: > > The divider_round_rate() function is now deprecated, so let's migrate > > to divider_determine_rate() instead so that this deprecated API can be > > removed. > > > > Note that when the main function itself was migrated to use > > determine_rate, this was mistakenly converted to: > > > > req->rate = divider_round_rate(...) > > > > This is invalid in the case when an error occurs since it can set the > > rate to a negative value. > > Acked-by: Vinod Koul Thanks for the Acked-by. However, this patch depends on this other series of mine that's merged into your phy tree: https://lore.kernel.org/linux-clk/176661322399.4169.14248756511703978007@lazor/ Stephen asked for an Acked-by for that series or an immutable branch. This will allow us to remove round_rate from the clk core. I also have a small series to post that's dependent on all of this that lets us get rid of the noop determine_rate implementations that only 'return 0'. I haven't posted that because of the dependencies. Brian