From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE303321F27 for ; Thu, 15 Jan 2026 12:01:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768478478; cv=none; b=lUor3kigqxdxsP23UTuHUZ21B2WOyqQ+xWg9cwIt1X6LZarLmBXdAXrf05RxcWYUpUVTmbQYIJFTozp03LlZeKaoQv8F/tp4y7ZXzbDaZCTura33UxmSw4kNXQYicnPWIa2iRNR6ZnnWjC31JY742KwzfWxmIGKCSorhQw+OFsc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768478478; c=relaxed/simple; bh=HGrCcAWK8+bJScOVj4GyD53aQQY2PTSVg+l13f7Owwk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z3kEiRn7M+nwzbvuInL9OyoDtNtVbirjscI4SLlRO9ilv/a/y4ioadaoi3gzWbs5Ez8evi3Pq+JpKAShcyXW3G3+OAwBlIObSCYyOgnpS3thWIAmJmgTxCGDZ+Qj7Zue5gs4LExIlyjSSAbr8ybvdGDnOkq5FOyloxJmL9RFtgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f6xLzzyf; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=A4c/beiL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f6xLzzyf"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="A4c/beiL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768478475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HbFTVSTAF+qKU6LVtQSbnv/YXWJKOg3pN9JnvD/UC9k=; b=f6xLzzyfHTeaCeDSKniRe0FQxlPhiEPMXeNb3KEIbh1DuriYB/T/+wIjBDu+1aXX3GGc7O zKf5XSBpCxrT9ooHnOjtEmeBUj9seZ3qiN5ClIbObMWqGgjbsK2KeRihf794SffyoM7LEN ZrZtoXgueSOun/fwn8P/lH2WTsqUz8Q= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-333-AkYLC2-KOsaKoF-yYvw_2w-1; Thu, 15 Jan 2026 07:01:14 -0500 X-MC-Unique: AkYLC2-KOsaKoF-yYvw_2w-1 X-Mimecast-MFC-AGG-ID: AkYLC2-KOsaKoF-yYvw_2w_1768478474 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5019f8a18cdso25291321cf.2 for ; Thu, 15 Jan 2026 04:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768478474; x=1769083274; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HbFTVSTAF+qKU6LVtQSbnv/YXWJKOg3pN9JnvD/UC9k=; b=A4c/beiLQhGBW6p1FeG4XY/FIGemGFzc4QTMMqgST6gw1jWGsS9Hc32yfVdEibSsFC 1BVSX6pt9KP1gwI1MjXp2+G7fugaiwmG5gK/C9HAsFu6VGaYkiS88JswnsT9N4UkpuLN TGn1DNICWn/BtYy+OZp8shc2Lz4IWoHp0XBL76j2WXyxEMZufG6jlBq5W4X6//CPRRMK PoMxgdwoj7gsN0K3JUMSpKDAeDPpekhRw21iwkbAnc5N/ydwHzhFczZqHPY9r0Hu1MU0 /lwQCBmdGSwDN++pIqcUD1npm+tJ6gvlEFRy7ZW06ZOwPrgt6WXnFpQnHAw/x57oq1H3 msKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768478474; x=1769083274; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HbFTVSTAF+qKU6LVtQSbnv/YXWJKOg3pN9JnvD/UC9k=; b=QH96u1yrf9Fx8P6g64XYYueMOCJQdxGW6LbEDfAypwGY4Iv7UI+TzKP8u7tYCo/FfD UPIXliokbUbJGlbUwSNKLUxtycRbAWeWlVK4xGIG7+N2y5c44TbHiUDcWKwXRf+ng06/ Xu1yre2AjJ9tdYF1uXbzyzrz+/bsE/3U00E8eAzo3EU5yEk05ERMmD7/MRverCJ2w9pS KEfZJsd/EizrDS0+AR50nkHRKeEBB5oKshOqvpKuA1M328CI9A3M51aJdegAjeYhmOkv qQkMKDYmC7R/0VFiHnAe/Lmd4XtMhYFiJ70Jm/HmomwvD7q39q5Kr7vFqe1TKLd9NhaA FW4A== X-Forwarded-Encrypted: i=1; AJvYcCWBs2T3rhPVlaWCZ3wxlvhg/yP9ymTsydqYgn79PiE0u7SS+nAxh08CbJcY3wXFJjxfrrClIa/84w2/yHA=@vger.kernel.org X-Gm-Message-State: AOJu0YyXul9za0CbYxyEXHLU9UzwnDpY4ond4jQe7Iz4XVI9YGJYzyTs hXzf8yGNH3O88FTsLgHCcqtakeE27D60SfNHfVdzxnQa7kR6konnLQJpYtyfEyUewg/GDck2Z/j twPSpRiG3S1kTZg6Sx072KEvVeNrkf1MjSvuO2/JS05QFR6poHVNprRSPG9ZyZRErcQ== X-Gm-Gg: AY/fxX7hijPlbIHIyC3wgf3n6s3dp7Z0VDL7zd5hKNMkx09iP9hGf+H9oRb+V0/KgMI TftrE7HJhrF2Juik+5T5E9kc4SuWKsZsbofkPz+tAa84wDmAJOTMAtE/9g6dMXunLhbHc0Ayqn/ 9ZEUk5jMmzlRSrMdZN+SZPOfMxF/9TEr491pOnFKWwz+Nbv6UXYmf6RmIE5ugumeUhtlTmMf2rG +AZ3n31YiSAM0JOvs6c8ReGNSYFP6Sd815wPdWx04omzKTGdp2auqY9STYYR9qxDNZzVYA3YaMj EVbCmpGbBNhBCJYAx4BXi3tuxUI2BaEh6ivy2JpyqU6W3JQDmZtZS8GxV5Ws5NN1jRvhFV2GdRN diagTbraPNYEnT1nN0OfZYqdGG1kpzNJiCUPzDF5vCsui X-Received: by 2002:a05:622a:1f11:b0:4ed:b0f9:767f with SMTP id d75a77b69052e-5014848f4c9mr87190291cf.70.1768478474119; Thu, 15 Jan 2026 04:01:14 -0800 (PST) X-Received: by 2002:a05:622a:1f11:b0:4ed:b0f9:767f with SMTP id d75a77b69052e-5014848f4c9mr87189551cf.70.1768478473665; Thu, 15 Jan 2026 04:01:13 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89077280fd3sm196986366d6.55.2026.01.15.04.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 04:01:12 -0800 (PST) Date: Thu, 15 Jan 2026 07:01:11 -0500 From: Brian Masney To: Haoxiang Li Cc: mturquette@baylibre.com, sboyd@kernel.org, mturquette@linaro.org, pankaj.dev@st.com, gabriel.fernandez@st.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] clk: st: clkgen-pll: Fix a memory leak in clkgen_odf_register() Message-ID: References: <20260115045524.640427-1-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260115045524.640427-1-lihaoxiang@isrc.iscas.ac.cn> User-Agent: Mutt/2.2.14 (2025-02-20) On Thu, Jan 15, 2026 at 12:55:24PM +0800, Haoxiang Li wrote: > If clk_register_composite() fails, call kfree() to release > div and gate. > > Fixes: b9b8e614b580 ("clk: st: Support for PLLs inside ClockGenA(s)") > Cc: stable@vger.kernel.org > Signed-off-by: Haoxiang Li Reviewed-by: Brian Masney This patch looks good, however this patch belongs in a series with your other work to clkgen-pll. I'm going to leave some comments on your other patch that you posted to this driver. Brian