From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 556523B8D4C for ; Thu, 15 Jan 2026 15:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768490513; cv=none; b=YsnnFwLGrxAG6zT9wHacTha1IVm8VSALqWMna6VE+JhKHtQhnv7tJNPiXCIZvFqCZcElxQTySenCP5aX6O+N3XdCdQTWLslXPq6nGSPsOxV1imcNqGkkd3vOXfL1L91inuml+JIUvI3221s+QWk46ZmOnHjuRo+CHrfVPJt79sQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768490513; c=relaxed/simple; bh=3mrmeybuzh9PgQXyTEyKUo1q9SHk4JU+LnlVDAEkQ6w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pnwzwENS/EMwG14rSWWukGxQe5fmr5Ox8lI07LrzoxbvFcgn2L5gl4XGqjDS30NWUVLhn+hUuTWtit0lb01KjVO05Q0nnqCukjI4BrRbdMnmo5qU0up1qQ/5vl40Yk0oLNfGyNHKk+6rgYP+U5G72d6BI4wS85dEYPid/pNeNNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K0fVGP5f; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K0fVGP5f" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c46d68f2b4eso649091a12.2 for ; Thu, 15 Jan 2026 07:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768490502; x=1769095302; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zFSOPl7QH14MMJkmhVI069FeYyKLf5eLmECuhHyuPZw=; b=K0fVGP5fj5vxPZHXuasjkrdrRkraXzVwrMEbO9lFSWUSnfm5l/LI9JMihaNDywvLtK BnZeCFkQBk4O1jNA47dDKetuVsbHlZkkDo+6fKVOa/Y81zKMEfuLUjOtFO/8MJ5vDbGH oY2PnpYaPPsetgFqZVxh1mfAGq8ph0drDaZPoQhhtmM4w+xSW4PyAXQcgoVJqFJK6kC+ OaVmi1rgoC7z3Stq1if/m5osCmfVdkYkF2tKb2fYuLutzIDeDoFdQv1aKSHPOP6gP/VT S9nVGZc3If2qN1V41pvJv3epeTKmA6OVc3u+5DeKVGllslGeDrR9bNSOcl3RVxlntLme JjjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768490502; x=1769095302; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zFSOPl7QH14MMJkmhVI069FeYyKLf5eLmECuhHyuPZw=; b=wdgArTLbusHYCMCOnj2Ia0lAlJ4Y0GzT8AtewzgihcRRPNjQTXNp2IiBttmrbp5BbG 9gu0HV6jvAUOIS0lHNMUO+1LurcVMpuEFMgtbRZpgLzC3QhE96RPqiMG2Du8irpNb5V3 UJIT78XWFgEmqyMQHLXXSZLy1JI87kkqUCY+LS9Mk6jvkiyEysFxRfj9dCRd/XAotln6 m0qVmMqPfcuXTsXD0PUf9TPMkoA8qwjBeYHChSr1QdcfwPaOQjRnbFBUfs4sUJRS6VwC xRkO0AcoDQs69f3HR8f8QRJ0WSs9MJjwvUOyQ58pnKfKRfwC0Sk2D/ZqTmKapOdQ6Z23 hOWw== X-Forwarded-Encrypted: i=1; AJvYcCWl+CiLp9a8KCQhXLXKnCzrZlOq/mDNtb+WsW/MKxhhe0Un9ZWZ2rcRuuc1GBCZFg24LHmnuCz2zyog9sw=@vger.kernel.org X-Gm-Message-State: AOJu0YzksI4yrbIX1eQfcTjNRwB6iRAxM+4W7w8mDLlYqPdzNezfTsCA NtvCS/a/REVKMvdq/KQqof9Y09roCYCLgukgTn/0WPjTFNqbFSbxOeA7qsC/Mg== X-Gm-Gg: AY/fxX5Tb4X8ITOrrGQSYoUvy0kokHAzydOfwMUEV1sSdAKJTfo77O4iY4raPQ8ga78 fXkWNiB/1OSvCBAqbftAkJeq7GKKQD08pRfFE3x+rPOxA6/9Ck5yX1tED0aEc7ZLluQBp5JUxfS 0WyUvViDcvNLqeWTJePvhygv+IzXHnmOT2PMdpiX6LkvzkzrK2uaGl4BwDoAAGbqIsqx2G57HU4 RxFLur+5KFgAHMiVwvkNR/qo4zKeSA5Q3JBgAeM4lG9QfBO5qRAvu1f5J3Jl4t5YW9KA0SM6a+n 6wT2bscBJREI8SgNKUFuB8qMqEinWwrtmtMtITjs0krbPq7qNCJtECOJs2tnORzRCbQiEBBQNLD sBGuMXY2+QRxOAqUJs3rVlCtdTpI4eBikdDOR2yqO7psdP+iBYjOtDaLzFXKrrry0J+vNY3IF/7 9kwGeCq+vRQledIlW97/UcyfRa X-Received: by 2002:a17:90b:180d:b0:330:82b1:ef76 with SMTP id 98e67ed59e1d1-3510b145a4dmr4806914a91.28.1768490501476; Thu, 15 Jan 2026 07:21:41 -0800 (PST) Received: from google.com ([2402:7500:568:57ed:9f73:35b6:5a3b:786e]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-352678ef77fsm2307285a91.17.2026.01.15.07.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 07:21:40 -0800 (PST) Date: Thu, 15 Jan 2026 23:21:36 +0800 From: Kuan-Wei Chiu To: Daniel Palmer Cc: geert@linux-m68k.org, sre@kernel.org, jserv@ccns.ncku.edu.tw, eleanor15x@gmail.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 1/2] power: reset: Add QEMU virt-ctrl driver Message-ID: References: <20260112182258.1851769-1-visitorckw@gmail.com> <20260112182258.1851769-2-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Daniel, On Thu, Jan 15, 2026 at 10:29:29PM +0900, Daniel Palmer wrote: > Hi Kuan-Wei, > > On Thu, 15 Jan 2026 at 15:15, Kuan-Wei Chiu wrote: > > > > FWIW: I have a driver for this in my "m68k with devicetree" tree. As > > > far as I could tell the virt_ctrl thing in QEMU might get more > > > features aside from power control. > > > So I made it a misc device instead. > > > > Thanks for the note. > > Just out of curious, are there currently specific plans to add > > non-power features to virt_ctrl? > > The docs here suggest that power control is the only currently > implemented feature but doesn't have to be the only feature: > https://github.com/qemu/qemu/blob/master/docs/specs/virt-ctlr.rst > > > If new features are added, shouldn't they be exposed via separate > > drivers in their respective subsystems, rather than consolidating > > everything into a misc driver? > > I guess if it did get new features maybe it'd be a multifunction > device? Since nothing except power control has ever actually been > implemented, maybe the way you have it right now makes the most sense. > I agree that migrating to an MFD architecture would be the right move if/when qemu implements additional features. For now, I will stick to the current approach in drivers/power/reset as it fits the existing functionality best. Thanks again for your feedback. Regards, Kuan-Wei