From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011036.outbound.protection.outlook.com [40.93.194.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 560EF1D8E01 for ; Thu, 15 Jan 2026 16:25:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.36 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768494328; cv=fail; b=q4QgROES03KPLSL2+8uNXyG0XBau5vgXPBCjx+PajXTa3DQyok/cTaaOPlNygDncX2BH0aLXP0ckjAeX59Gf7dxLleh8nosFBKsCYkIXgbN/esn+G0wyhtqWnjj8Vp1OAPQ7Ab4i51/xy/xmJ84A+4/ofZ/1cJCLL7siGyLWSeQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768494328; c=relaxed/simple; bh=LDC1HAzuq4FcRHG+f0u4Jpdkalq3uyPYRfpsUJ75zMI=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZkFS5t02B6Wd3XXlg4eVyAJAn2oM9zqDbQpKGP7snicOOGPrMN2OgsBZP1HR4gyKoFhfz4UGW/fgt1NjniIvSGR4XRMkH40o75acXqlvgbchowF25k0n8RknfnGGcYpqNbTwJR+IHc+Cn8DbT5a8pfb8cDkPXZ1o33B3tWqXPfM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=VKLs9XtB; arc=fail smtp.client-ip=40.93.194.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="VKLs9XtB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tmykuiUIwO+xzzXKXpawkWQsJQ/bPksL+iZk2UxqmhtvG9SSUhXdqUTKytmoQAvhEzq/wjaL50lYjw9WWna2UknwP/DRmLkpxQcZ3G5gTCjzwgMuVn66J9ZqthwQ4A+ulCcT9CWpGzOWDCUjWb6gTmG0EPyEWh1jxXoQAS7aX+y3bi7kohxYy+2+ZnycJSWaE5W9rOui2QL1ATj39OoCyo9ZTJ70mg+4DE44ssJvUuLC5j5KKaTbcmPN64u7Yfx4RwBhmizZps+DS9bs8ruimtNvULR0l0bCyEEyfsTG2q+Imhgao1izyR9EdmZ4+z2oA5pNKZ7npC0tqTvTxDsVkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DHSRY75HCmzJLXl9dIwpQdUp8OP46fKJw8PQ/fEZ6JI=; b=Oyh9D5tq1Vao8IFxaNYHRStviY64+NRQhlkdeRXp9BI9UVsB26OO8s/8Z9LW03ocCDyxBk90RsBTt8wSIJ/xpMKUuDAfJ0WVL+RaaCMCBAZ8eV2+Ew2bPb/Ubqdh4aMWbYnA8oWp5u5Ca6Xhob7K2oK1uo5ygYJgK/ZOs1ekaSDCoBZzcOlQB3Qq0MXATqienQGullnatlTHp5aryR/NKxFMCwg9GamLP+jNYn0DaeOTtIVzi2r2QGbJotvUPYHd2Zfo/OdOBj43gAl3NbNLbqOZHTUw7bPh5ZRJQa1I/pNYaYF8lhgsdSNPIcjsIsv3tBXCG9g0XrlOlJIrOVDM6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DHSRY75HCmzJLXl9dIwpQdUp8OP46fKJw8PQ/fEZ6JI=; b=VKLs9XtBE0iCzYyv3ooUxtBd4JnuSGM3yCn1yxPGfPkv2YtgS0vErL55LvvJooUgMxQYHT+6IcUEJbKBuXPvixdYuOE8eLGHd6oUP5GIvg9dbfTs9jt0OTnpVHHZNhVWrJlMuOm4tN0CIfL02rT8YW9zE/x9k87ZR/juhBg0sMC6iiUyJ9LiBJm4Th89JoCCucbUMfKny4LQgoWbBnfo4+fhY4plromou3lASFY0qG685eVnYJN1Zlvh3b9jjZCN/obxWFnWEgtN/mGi+oZtfrPX7lXaKmU3ffUz5i8qpP41kRGqelGo/XDqehdRSaerCUAgJXirrVDL7A7UtFy46Q== Received: from PH0PR07CA0079.namprd07.prod.outlook.com (2603:10b6:510:f::24) by MN2PR12MB4469.namprd12.prod.outlook.com (2603:10b6:208:268::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.4; Thu, 15 Jan 2026 16:25:23 +0000 Received: from SN1PEPF00036F3C.namprd05.prod.outlook.com (2603:10b6:510:f:cafe::ff) by PH0PR07CA0079.outlook.office365.com (2603:10b6:510:f::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9520.4 via Frontend Transport; Thu, 15 Jan 2026 16:25:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SN1PEPF00036F3C.mail.protection.outlook.com (10.167.248.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.4 via Frontend Transport; Thu, 15 Jan 2026 16:25:23 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 15 Jan 2026 08:25:08 -0800 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 15 Jan 2026 08:25:07 -0800 Received: from Asurada-Nvidia (10.127.8.14) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 15 Jan 2026 08:25:06 -0800 Date: Thu, 15 Jan 2026 08:25:05 -0800 From: Nicolin Chen To: Jason Gunthorpe CC: Will Deacon , , , , , , , , , Subject: Re: [PATCH rc v5 1/4] iommu/arm-smmu-v3: Add update_safe bits to fix STE update sequence Message-ID: References: <20260108003646.GA537728@nvidia.com> <20260112161010.GC812923@nvidia.com> <20260113161253.GG812923@nvidia.com> <20260113205112.GJ812923@nvidia.com> <20260115131151.GA1081267@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260115131151.GA1081267@nvidia.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF00036F3C:EE_|MN2PR12MB4469:EE_ X-MS-Office365-Filtering-Correlation-Id: d4b7a9af-5daf-4aca-9f1c-08de5452af0f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6Q2CitK5fwNAoO5Z4NdE1waujxMFTSow4JLELa4CKQ5iWIJ0H/dC3HXDgFdV?= =?us-ascii?Q?P7/iRhJLKAUJ0emXD+ZNwaMZSre4yw7mSUKDSqbuJsEQZvW/R00tK8Rn5U3/?= =?us-ascii?Q?R8kG4kdTtR8ZusnQ4L9/o6FcYmN/L0f23pk0g2GbgvV3WEe1Np5uGvgFRG7Z?= =?us-ascii?Q?mmHrwR8KmftBG9ukuIapZ6RC371Rt7GHscIUFEMLdZEvsJtaeHykWC9Y0zrs?= =?us-ascii?Q?pwKP5hCRPC/gIbqluXx481vNjSXPUq+avnkVIn7kRv9y2rfqUoGivX8kZJnY?= =?us-ascii?Q?WntwWeCZZHD4IU9BezJ/Q00FvFarW6kCkB7Kk9Q+dqV8zPP4hh3egMGzQqwb?= =?us-ascii?Q?wy1rNwEPvyGEYWoSX6MGc+Bf4rrI8bHQ/yRKUjQsFaMbi9GGUdPMviiZmE7R?= =?us-ascii?Q?+C3ITSuZo1wE5GWrzRtlNeKQm5x1bc146lacxcTYFVB/VYB9K+rvUsmWWE2+?= =?us-ascii?Q?sDUoCDN8lvfdXFzlb7Hutpjup4ZdYc7Ra+IAOt2kgHP+jjQdL8/P1ZGIbZ/1?= =?us-ascii?Q?BJncJ/1/KdjcYfCLm/ZHK4mXFU+o1unqMqLpEku10ldBvTXFBeo1HNSJIJeF?= =?us-ascii?Q?n/7bD5lmUoJ3tBC8qRKmWBNH9hEb1P1zXXj2dY2ohmVyJ/msXVZ6u7zcbLlN?= =?us-ascii?Q?FQvsZfBZCXcC+PATMS5P/S7z9s0aofnBnKXPUcWAE+JAZ6uqD7hKxGy/zbkC?= =?us-ascii?Q?wOIOJvW2olKeGNvjqPYeCM/PamUVU9STtSTn5G9/GddLBtORElsyVjbB+8ir?= =?us-ascii?Q?Rv7/WVdoPJIsTnu4Bdef2n+7RQPKcYUKUoNMyRe3LRDYb81av3TBzREjlDys?= =?us-ascii?Q?C9Fzjpw2SjhnNDbJGKYqQVzLGRwFhAxWhKCa5f6QjAxMNqCdst79tZkWE6vA?= =?us-ascii?Q?cS02K9QLyphIUg+Em0YKLJ7xkQhec+UuWj2bcGYwcwYke2BzHq55SCGvPxjE?= =?us-ascii?Q?z5ev4pWDW95ZKEo/n2KorEbCWxraV6hbdsN5e6yjG9hd1CJYOJVm2PAB4QUa?= =?us-ascii?Q?HL3YlTktA9Zj1SzkruTyk9BYMBoxnek4NjdMN9lO2nt20iujz7bvZVHJ/Hkd?= =?us-ascii?Q?kxFQmksOOaAU3GLL6TH4CEiABcdGxJzNkwayX9l5+yq+kRpE0lN3EjGMAV9K?= =?us-ascii?Q?mfcmV8D7/qzLrGHQN/Xcw3bVMAkOwHrhWmUV3o5OZ/y8dqY8zS9UQCnwTb9S?= =?us-ascii?Q?c6CnF5qUKVTS8jaRyCOCrH2ap7kVm5VgcsAxHH7Saiyh6UP1SrijCDosrkb/?= =?us-ascii?Q?qoYxv/0wRLEuWn1Wa/CLA4a7OXztLYAKdurFprKZ8bQRFcyqMb+QbDd//sWv?= =?us-ascii?Q?g86VHxYCXK0pQPptNTG9Uh8FkG099feM2i1qh3R0xfLWS4J/De83l/0PG3Hb?= =?us-ascii?Q?uLyrpK2uAx0QXV9LcH9zXge+bxO5M9/UGbcAcEatlBN3Raq8W2FkCFjg2n1o?= =?us-ascii?Q?EyKbEfldub2If8UQx0yLIONowys0Ym1edCr5WNXaZYS6oxCte3rvKPH5tfB3?= =?us-ascii?Q?kjyyUkF6x6WyEcajjc46E4ac9/ccXUJzTJvMnII6ZzeUclKmSvGDotBqasz4?= =?us-ascii?Q?/X6vL0hlgvmTnHiRcDDwDyAkbGc3re+d52izJdaERmLfLym+NXF1a859wzuQ?= =?us-ascii?Q?NXWweu2wm0u8HnkVpYXHt8dhkcoN+pJeFFOOMeIaEQkpmtbOzfleKVMOCOos?= =?us-ascii?Q?K7+DcA=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2026 16:25:23.3028 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4b7a9af-5daf-4aca-9f1c-08de5452af0f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF00036F3C.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4469 On Thu, Jan 15, 2026 at 09:11:51AM -0400, Jason Gunthorpe wrote: > On Tue, Jan 13, 2026 at 04:51:12PM -0400, Jason Gunthorpe wrote: > > > - safe_bits[1] |= cpu_to_le64(STRTAB_STE_1_EATS); > > > + if (!((cur[2] | target[2]) & cpu_to_le64(STRTAB_STE_2_S2S))) > > > + safe_bits[1] |= cpu_to_le64( > > > + FIELD_PREP(STRTAB_STE_1_EATS, STRTAB_STE_1_EATS_TRANS)); > > > -------------------------------------------------------------------------- > > > > > > @will, does this look good to you? I can send a v7 with this. > > > > That is an easy way to address Will's observation, makes sense to me. > > Ah, but it looks like it can generate an errant view of a EATS that is > neither old or new. Ie value 3, reserved. > > I think you should just check if old or new has EATS bit 1 set: > > if (!((cur[2] | target[2]) & cpu_to_le64(STRTAB_STE_2_S2S)) && > !((cur[1] | target[1]) & cpu_to_le64(FIELD_PREP(STRTAB_STE_1_EATS, 2)))) > > Which the current driver never does.. The EATS field is completely controlled by the driver. So, we are safe for now, right? Should we add this when the driver has the actual support for the split stage thing? Thanks Nicolin