From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6656A3B8D46 for ; Thu, 15 Jan 2026 16:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768494591; cv=none; b=sf/rr0QtoxmKENlapHu1K4arkW/AvlyqWWopSgMyksPYllWVottGYIdq5Y6unIjziAnma1b30PFRTSzCVDRqxb0PoE+7ua1S8iNPVc0bwLx7ScqVE2TNKbujzoR+so2J3E5JqxtW5O+TKRiJrXLzfvY3gI6kTC+xMSux+QAwd0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768494591; c=relaxed/simple; bh=YCSgRz0/t1jQPY4RHJTrlyzNUMtunhzW6BeYFIuu23E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ASN+15TbTYXhR0jkrI6fZ+P2uzeyBPpSjq90U3RuInicZK0LZrl8/Ao0jeny/AxwSqzFp5gKUVjH3c+CrZfBjPiLMsQrobnVin2SR/y9RNwVxlgz46x+NKTypu21bvwDO9fJNYaanYpDQGk6D5Pie0Qrhy9HUA6YVgOhNQDmhOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lyacIWQG; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lyacIWQG" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47d1d8a49f5so6989325e9.3 for ; Thu, 15 Jan 2026 08:29:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768494587; x=1769099387; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+QtzGuA52dI+s82SvTC1BjsIyHyAmyGgk9s5A5FU5GE=; b=lyacIWQGncM4CewZKnO+E8NjeMAbtR1fCct95dSm3hmgrPDHNfu0eN/6MoF9cHzj7f 1mECDITRVxmAP49m6Ci4VgsRNAwDO5BZqYxzthc1wZT1RTrqIEwdOWkJbD89TIdd98Yt KOXgUpT9mx937BG26qGVo6g2kc3d39G5FH9juEudjMXX1OC13pcNjiyBtCTJ5/rpYzcT 8N/2gx2M3y71cqFl74ehCpGerLUsJi8vL+IKLklxR9KxSdZGDIUvaE4kIrFgIHisrY00 etP6sWoKE+4wShNCsLsSMldrCDxcyd18rBY4BED/xVr1Uqm4rJRL0LxrK3/jkK3sQ14C jd9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768494587; x=1769099387; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+QtzGuA52dI+s82SvTC1BjsIyHyAmyGgk9s5A5FU5GE=; b=fmWgv8wBl/p+3hn3pjiGii9zQtjx5zYdeJiKgsc9kIOoG4hPQsgLSotcQla97UdccV c24O8SFNRO4ODXQcEuG7809lJgJMKxJ/4Bm3OOp2v6y1EcjJ9xyFb1EOChElOyq5d4bG 36OprOYPhSoER9BEOdCgMZgcNzo1vr+XNA++t3Kc1tdDg/6u21hmxz/SIgxZqeavyQ5G S5ilvbhv3aLuocLSqRbOz+bUwzgqKwhxGzC+E5IABAffqaMERbujbXq3Sb4eRTxaxOU/ gCajEPfNRZrvgpCYV7dj15R0p0D162QkgfKvUtCYw6GL1kTVoqcfzkb4V2tqRSpU32TD lWlA== X-Forwarded-Encrypted: i=1; AJvYcCW4pi+s8u3XhAcEp+D1SNSK9TGtr/XDuc+8ncXMXQzGHb6l2+nWWOKOrHa9WfQKCukXvtuzwawPsItBZuk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx45zMjzpxbb09Zf+fgiwZ4rhjzhXZ/dCrD8+gHceA2wX5nmhjN cAbs00gRHlJe5o4lvOHKJCFeRRSDPDunxwk/M1ouLNzPV17lXwNUg5y0 X-Gm-Gg: AY/fxX4eFMlCZ/f+3kuk6JZ2nZgI30j/bShfFuGBI4FudQUK+h9gsB59R7K3LxxmLgL 5fR00QtyZc7Ka0nGSatO/Ft7hxH99g3KBdqt47UsDykUnsyEC+VhExkySOPcNKPJwHgfO0vGqLw OxCEEte1LXMFCTN9WIWuVnkFsvNysGumO8NWDvsC1cnD5MsgHChiDuca1rhYLAfnBuVEMW6FNQX KtAZVH+cAEVdRg6iP+JgbQQCjSRTSlKcGrIq2hURulrep4WpQxEs8Lp7jT4PvKe46WCvuBkzROC W2PJaZ3rqjGbIdlqVTDQ1XB785iNRoZrlNm4tH2AHUEt7WskVzG8yjMecFUproS8vOe41jL4pwq fYpPJm7Q+Xacm5YgyoqYh7sOVamzIrot3+vW/6DGfZDYRqz0VJIoVxAimib6iNWo08ZrJ8EdNBI c50y4xS3YXrJnfQ1BPDkfP/w467yfkWr17azZ0 X-Received: by 2002:a05:600c:1385:b0:480:1b1a:551d with SMTP id 5b1f17b1804b1-4801e33c18cmr3992165e9.18.1768494587311; Thu, 15 Jan 2026 08:29:47 -0800 (PST) Received: from egonzo (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ee27d9aaesm50238085e9.3.2026.01.15.08.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 08:29:46 -0800 (PST) Date: Thu, 15 Jan 2026 17:29:44 +0100 From: Dave Penkler To: Dominik Karol Pi??tkowski Cc: Greg Kroah-Hartman , Michael Rubin , Dan Carpenter , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/9] gpib: cec: Unify *allocate_private Message-ID: References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> <20260113190759.54355-4-dominik.karol.piatkowski@protonmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260113190759.54355-4-dominik.karol.piatkowski@protonmail.com> On Tue, Jan 13, 2026 at 07:08:56PM +0000, Dominik Karol Pi??tkowski wrote: > Return values for *allocate_private functions as well as calling code in > gpib driver are all over the place. Unify them by returning -errno if > something fails, zero otherwise. Use the returned value as early return > value in case of error. > > Signed-off-by: Dominik Karol Pi??tkowski > --- > drivers/gpib/cec/cec_gpib.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpib/cec/cec_gpib.c b/drivers/gpib/cec/cec_gpib.c > index dbf9b95baabc..6d04becd1058 100644 > --- a/drivers/gpib/cec/cec_gpib.c > +++ b/drivers/gpib/cec/cec_gpib.c > @@ -222,7 +222,7 @@ static int cec_allocate_private(struct gpib_board *board) > > board->private_data = kmalloc(sizeof(struct cec_priv), GFP_KERNEL); Maybe you could change all the remaining kmalloc/memset pairs to kzalloc at the same time ? > if (!board->private_data) > - return -1; > + return -ENOMEM; > priv = board->private_data; > memset(priv, 0, sizeof(struct cec_priv)); > init_nec7210_private(&priv->nec7210_priv); > @@ -239,11 +239,13 @@ static int cec_generic_attach(struct gpib_board *board) > { > struct cec_priv *cec_priv; > struct nec7210_priv *nec_priv; > + int retval; > > board->status = 0; > > - if (cec_allocate_private(board)) > - return -ENOMEM; > + retval = cec_allocate_private(board); > + if (retval < 0) > + return retval; > cec_priv = board->private_data; > nec_priv = &cec_priv->nec7210_priv; > nec_priv->read_byte = nec7210_ioport_read_byte; > -- > 2.43.0 > >