Re: [PATCH net-next] net: phy: intel-xway: workaround stale LEDs before link-up

Andrew Lunn
2026-01-16T01:23:34Z

On Thu, Jan 15, 2026 at 11:40:38PM +0000, Daniel Golle wrote:
> Due to a bug in some PHY internal firmware, manual control as well as
> polarity configuration of the PHY LEDs has no effect until a link has
> been detected at least once after reset. Apparently the LED control
> thread is not started until then.
>
> As a workaround, clear the BMCR_ANENABLE bit for 100ms to force the
> firmware to start the LED thread, allowing manual LED control and
> respecting LED polarity before the first link comes up.
>
> In case the legacy default LED configuration is used the bug isn't
> visible, so only apply the workaround in case LED configuration is
> present in the device tree.

You should consider the case of forced links, where autoneg is
disabled. Under such conditions, you should not leave autoneg enabled.

Andrew