* [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404
@ 2026-01-15 12:18 Antoniu Miclaus
2026-01-15 12:18 ` [PATCH v3 1/4] dt-bindings: mux: gpio-mux: add enable-gpios support Antoniu Miclaus
` (4 more replies)
0 siblings, 5 replies; 19+ messages in thread
From: Antoniu Miclaus @ 2026-01-15 12:18 UTC (permalink / raw)
To: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Antoniu Miclaus, Srinivas Kandagatla, Johan Hovold, David Lechner,
devicetree, linux-kernel
This series extends the gpio-mux driver with optional enable GPIO support
to prevent glitches during channel transitions, then adds support for the
Analog Devices ADG2404 multiplexer as the first user of this feature.
The enable GPIO allows the multiplexer to be disabled before changing
address lines and re-enabled after, preventing brief activation of
unintended channels during transitions. This is particularly important
for precision analog applications.
The ADG2404 is a 4:1 analog multiplexer with low 0.62Ω on-resistance
that requires this enable GPIO functionality for glitch-free operation.
Changes in v3:
* Extend gpio-mux driver instead of creating standalone adg2404 driver
* Make enable GPIO optional for backward compatibility
* Add MUX_IDLE_DISCONNECT support via enable GPIO
Antoniu Miclaus (4):
dt-bindings: mux: gpio-mux: add enable-gpios support
mux: gpio-mux: add support for enable GPIO
dt-bindings: mux: gpio-mux: add adi,adg2404 support
mux: gpio-mux: add adi,adg2404 support
.../devicetree/bindings/mux/gpio-mux.yaml | 26 ++++++++++++++-
drivers/mux/gpio.c | 33 ++++++++++++++++++-
2 files changed, 57 insertions(+), 2 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 1/4] dt-bindings: mux: gpio-mux: add enable-gpios support
2026-01-15 12:18 [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404 Antoniu Miclaus
@ 2026-01-15 12:18 ` Antoniu Miclaus
2026-01-16 8:30 ` Krzysztof Kozlowski
2026-01-15 12:18 ` [PATCH v3 2/4] mux: gpio-mux: add support for enable GPIO Antoniu Miclaus
` (3 subsequent siblings)
4 siblings, 1 reply; 19+ messages in thread
From: Antoniu Miclaus @ 2026-01-15 12:18 UTC (permalink / raw)
To: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Antoniu Miclaus, Srinivas Kandagatla, David Lechner,
Bartosz Golaszewski, devicetree, linux-kernel
Add support for an optional enable GPIO that allows the multiplexer
to be disabled.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
changes in v3:
* new patch - extend gpio-mux instead of standalone driver approach
---
Documentation/devicetree/bindings/mux/gpio-mux.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/mux/gpio-mux.yaml b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
index ef7e33ec85d4..199792d42323 100644
--- a/Documentation/devicetree/bindings/mux/gpio-mux.yaml
+++ b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
@@ -25,6 +25,13 @@ properties:
description:
List of gpios used to control the multiplexer, least significant bit first.
+ enable-gpios:
+ description:
+ Optional GPIO to enable the multiplexer. When present, the mux will be
+ disabled before changing address lines and re-enabled after to prevent
+ glitches. Required for MUX_IDLE_DISCONNECT idle-state.
+ maxItems: 1
+
mux-supply:
description:
Regulator to power on the multiplexer.
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v3 2/4] mux: gpio-mux: add support for enable GPIO
2026-01-15 12:18 [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404 Antoniu Miclaus
2026-01-15 12:18 ` [PATCH v3 1/4] dt-bindings: mux: gpio-mux: add enable-gpios support Antoniu Miclaus
@ 2026-01-15 12:18 ` Antoniu Miclaus
2026-01-15 12:18 ` [PATCH v3 3/4] dt-bindings: mux: gpio-mux: add adi,adg2404 support Antoniu Miclaus
` (2 subsequent siblings)
4 siblings, 0 replies; 19+ messages in thread
From: Antoniu Miclaus @ 2026-01-15 12:18 UTC (permalink / raw)
To: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Antoniu Miclaus, Srinivas Kandagatla, Linus Walleij,
Bartosz Golaszewski, David Lechner, devicetree, linux-kernel
Add support for an optional enable GPIO to the gpio-mux driver. This
allows the mux to be disabled before changing address lines and
re-enabled after, preventing glitches that could briefly activate
unintended channels during transitions.
The enable GPIO is optional and the driver maintains backward
compatibility with existing gpio-mux users.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
changes in v3:
* new patch - extend gpio-mux instead of standalone driver approach
---
drivers/mux/gpio.c | 32 +++++++++++++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
index 4cc3202c58f3..93487483e81f 100644
--- a/drivers/mux/gpio.c
+++ b/drivers/mux/gpio.c
@@ -19,6 +19,7 @@
struct mux_gpio {
struct gpio_descs *gpios;
+ struct gpio_desc *enable;
};
static int mux_gpio_set(struct mux_control *mux, int state)
@@ -27,10 +28,28 @@ static int mux_gpio_set(struct mux_control *mux, int state)
DECLARE_BITMAP(values, BITS_PER_TYPE(state));
u32 value = state;
+ if (state == MUX_IDLE_DISCONNECT) {
+ if (mux_gpio->enable)
+ gpiod_set_value_cansleep(mux_gpio->enable, 0);
+ return 0;
+ }
+
+ if (mux_gpio->enable) {
+ /*
+ * Disable the mux before changing address lines to prevent
+ * glitches. Changing address while enabled could briefly
+ * activate an unintended channel during the transition.
+ */
+ gpiod_set_value_cansleep(mux_gpio->enable, 0);
+ }
+
bitmap_from_arr32(values, &value, BITS_PER_TYPE(value));
gpiod_multi_set_value_cansleep(mux_gpio->gpios, values);
+ if (mux_gpio->enable)
+ gpiod_set_value_cansleep(mux_gpio->enable, 1);
+
return 0;
}
@@ -71,9 +90,20 @@ static int mux_gpio_probe(struct platform_device *pdev)
WARN_ON(pins != mux_gpio->gpios->ndescs);
mux_chip->mux->states = BIT(pins);
+ mux_gpio->enable = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
+ if (IS_ERR(mux_gpio->enable))
+ return dev_err_probe(dev, PTR_ERR(mux_gpio->enable),
+ "failed to get enable gpio\n");
+
ret = device_property_read_u32(dev, "idle-state", (u32 *)&idle_state);
if (ret >= 0 && idle_state != MUX_IDLE_AS_IS) {
- if (idle_state < 0 || idle_state >= mux_chip->mux->states) {
+ if (idle_state == MUX_IDLE_DISCONNECT) {
+ if (!mux_gpio->enable) {
+ dev_err(dev,
+ "invalid idle-state (MUX_IDLE_DISCONNECT requires enable-gpios)\n");
+ return -EINVAL;
+ }
+ } else if (idle_state < 0 || idle_state >= mux_chip->mux->states) {
dev_err(dev, "invalid idle-state %u\n", idle_state);
return -EINVAL;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v3 3/4] dt-bindings: mux: gpio-mux: add adi,adg2404 support
2026-01-15 12:18 [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404 Antoniu Miclaus
2026-01-15 12:18 ` [PATCH v3 1/4] dt-bindings: mux: gpio-mux: add enable-gpios support Antoniu Miclaus
2026-01-15 12:18 ` [PATCH v3 2/4] mux: gpio-mux: add support for enable GPIO Antoniu Miclaus
@ 2026-01-15 12:18 ` Antoniu Miclaus
2026-01-16 8:29 ` Krzysztof Kozlowski
2026-01-15 12:18 ` [PATCH v3 4/4] " Antoniu Miclaus
2026-01-16 8:37 ` [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404 Krzysztof Kozlowski
4 siblings, 1 reply; 19+ messages in thread
From: Antoniu Miclaus @ 2026-01-15 12:18 UTC (permalink / raw)
To: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Antoniu Miclaus, Srinivas Kandagatla, Johan Hovold,
Bartosz Golaszewski, David Lechner, devicetree, linux-kernel
Add adi,adg2404 as a compatible string. The ADG2404 is a 4:1 analog
multiplexer that uses the enable-gpios feature.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
changes in v3:
* integrate with gpio-mux bindings instead of separate adi,adg2404.yaml
---
.../devicetree/bindings/mux/gpio-mux.yaml | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mux/gpio-mux.yaml b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
index 199792d42323..f5866b9f46dd 100644
--- a/Documentation/devicetree/bindings/mux/gpio-mux.yaml
+++ b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
@@ -19,7 +19,9 @@ description: |+
properties:
compatible:
- const: gpio-mux
+ enum:
+ - gpio-mux
+ - adi,adg2404
mux-gpios:
description:
@@ -107,4 +109,19 @@ examples:
};
};
};
+
+ - |
+ /* ADG2404 4:1 multiplexer with enable GPIO */
+ #include <dt-bindings/gpio/gpio.h>
+
+ mux-controller {
+ compatible = "adi,adg2404";
+ #mux-control-cells = <0>;
+
+ mux-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>,
+ <&gpio 2 GPIO_ACTIVE_HIGH>;
+ enable-gpios = <&gpio 3 GPIO_ACTIVE_HIGH>;
+
+ idle-state = <0>; /* Select channel S1 when idle */
+ };
...
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v3 4/4] mux: gpio-mux: add adi,adg2404 support
2026-01-15 12:18 [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404 Antoniu Miclaus
` (2 preceding siblings ...)
2026-01-15 12:18 ` [PATCH v3 3/4] dt-bindings: mux: gpio-mux: add adi,adg2404 support Antoniu Miclaus
@ 2026-01-15 12:18 ` Antoniu Miclaus
2026-01-16 8:32 ` Krzysztof Kozlowski
2026-01-16 8:37 ` [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404 Krzysztof Kozlowski
4 siblings, 1 reply; 19+ messages in thread
From: Antoniu Miclaus @ 2026-01-15 12:18 UTC (permalink / raw)
To: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Antoniu Miclaus, Srinivas Kandagatla, Johan Hovold,
Bartosz Golaszewski, Linus Walleij, David Lechner, devicetree,
linux-kernel
Add adi,adg2404 to the compatible list. The ADG2404 is a 4:1 analog
multiplexer that benefits from the enable GPIO support to prevent
glitches during channel transitions.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
changes in v3:
* integrate with gpio-mux driver instead of standalone adg2404 driver
---
drivers/mux/gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
index 93487483e81f..bd8f0c617dd6 100644
--- a/drivers/mux/gpio.c
+++ b/drivers/mux/gpio.c
@@ -59,6 +59,7 @@ static const struct mux_control_ops mux_gpio_ops = {
static const struct of_device_id mux_gpio_dt_ids[] = {
{ .compatible = "gpio-mux", },
+ { .compatible = "adi,adg2404", },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, mux_gpio_dt_ids);
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v3 3/4] dt-bindings: mux: gpio-mux: add adi,adg2404 support
2026-01-15 12:18 ` [PATCH v3 3/4] dt-bindings: mux: gpio-mux: add adi,adg2404 support Antoniu Miclaus
@ 2026-01-16 8:29 ` Krzysztof Kozlowski
2026-01-16 8:34 ` Krzysztof Kozlowski
0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-16 8:29 UTC (permalink / raw)
To: Antoniu Miclaus
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Johan Hovold, Bartosz Golaszewski,
David Lechner, devicetree, linux-kernel
On Thu, Jan 15, 2026 at 02:18:21PM +0200, Antoniu Miclaus wrote:
> Add adi,adg2404 as a compatible string. The ADG2404 is a 4:1 analog
> multiplexer that uses the enable-gpios feature.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> changes in v3:
> * integrate with gpio-mux bindings instead of separate adi,adg2404.yaml
> ---
> .../devicetree/bindings/mux/gpio-mux.yaml | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mux/gpio-mux.yaml b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
> index 199792d42323..f5866b9f46dd 100644
> --- a/Documentation/devicetree/bindings/mux/gpio-mux.yaml
> +++ b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
> @@ -19,7 +19,9 @@ description: |+
>
> properties:
> compatible:
> - const: gpio-mux
> + enum:
> + - gpio-mux
> + - adi,adg2404
I do not understand why this was placed in gpio-mux. You have a strictly
defined hardware, with known muxes, not a flexible semi-software
binding.
Otherwise please explain: why do you have both 0 and 1 cells?
This is supposed to be in its own binding.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: mux: gpio-mux: add enable-gpios support
2026-01-15 12:18 ` [PATCH v3 1/4] dt-bindings: mux: gpio-mux: add enable-gpios support Antoniu Miclaus
@ 2026-01-16 8:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-16 8:30 UTC (permalink / raw)
To: Antoniu Miclaus
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, David Lechner, Bartosz Golaszewski,
devicetree, linux-kernel
On Thu, Jan 15, 2026 at 02:18:19PM +0200, Antoniu Miclaus wrote:
> Add support for an optional enable GPIO that allows the multiplexer
> to be disabled.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> changes in v3:
> * new patch - extend gpio-mux instead of standalone driver approach
> ---
> Documentation/devicetree/bindings/mux/gpio-mux.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mux/gpio-mux.yaml b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
> index ef7e33ec85d4..199792d42323 100644
> --- a/Documentation/devicetree/bindings/mux/gpio-mux.yaml
> +++ b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
> @@ -25,6 +25,13 @@ properties:
> description:
> List of gpios used to control the multiplexer, least significant bit first.
>
> + enable-gpios:
> + description:
> + Optional GPIO to enable the multiplexer. When present, the mux will be
> + disabled before changing address lines and re-enabled after to prevent
> + glitches. Required for MUX_IDLE_DISCONNECT idle-state.
Where is any DTS user of such gpio-mux with enable-gpios?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 4/4] mux: gpio-mux: add adi,adg2404 support
2026-01-15 12:18 ` [PATCH v3 4/4] " Antoniu Miclaus
@ 2026-01-16 8:32 ` Krzysztof Kozlowski
2026-01-16 8:34 ` Krzysztof Kozlowski
2026-01-16 9:48 ` Miclaus, Antoniu
0 siblings, 2 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-16 8:32 UTC (permalink / raw)
To: Antoniu Miclaus
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Johan Hovold, Bartosz Golaszewski,
Linus Walleij, David Lechner, devicetree, linux-kernel
On Thu, Jan 15, 2026 at 02:18:22PM +0200, Antoniu Miclaus wrote:
> Add adi,adg2404 to the compatible list. The ADG2404 is a 4:1 analog
> multiplexer that benefits from the enable GPIO support to prevent
> glitches during channel transitions.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> changes in v3:
> * integrate with gpio-mux driver instead of standalone adg2404 driver
> ---
> drivers/mux/gpio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
> index 93487483e81f..bd8f0c617dd6 100644
> --- a/drivers/mux/gpio.c
> +++ b/drivers/mux/gpio.c
> @@ -59,6 +59,7 @@ static const struct mux_control_ops mux_gpio_ops = {
>
> static const struct of_device_id mux_gpio_dt_ids[] = {
> { .compatible = "gpio-mux", },
> + { .compatible = "adi,adg2404", },
Why do you need the compatible? I do not understand this patchset. You
are saying you integrate it into gpio-mux, but what you did is to
duplicate the compatible and binding.
Half of your patches are not necessary, you only needed to add
enable-gpios to gpio-mux with argument that ADG2404 can use such binding
(in complete/full/proper way).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 3/4] dt-bindings: mux: gpio-mux: add adi,adg2404 support
2026-01-16 8:29 ` Krzysztof Kozlowski
@ 2026-01-16 8:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-16 8:34 UTC (permalink / raw)
To: Antoniu Miclaus
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Johan Hovold, Bartosz Golaszewski,
David Lechner, devicetree, linux-kernel
On 16/01/2026 09:29, Krzysztof Kozlowski wrote:
> On Thu, Jan 15, 2026 at 02:18:21PM +0200, Antoniu Miclaus wrote:
>> Add adi,adg2404 as a compatible string. The ADG2404 is a 4:1 analog
>> multiplexer that uses the enable-gpios feature.
>>
>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
>> ---
>> changes in v3:
>> * integrate with gpio-mux bindings instead of separate adi,adg2404.yaml
>> ---
>> .../devicetree/bindings/mux/gpio-mux.yaml | 19 ++++++++++++++++++-
>> 1 file changed, 18 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mux/gpio-mux.yaml b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
>> index 199792d42323..f5866b9f46dd 100644
>> --- a/Documentation/devicetree/bindings/mux/gpio-mux.yaml
>> +++ b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
>> @@ -19,7 +19,9 @@ description: |+
>>
>> properties:
>> compatible:
>> - const: gpio-mux
>> + enum:
>> + - gpio-mux
>> + - adi,adg2404
>
> I do not understand why this was placed in gpio-mux. You have a strictly
> defined hardware, with known muxes, not a flexible semi-software
> binding.
>
> Otherwise please explain: why do you have both 0 and 1 cells?
>
> This is supposed to be in its own binding.
After reading further patches - this patch does not make sense, but it
should not be its own binding. Rob at v2 gave you advice what should be
done.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 4/4] mux: gpio-mux: add adi,adg2404 support
2026-01-16 8:32 ` Krzysztof Kozlowski
@ 2026-01-16 8:34 ` Krzysztof Kozlowski
2026-01-16 9:48 ` Miclaus, Antoniu
1 sibling, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-16 8:34 UTC (permalink / raw)
To: Antoniu Miclaus
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Johan Hovold, Bartosz Golaszewski,
Linus Walleij, David Lechner, devicetree, linux-kernel
On 16/01/2026 09:32, Krzysztof Kozlowski wrote:
> On Thu, Jan 15, 2026 at 02:18:22PM +0200, Antoniu Miclaus wrote:
>> Add adi,adg2404 to the compatible list. The ADG2404 is a 4:1 analog
>> multiplexer that benefits from the enable GPIO support to prevent
>> glitches during channel transitions.
>>
>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
>> ---
>> changes in v3:
>> * integrate with gpio-mux driver instead of standalone adg2404 driver
>> ---
>> drivers/mux/gpio.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
>> index 93487483e81f..bd8f0c617dd6 100644
>> --- a/drivers/mux/gpio.c
>> +++ b/drivers/mux/gpio.c
>> @@ -59,6 +59,7 @@ static const struct mux_control_ops mux_gpio_ops = {
>>
>> static const struct of_device_id mux_gpio_dt_ids[] = {
>> { .compatible = "gpio-mux", },
>> + { .compatible = "adi,adg2404", },
>
> Why do you need the compatible? I do not understand this patchset. You
> are saying you integrate it into gpio-mux, but what you did is to
> duplicate the compatible and binding.
>
> Half of your patches are not necessary, you only needed to add
> enable-gpios to gpio-mux with argument that ADG2404 can use such binding
> (in complete/full/proper way).
... and Rob at v2 asked already that...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404
2026-01-15 12:18 [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404 Antoniu Miclaus
` (3 preceding siblings ...)
2026-01-15 12:18 ` [PATCH v3 4/4] " Antoniu Miclaus
@ 2026-01-16 8:37 ` Krzysztof Kozlowski
2026-01-16 9:00 ` Johan Hovold
4 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-16 8:37 UTC (permalink / raw)
To: Antoniu Miclaus
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Johan Hovold, David Lechner, devicetree,
linux-kernel
On Thu, Jan 15, 2026 at 02:18:18PM +0200, Antoniu Miclaus wrote:
> This series extends the gpio-mux driver with optional enable GPIO support
> to prevent glitches during channel transitions, then adds support for the
> Analog Devices ADG2404 multiplexer as the first user of this feature.
>
> The enable GPIO allows the multiplexer to be disabled before changing
> address lines and re-enabled after, preventing brief activation of
> unintended channels during transitions. This is particularly important
> for precision analog applications.
>
> The ADG2404 is a 4:1 analog multiplexer with low 0.62Ω on-resistance
> that requires this enable GPIO functionality for glitch-free operation.
>
> Changes in v3:
> * Extend gpio-mux driver instead of creating standalone adg2404 driver
> * Make enable GPIO optional for backward compatibility
> * Add MUX_IDLE_DISCONNECT support via enable GPIO
You are developing on some old kernel. You got stale Cc list of at least
three people! How could you for example get "johan+linaro@kernel.org" -
from which maintainer entry - but that at least is not bouncing like two
others.
You must use get_maintainers, not custom templates with fixed outdated
addresses.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404
2026-01-16 8:37 ` [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404 Krzysztof Kozlowski
@ 2026-01-16 9:00 ` Johan Hovold
2026-01-16 9:39 ` Miclaus, Antoniu
0 siblings, 1 reply; 19+ messages in thread
From: Johan Hovold @ 2026-01-16 9:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Antoniu Miclaus, Peter Rosin, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Johan Hovold, David Lechner,
devicetree, linux-kernel
On Fri, Jan 16, 2026 at 09:37:36AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Jan 15, 2026 at 02:18:18PM +0200, Antoniu Miclaus wrote:
> > This series extends the gpio-mux driver with optional enable GPIO support
> > to prevent glitches during channel transitions, then adds support for the
> > Analog Devices ADG2404 multiplexer as the first user of this feature.
> >
> > The enable GPIO allows the multiplexer to be disabled before changing
> > address lines and re-enabled after, preventing brief activation of
> > unintended channels during transitions. This is particularly important
> > for precision analog applications.
> >
> > The ADG2404 is a 4:1 analog multiplexer with low 0.62Ω on-resistance
> > that requires this enable GPIO functionality for glitch-free operation.
> >
> > Changes in v3:
> > * Extend gpio-mux driver instead of creating standalone adg2404 driver
> > * Make enable GPIO optional for backward compatibility
> > * Add MUX_IDLE_DISCONNECT support via enable GPIO
>
> You are developing on some old kernel. You got stale Cc list of at least
> three people! How could you for example get "johan+linaro@kernel.org" -
> from which maintainer entry - but that at least is not bouncing like two
> others.
Probably from using get_maintainer.pl --git:
$ scripts/get_maintainer.pl --git drivers/mux/gpio.c
Peter Rosin <peda@axentia.se> (maintainer:MULTIPLEXER SUBSYSTEM)
Srinivas Kandagatla <srini@kernel.org> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:5/6=83%)
Krzysztof Kozlowski <krzk@kernel.org> (commit_signer:1/2=50%)
Bartosz Golaszewski <brgl@kernel.org> (commit_signer:1/2=50%)
David Lechner <dlechner@baylibre.com> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:1/6=17%,removed_lines:3/3=100%)
Johan Hovold <johan+linaro@kernel.org> (commit_signer:1/2=50%)
linux-kernel@vger.kernel.org (open list)
MULTIPLEXER SUBSYSTEM status: Odd Fixes
A recent mailmap is indeed needed to remap Bartosz's old address,
though.
Johan
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404
2026-01-16 9:00 ` Johan Hovold
@ 2026-01-16 9:39 ` Miclaus, Antoniu
2026-01-16 10:31 ` Krzysztof Kozlowski
0 siblings, 1 reply; 19+ messages in thread
From: Miclaus, Antoniu @ 2026-01-16 9:39 UTC (permalink / raw)
To: Johan Hovold, Krzysztof Kozlowski
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Johan Hovold, David Lechner,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Johan Hovold <johan@kernel.org>
> Sent: Friday, January 16, 2026 11:01 AM
> To: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; Peter Rosin
> <peda@axentia.se>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Srinivas
> Kandagatla <srini@kernel.org>; Johan Hovold <johan+linaro@kernel.org>;
> David Lechner <dlechner@baylibre.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and
> ADG2404
>
> [External]
>
> On Fri, Jan 16, 2026 at 09:37:36AM +0100, Krzysztof Kozlowski wrote:
> > On Thu, Jan 15, 2026 at 02:18:18PM +0200, Antoniu Miclaus wrote:
> > > This series extends the gpio-mux driver with optional enable GPIO support
> > > to prevent glitches during channel transitions, then adds support for the
> > > Analog Devices ADG2404 multiplexer as the first user of this feature.
> > >
> > > The enable GPIO allows the multiplexer to be disabled before changing
> > > address lines and re-enabled after, preventing brief activation of
> > > unintended channels during transitions. This is particularly important
> > > for precision analog applications.
> > >
> > > The ADG2404 is a 4:1 analog multiplexer with low 0.62Ω on-resistance
> > > that requires this enable GPIO functionality for glitch-free operation.
> > >
> > > Changes in v3:
> > > * Extend gpio-mux driver instead of creating standalone adg2404 driver
> > > * Make enable GPIO optional for backward compatibility
> > > * Add MUX_IDLE_DISCONNECT support via enable GPIO
> >
> > You are developing on some old kernel. You got stale Cc list of at least
> > three people! How could you for example get "johan+linaro@kernel.org" -
> > from which maintainer entry - but that at least is not bouncing like two
> > others.
>
> Probably from using get_maintainer.pl --git:
>
> $ scripts/get_maintainer.pl --git drivers/mux/gpio.c
> Peter Rosin <peda@axentia.se> (maintainer:MULTIPLEXER
> SUBSYSTEM)
> Srinivas Kandagatla <srini@kernel.org>
> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:5/6=83%)
> Krzysztof Kozlowski <krzk@kernel.org> (commit_signer:1/2=50%)
> Bartosz Golaszewski <brgl@kernel.org> (commit_signer:1/2=50%)
> David Lechner <dlechner@baylibre.com>
> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:1/6=17%,removed
> _lines:3/3=100%)
> Johan Hovold <johan+linaro@kernel.org> (commit_signer:1/2=50%)
> linux-kernel@vger.kernel.org (open list)
> MULTIPLEXER SUBSYSTEM status: Odd Fixes
>
> A recent mailmap is indeed needed to remap Bartosz's old address,
> though.
>
Yes, I've used "--to-cmd='./scripts/get_maintainer.pl --norolestats" when sending the patches.
> Johan
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v3 4/4] mux: gpio-mux: add adi,adg2404 support
2026-01-16 8:32 ` Krzysztof Kozlowski
2026-01-16 8:34 ` Krzysztof Kozlowski
@ 2026-01-16 9:48 ` Miclaus, Antoniu
2026-01-16 10:42 ` Krzysztof Kozlowski
1 sibling, 1 reply; 19+ messages in thread
From: Miclaus, Antoniu @ 2026-01-16 9:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Johan Hovold, Bartosz Golaszewski,
Linus Walleij, David Lechner, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Friday, January 16, 2026 10:33 AM
> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>
> Cc: Peter Rosin <peda@axentia.se>; Rob Herring <robh@kernel.org>; Krzysztof
> Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> Srinivas Kandagatla <srini@kernel.org>; Johan Hovold
> <johan+linaro@kernel.org>; Bartosz Golaszewski
> <bartosz.golaszewski@linaro.org>; Linus Walleij <linus.walleij@linaro.org>;
> David Lechner <dlechner@baylibre.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v3 4/4] mux: gpio-mux: add adi,adg2404 support
>
> [External]
>
> On Thu, Jan 15, 2026 at 02:18:22PM +0200, Antoniu Miclaus wrote:
> > Add adi,adg2404 to the compatible list. The ADG2404 is a 4:1 analog
> > multiplexer that benefits from the enable GPIO support to prevent
> > glitches during channel transitions.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---
> > changes in v3:
> > * integrate with gpio-mux driver instead of standalone adg2404 driver
> > ---
> > drivers/mux/gpio.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
> > index 93487483e81f..bd8f0c617dd6 100644
> > --- a/drivers/mux/gpio.c
> > +++ b/drivers/mux/gpio.c
> > @@ -59,6 +59,7 @@ static const struct mux_control_ops mux_gpio_ops = {
> >
> > static const struct of_device_id mux_gpio_dt_ids[] = {
> > { .compatible = "gpio-mux", },
> > + { .compatible = "adi,adg2404", },
>
> Why do you need the compatible? I do not understand this patchset. You
> are saying you integrate it into gpio-mux, but what you did is to
> duplicate the compatible and binding.
>
> Half of your patches are not necessary, you only needed to add
> enable-gpios to gpio-mux with argument that ADG2404 can use such binding
> (in complete/full/proper way).
I am a bit confused on how can I emphasize to the users explicitly:
"Hey, you can use adg2404 directly with gpio-mux"
The same issue I had with adg1712 series which can be used straight away with gpio-mux.
If there are people/customers looking for adg2404/adg1712 there should be a hint somewhere.
Sorry for my poor knowledge on this, but I need some guidance on what the best approach is to solve it.
Thanks,
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404
2026-01-16 9:39 ` Miclaus, Antoniu
@ 2026-01-16 10:31 ` Krzysztof Kozlowski
2026-01-16 15:26 ` Miclaus, Antoniu
0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-16 10:31 UTC (permalink / raw)
To: Miclaus, Antoniu, Johan Hovold
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Johan Hovold, David Lechner,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
On 16/01/2026 10:39, Miclaus, Antoniu wrote:
>> -----Original Message-----
>> From: Johan Hovold <johan@kernel.org>
>> Sent: Friday, January 16, 2026 11:01 AM
>> To: Krzysztof Kozlowski <krzk@kernel.org>
>> Cc: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; Peter Rosin
>> <peda@axentia.se>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
>> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Srinivas
>> Kandagatla <srini@kernel.org>; Johan Hovold <johan+linaro@kernel.org>;
>> David Lechner <dlechner@baylibre.com>; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org
>> Subject: Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and
>> ADG2404
>>
>> [External]
>>
>> On Fri, Jan 16, 2026 at 09:37:36AM +0100, Krzysztof Kozlowski wrote:
>>> On Thu, Jan 15, 2026 at 02:18:18PM +0200, Antoniu Miclaus wrote:
>>>> This series extends the gpio-mux driver with optional enable GPIO support
>>>> to prevent glitches during channel transitions, then adds support for the
>>>> Analog Devices ADG2404 multiplexer as the first user of this feature.
>>>>
>>>> The enable GPIO allows the multiplexer to be disabled before changing
>>>> address lines and re-enabled after, preventing brief activation of
>>>> unintended channels during transitions. This is particularly important
>>>> for precision analog applications.
>>>>
>>>> The ADG2404 is a 4:1 analog multiplexer with low 0.62Ω on-resistance
>>>> that requires this enable GPIO functionality for glitch-free operation.
>>>>
>>>> Changes in v3:
>>>> * Extend gpio-mux driver instead of creating standalone adg2404 driver
>>>> * Make enable GPIO optional for backward compatibility
>>>> * Add MUX_IDLE_DISCONNECT support via enable GPIO
>>>
>>> You are developing on some old kernel. You got stale Cc list of at least
>>> three people! How could you for example get "johan+linaro@kernel.org" -
>>> from which maintainer entry - but that at least is not bouncing like two
>>> others.
>>
>> Probably from using get_maintainer.pl --git:
>>
>> $ scripts/get_maintainer.pl --git drivers/mux/gpio.c
>> Peter Rosin <peda@axentia.se> (maintainer:MULTIPLEXER
>> SUBSYSTEM)
>> Srinivas Kandagatla <srini@kernel.org>
>> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:5/6=83%)
>> Krzysztof Kozlowski <krzk@kernel.org> (commit_signer:1/2=50%)
>> Bartosz Golaszewski <brgl@kernel.org> (commit_signer:1/2=50%)
>> David Lechner <dlechner@baylibre.com>
>> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:1/6=17%,removed
>> _lines:3/3=100%)
>> Johan Hovold <johan+linaro@kernel.org> (commit_signer:1/2=50%)
>> linux-kernel@vger.kernel.org (open list)
>> MULTIPLEXER SUBSYSTEM status: Odd Fixes
>>
>> A recent mailmap is indeed needed to remap Bartosz's old address,
>> though.
>>
>
> Yes, I've used "--to-cmd='./scripts/get_maintainer.pl --norolestats" when sending the patches.
Then how did you get non-working Bartosz and Linus' emails?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 4/4] mux: gpio-mux: add adi,adg2404 support
2026-01-16 9:48 ` Miclaus, Antoniu
@ 2026-01-16 10:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-16 10:42 UTC (permalink / raw)
To: Miclaus, Antoniu
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Johan Hovold, Bartosz Golaszewski,
Linus Walleij, David Lechner, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
On 16/01/2026 10:48, Miclaus, Antoniu wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Friday, January 16, 2026 10:33 AM
>> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>
>> Cc: Peter Rosin <peda@axentia.se>; Rob Herring <robh@kernel.org>; Krzysztof
>> Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
>> Srinivas Kandagatla <srini@kernel.org>; Johan Hovold
>> <johan+linaro@kernel.org>; Bartosz Golaszewski
>> <bartosz.golaszewski@linaro.org>; Linus Walleij <linus.walleij@linaro.org>;
>> David Lechner <dlechner@baylibre.com>; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org
>> Subject: Re: [PATCH v3 4/4] mux: gpio-mux: add adi,adg2404 support
>>
>> [External]
>>
>> On Thu, Jan 15, 2026 at 02:18:22PM +0200, Antoniu Miclaus wrote:
>>> Add adi,adg2404 to the compatible list. The ADG2404 is a 4:1 analog
>>> multiplexer that benefits from the enable GPIO support to prevent
>>> glitches during channel transitions.
>>>
>>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
>>> ---
>>> changes in v3:
>>> * integrate with gpio-mux driver instead of standalone adg2404 driver
>>> ---
>>> drivers/mux/gpio.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
>>> index 93487483e81f..bd8f0c617dd6 100644
>>> --- a/drivers/mux/gpio.c
>>> +++ b/drivers/mux/gpio.c
>>> @@ -59,6 +59,7 @@ static const struct mux_control_ops mux_gpio_ops = {
>>>
>>> static const struct of_device_id mux_gpio_dt_ids[] = {
>>> { .compatible = "gpio-mux", },
>>> + { .compatible = "adi,adg2404", },
>>
>> Why do you need the compatible? I do not understand this patchset. You
>> are saying you integrate it into gpio-mux, but what you did is to
>> duplicate the compatible and binding.
>>
>> Half of your patches are not necessary, you only needed to add
>> enable-gpios to gpio-mux with argument that ADG2404 can use such binding
>> (in complete/full/proper way).
>
> I am a bit confused on how can I emphasize to the users explicitly:
> "Hey, you can use adg2404 directly with gpio-mux"
> The same issue I had with adg1712 series which can be used straight away with gpio-mux.
> If there are people/customers looking for adg2404/adg1712 there should be a hint somewhere.
This is a bit different problem. Why would we care about message to
customers? Following such approach this driver and dozen of others might
have soon 1000 entries for every possible device which is supported by it.
IMO the best way is to submit good DTS using this with a comment that it
IS ADG-foobar which also has other benefits - helps reviewing of
bindings and driver. I would accept also a short/concise list of device
names/models in the binding description.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404
2026-01-16 10:31 ` Krzysztof Kozlowski
@ 2026-01-16 15:26 ` Miclaus, Antoniu
2026-01-16 16:06 ` Krzysztof Kozlowski
0 siblings, 1 reply; 19+ messages in thread
From: Miclaus, Antoniu @ 2026-01-16 15:26 UTC (permalink / raw)
To: Krzysztof Kozlowski, Johan Hovold
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Johan Hovold, David Lechner,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
--
Antoniu Miclăuş
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Friday, January 16, 2026 12:32 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; Johan Hovold
> <johan@kernel.org>
> Cc: Peter Rosin <peda@axentia.se>; Rob Herring <robh@kernel.org>; Krzysztof
> Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> Srinivas Kandagatla <srini@kernel.org>; Johan Hovold
> <johan+linaro@kernel.org>; David Lechner <dlechner@baylibre.com>;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and
> ADG2404
>
> [External]
>
> On 16/01/2026 10:39, Miclaus, Antoniu wrote:
> >> -----Original Message-----
> >> From: Johan Hovold <johan@kernel.org>
> >> Sent: Friday, January 16, 2026 11:01 AM
> >> To: Krzysztof Kozlowski <krzk@kernel.org>
> >> Cc: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; Peter Rosin
> >> <peda@axentia.se>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> >> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Srinivas
> >> Kandagatla <srini@kernel.org>; Johan Hovold <johan+linaro@kernel.org>;
> >> David Lechner <dlechner@baylibre.com>; devicetree@vger.kernel.org;
> linux-
> >> kernel@vger.kernel.org
> >> Subject: Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and
> >> ADG2404
> >>
> >> [External]
> >>
> >> On Fri, Jan 16, 2026 at 09:37:36AM +0100, Krzysztof Kozlowski wrote:
> >>> On Thu, Jan 15, 2026 at 02:18:18PM +0200, Antoniu Miclaus wrote:
> >>>> This series extends the gpio-mux driver with optional enable GPIO
> support
> >>>> to prevent glitches during channel transitions, then adds support for the
> >>>> Analog Devices ADG2404 multiplexer as the first user of this feature.
> >>>>
> >>>> The enable GPIO allows the multiplexer to be disabled before changing
> >>>> address lines and re-enabled after, preventing brief activation of
> >>>> unintended channels during transitions. This is particularly important
> >>>> for precision analog applications.
> >>>>
> >>>> The ADG2404 is a 4:1 analog multiplexer with low 0.62Ω on-resistance
> >>>> that requires this enable GPIO functionality for glitch-free operation.
> >>>>
> >>>> Changes in v3:
> >>>> * Extend gpio-mux driver instead of creating standalone adg2404 driver
> >>>> * Make enable GPIO optional for backward compatibility
> >>>> * Add MUX_IDLE_DISCONNECT support via enable GPIO
> >>>
> >>> You are developing on some old kernel. You got stale Cc list of at least
> >>> three people! How could you for example get "johan+linaro@kernel.org" -
> >>> from which maintainer entry - but that at least is not bouncing like two
> >>> others.
> >>
> >> Probably from using get_maintainer.pl --git:
> >>
> >> $ scripts/get_maintainer.pl --git drivers/mux/gpio.c
> >> Peter Rosin <peda@axentia.se> (maintainer:MULTIPLEXER
> >> SUBSYSTEM)
> >> Srinivas Kandagatla <srini@kernel.org>
> >> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:5/6=83%)
> >> Krzysztof Kozlowski <krzk@kernel.org> (commit_signer:1/2=50%)
> >> Bartosz Golaszewski <brgl@kernel.org> (commit_signer:1/2=50%)
> >> David Lechner <dlechner@baylibre.com>
> >>
> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:1/6=17%,removed
> >> _lines:3/3=100%)
> >> Johan Hovold <johan+linaro@kernel.org> (commit_signer:1/2=50%)
> >> linux-kernel@vger.kernel.org (open list)
> >> MULTIPLEXER SUBSYSTEM status: Odd Fixes
> >>
> >> A recent mailmap is indeed needed to remap Bartosz's old address,
> >> though.
> >>
> >
> > Yes, I've used "--to-cmd='./scripts/get_maintainer.pl --norolestats" when
> sending the patches.
>
> Then how did you get non-working Bartosz and Linus' emails?
I am on torvalds/linux latest master branch now. Here is the output of ./scripts/get_maintainer.pl --norolestats:
Peter Rosin <peda@axentia.se>
Rob Herring <robh@kernel.org>
Krzysztof Kozlowski <krzk+dt@kernel.org>
Conor Dooley <conor+dt@kernel.org>
Antoniu Miclaus <antoniu.miclaus@analog.com>
Srinivas Kandagatla <srini@kernel.org>
Bartosz Golaszewski <brgl@kernel.org>
David Lechner <dlechner@baylibre.com>
devicetree@vger.kernel.org
linux-kernel@vger.kernel.org
Regards,
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404
2026-01-16 15:26 ` Miclaus, Antoniu
@ 2026-01-16 16:06 ` Krzysztof Kozlowski
2026-01-16 16:17 ` Miclaus, Antoniu
0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-16 16:06 UTC (permalink / raw)
To: Miclaus, Antoniu, Johan Hovold
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Johan Hovold, David Lechner,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
On 16/01/2026 16:26, Miclaus, Antoniu wrote:
>
>
> --
> Antoniu Miclăuş
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Friday, January 16, 2026 12:32 PM
>> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; Johan Hovold
>> <johan@kernel.org>
>> Cc: Peter Rosin <peda@axentia.se>; Rob Herring <robh@kernel.org>; Krzysztof
>> Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
>> Srinivas Kandagatla <srini@kernel.org>; Johan Hovold
>> <johan+linaro@kernel.org>; David Lechner <dlechner@baylibre.com>;
>> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and
>> ADG2404
>>
>> [External]
>>
>> On 16/01/2026 10:39, Miclaus, Antoniu wrote:
>>>> -----Original Message-----
>>>> From: Johan Hovold <johan@kernel.org>
>>>> Sent: Friday, January 16, 2026 11:01 AM
>>>> To: Krzysztof Kozlowski <krzk@kernel.org>
>>>> Cc: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; Peter Rosin
>>>> <peda@axentia.se>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
>>>> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Srinivas
>>>> Kandagatla <srini@kernel.org>; Johan Hovold <johan+linaro@kernel.org>;
>>>> David Lechner <dlechner@baylibre.com>; devicetree@vger.kernel.org;
>> linux-
>>>> kernel@vger.kernel.org
>>>> Subject: Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and
>>>> ADG2404
>>>>
>>>> [External]
>>>>
>>>> On Fri, Jan 16, 2026 at 09:37:36AM +0100, Krzysztof Kozlowski wrote:
>>>>> On Thu, Jan 15, 2026 at 02:18:18PM +0200, Antoniu Miclaus wrote:
>>>>>> This series extends the gpio-mux driver with optional enable GPIO
>> support
>>>>>> to prevent glitches during channel transitions, then adds support for the
>>>>>> Analog Devices ADG2404 multiplexer as the first user of this feature.
>>>>>>
>>>>>> The enable GPIO allows the multiplexer to be disabled before changing
>>>>>> address lines and re-enabled after, preventing brief activation of
>>>>>> unintended channels during transitions. This is particularly important
>>>>>> for precision analog applications.
>>>>>>
>>>>>> The ADG2404 is a 4:1 analog multiplexer with low 0.62Ω on-resistance
>>>>>> that requires this enable GPIO functionality for glitch-free operation.
>>>>>>
>>>>>> Changes in v3:
>>>>>> * Extend gpio-mux driver instead of creating standalone adg2404 driver
>>>>>> * Make enable GPIO optional for backward compatibility
>>>>>> * Add MUX_IDLE_DISCONNECT support via enable GPIO
>>>>>
>>>>> You are developing on some old kernel. You got stale Cc list of at least
>>>>> three people! How could you for example get "johan+linaro@kernel.org" -
>>>>> from which maintainer entry - but that at least is not bouncing like two
>>>>> others.
>>>>
>>>> Probably from using get_maintainer.pl --git:
>>>>
>>>> $ scripts/get_maintainer.pl --git drivers/mux/gpio.c
>>>> Peter Rosin <peda@axentia.se> (maintainer:MULTIPLEXER
>>>> SUBSYSTEM)
>>>> Srinivas Kandagatla <srini@kernel.org>
>>>> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:5/6=83%)
>>>> Krzysztof Kozlowski <krzk@kernel.org> (commit_signer:1/2=50%)
>>>> Bartosz Golaszewski <brgl@kernel.org> (commit_signer:1/2=50%)
>>>> David Lechner <dlechner@baylibre.com>
>>>>
>> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:1/6=17%,removed
>>>> _lines:3/3=100%)
>>>> Johan Hovold <johan+linaro@kernel.org> (commit_signer:1/2=50%)
>>>> linux-kernel@vger.kernel.org (open list)
>>>> MULTIPLEXER SUBSYSTEM status: Odd Fixes
>>>>
>>>> A recent mailmap is indeed needed to remap Bartosz's old address,
>>>> though.
>>>>
>>>
>>> Yes, I've used "--to-cmd='./scripts/get_maintainer.pl --norolestats" when
>> sending the patches.
>>
>> Then how did you get non-working Bartosz and Linus' emails?
>
> I am on torvalds/linux latest master branch now. Here is the output of ./scripts/get_maintainer.pl --norolestats:
> Peter Rosin <peda@axentia.se>
> Rob Herring <robh@kernel.org>
> Krzysztof Kozlowski <krzk+dt@kernel.org>
> Conor Dooley <conor+dt@kernel.org>
> Antoniu Miclaus <antoniu.miclaus@analog.com>
> Srinivas Kandagatla <srini@kernel.org>
> Bartosz Golaszewski <brgl@kernel.org>
Exactly. So why did you send it to:
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
and
Linus Walleij <linus.walleij@linaro.org>
I mean, this is the third time I am asking but you keep deflecting the
question with some sort of other data...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404
2026-01-16 16:06 ` Krzysztof Kozlowski
@ 2026-01-16 16:17 ` Miclaus, Antoniu
0 siblings, 0 replies; 19+ messages in thread
From: Miclaus, Antoniu @ 2026-01-16 16:17 UTC (permalink / raw)
To: Krzysztof Kozlowski, Johan Hovold
Cc: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Johan Hovold, David Lechner,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Friday, January 16, 2026 6:06 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; Johan Hovold
> <johan@kernel.org>
> Cc: Peter Rosin <peda@axentia.se>; Rob Herring <robh@kernel.org>; Krzysztof
> Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> Srinivas Kandagatla <srini@kernel.org>; Johan Hovold
> <johan+linaro@kernel.org>; David Lechner <dlechner@baylibre.com>;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and
> ADG2404
>
> [External]
>
> On 16/01/2026 16:26, Miclaus, Antoniu wrote:
> >
> >
> > --
> > Antoniu Miclăuş
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@kernel.org>
> >> Sent: Friday, January 16, 2026 12:32 PM
> >> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; Johan Hovold
> >> <johan@kernel.org>
> >> Cc: Peter Rosin <peda@axentia.se>; Rob Herring <robh@kernel.org>;
> Krzysztof
> >> Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> >> Srinivas Kandagatla <srini@kernel.org>; Johan Hovold
> >> <johan+linaro@kernel.org>; David Lechner <dlechner@baylibre.com>;
> >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and
> >> ADG2404
> >>
> >> [External]
> >>
> >> On 16/01/2026 10:39, Miclaus, Antoniu wrote:
> >>>> -----Original Message-----
> >>>> From: Johan Hovold <johan@kernel.org>
> >>>> Sent: Friday, January 16, 2026 11:01 AM
> >>>> To: Krzysztof Kozlowski <krzk@kernel.org>
> >>>> Cc: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; Peter Rosin
> >>>> <peda@axentia.se>; Rob Herring <robh@kernel.org>; Krzysztof
> Kozlowski
> >>>> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Srinivas
> >>>> Kandagatla <srini@kernel.org>; Johan Hovold
> <johan+linaro@kernel.org>;
> >>>> David Lechner <dlechner@baylibre.com>; devicetree@vger.kernel.org;
> >> linux-
> >>>> kernel@vger.kernel.org
> >>>> Subject: Re: [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support
> and
> >>>> ADG2404
> >>>>
> >>>> [External]
> >>>>
> >>>> On Fri, Jan 16, 2026 at 09:37:36AM +0100, Krzysztof Kozlowski wrote:
> >>>>> On Thu, Jan 15, 2026 at 02:18:18PM +0200, Antoniu Miclaus wrote:
> >>>>>> This series extends the gpio-mux driver with optional enable GPIO
> >> support
> >>>>>> to prevent glitches during channel transitions, then adds support for
> the
> >>>>>> Analog Devices ADG2404 multiplexer as the first user of this feature.
> >>>>>>
> >>>>>> The enable GPIO allows the multiplexer to be disabled before changing
> >>>>>> address lines and re-enabled after, preventing brief activation of
> >>>>>> unintended channels during transitions. This is particularly important
> >>>>>> for precision analog applications.
> >>>>>>
> >>>>>> The ADG2404 is a 4:1 analog multiplexer with low 0.62Ω on-resistance
> >>>>>> that requires this enable GPIO functionality for glitch-free operation.
> >>>>>>
> >>>>>> Changes in v3:
> >>>>>> * Extend gpio-mux driver instead of creating standalone adg2404
> driver
> >>>>>> * Make enable GPIO optional for backward compatibility
> >>>>>> * Add MUX_IDLE_DISCONNECT support via enable GPIO
> >>>>>
> >>>>> You are developing on some old kernel. You got stale Cc list of at least
> >>>>> three people! How could you for example get
> "johan+linaro@kernel.org" -
> >>>>> from which maintainer entry - but that at least is not bouncing like two
> >>>>> others.
> >>>>
> >>>> Probably from using get_maintainer.pl --git:
> >>>>
> >>>> $ scripts/get_maintainer.pl --git drivers/mux/gpio.c
> >>>> Peter Rosin <peda@axentia.se> (maintainer:MULTIPLEXER
> >>>> SUBSYSTEM)
> >>>> Srinivas Kandagatla <srini@kernel.org>
> >>>> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:5/6=83%)
> >>>> Krzysztof Kozlowski <krzk@kernel.org> (commit_signer:1/2=50%)
> >>>> Bartosz Golaszewski <brgl@kernel.org> (commit_signer:1/2=50%)
> >>>> David Lechner <dlechner@baylibre.com>
> >>>>
> >>
> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:1/6=17%,removed
> >>>> _lines:3/3=100%)
> >>>> Johan Hovold <johan+linaro@kernel.org> (commit_signer:1/2=50%)
> >>>> linux-kernel@vger.kernel.org (open list)
> >>>> MULTIPLEXER SUBSYSTEM status: Odd Fixes
> >>>>
> >>>> A recent mailmap is indeed needed to remap Bartosz's old address,
> >>>> though.
> >>>>
> >>>
> >>> Yes, I've used "--to-cmd='./scripts/get_maintainer.pl --norolestats" when
> >> sending the patches.
> >>
> >> Then how did you get non-working Bartosz and Linus' emails?
> >
> > I am on torvalds/linux latest master branch now. Here is the output of
> ./scripts/get_maintainer.pl --norolestats:
> > Peter Rosin <peda@axentia.se>
> > Rob Herring <robh@kernel.org>
> > Krzysztof Kozlowski <krzk+dt@kernel.org>
> > Conor Dooley <conor+dt@kernel.org>
> > Antoniu Miclaus <antoniu.miclaus@analog.com>
> > Srinivas Kandagatla <srini@kernel.org>
> > Bartosz Golaszewski <brgl@kernel.org>
>
> Exactly. So why did you send it to:
> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> and
> Linus Walleij <linus.walleij@linaro.org>
>
> I mean, this is the third time I am asking but you keep deflecting the
> question with some sort of other data...
I was on an older branch.
This should be fixed now.
Regards,
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2026-01-16 16:18 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-15 12:18 [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404 Antoniu Miclaus
2026-01-15 12:18 ` [PATCH v3 1/4] dt-bindings: mux: gpio-mux: add enable-gpios support Antoniu Miclaus
2026-01-16 8:30 ` Krzysztof Kozlowski
2026-01-15 12:18 ` [PATCH v3 2/4] mux: gpio-mux: add support for enable GPIO Antoniu Miclaus
2026-01-15 12:18 ` [PATCH v3 3/4] dt-bindings: mux: gpio-mux: add adi,adg2404 support Antoniu Miclaus
2026-01-16 8:29 ` Krzysztof Kozlowski
2026-01-16 8:34 ` Krzysztof Kozlowski
2026-01-15 12:18 ` [PATCH v3 4/4] " Antoniu Miclaus
2026-01-16 8:32 ` Krzysztof Kozlowski
2026-01-16 8:34 ` Krzysztof Kozlowski
2026-01-16 9:48 ` Miclaus, Antoniu
2026-01-16 10:42 ` Krzysztof Kozlowski
2026-01-16 8:37 ` [PATCH v3 0/4] mux: gpio-mux: add enable GPIO support and ADG2404 Krzysztof Kozlowski
2026-01-16 9:00 ` Johan Hovold
2026-01-16 9:39 ` Miclaus, Antoniu
2026-01-16 10:31 ` Krzysztof Kozlowski
2026-01-16 15:26 ` Miclaus, Antoniu
2026-01-16 16:06 ` Krzysztof Kozlowski
2026-01-16 16:17 ` Miclaus, Antoniu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox