From: Thierry Reding <thierry.reding@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Andrew Jeffery <andrew@codeconstruct.com.au>,
Linus Walleij <linusw@kernel.org>, Joel Stanley <joel@jms.id.au>,
Emil Renner Berthing <kernel@esmil.dk>,
Hal Feng <hal.feng@starfivetech.com>,
Chen Wang <unicorn_wang@outlook.com>,
Inochi Amaoto <inochiama@gmail.com>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Daniel Machon <daniel.machon@microchip.com>,
UNGLinuxDriver@microchip.com,
Jonathan Hunter <jonathanh@nvidia.com>,
Heiko Stuebner <heiko@sntech.de>,
Patrice Chotard <patrice.chotard@foss.st.com>,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, sophgo@lists.linux.dev,
linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 08/11] pinctrl: tegra-xusb: Return void in padctl enable/disable functions
Date: Fri, 16 Jan 2026 13:50:58 +0100 [thread overview]
Message-ID: <aWo0LESc5bIs1kHi@orome> (raw)
In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-8-a14572685cd3@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On Wed, Jan 14, 2026 at 04:30:09PM +0100, Krzysztof Kozlowski wrote:
> Make the padctl functions a bit simpler by returning void instead of
> always '0'. The callers - phy init/exit - still need to return 0, but
> these are smaller function without if/branching.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-01-16 12:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 15:30 [PATCH 00/11] pinctrl: Some code cleanup including guards Krzysztof Kozlowski
2026-01-14 15:30 ` [PATCH 01/11] pinctrl: aspeed: Cleanup header includes Krzysztof Kozlowski
2026-01-15 1:41 ` Andrew Jeffery
2026-01-14 15:30 ` [PATCH 02/11] pinctrl: starfive: jh7110-sys: " Krzysztof Kozlowski
2026-01-18 9:23 ` Hal Feng
2026-01-14 15:30 ` [PATCH 03/11] pinctrl: sophgo: " Krzysztof Kozlowski
2026-01-15 1:52 ` Inochi Amaoto
2026-01-14 15:30 ` [PATCH 04/11] pinctrl: amd: " Krzysztof Kozlowski
2026-01-14 15:30 ` [PATCH 05/11] pinctrl: aw9523: Simplify locking with guard() Krzysztof Kozlowski
2026-01-14 15:30 ` [PATCH 06/11] pinctrl: microchip-sgpio: " Krzysztof Kozlowski
2026-01-14 15:30 ` [PATCH 07/11] pinctrl: tb10x: " Krzysztof Kozlowski
2026-01-14 15:30 ` [PATCH 08/11] pinctrl: tegra-xusb: Return void in padctl enable/disable functions Krzysztof Kozlowski
2026-01-14 16:07 ` Jon Hunter
2026-01-16 12:50 ` Thierry Reding [this message]
2026-01-14 15:30 ` [PATCH 09/11] pinctrl: tegra-xusb: Simplify locking with guard() Krzysztof Kozlowski
2026-01-14 15:51 ` Jon Hunter
2026-01-14 16:01 ` Krzysztof Kozlowski
2026-01-14 15:30 ` [PATCH 10/11] pinctrl: rockchip: Simplify locking with scoped_guard() Krzysztof Kozlowski
2026-01-15 16:14 ` Heiko Stübner
2026-01-14 15:30 ` [PATCH 11/11] pinctrl: st: Annotate st_pinconf_dbg_show() as holding mutex Krzysztof Kozlowski
2026-01-14 17:19 ` Patrice CHOTARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWo0LESc5bIs1kHi@orome \
--to=thierry.reding@gmail.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@codeconstruct.com.au \
--cc=brgl@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=hal.feng@starfivetech.com \
--cc=heiko@sntech.de \
--cc=inochiama@gmail.com \
--cc=joel@jms.id.au \
--cc=jonathanh@nvidia.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=patrice.chotard@foss.st.com \
--cc=sophgo@lists.linux.dev \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox