From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jonas Jelonek <jelonek.jonas@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Bjørn Mork" <bjorn@mork.no>
Subject: Re: [PATCH net-next v5] net: sfp: extend SMBus support
Date: Fri, 16 Jan 2026 13:57:01 +0000 [thread overview]
Message-ID: <aWpDrdocUvuBt-gS@shell.armlinux.org.uk> (raw)
In-Reply-To: <20260116113105.244592-1-jelonek.jonas@gmail.com>
On Fri, Jan 16, 2026 at 11:31:05AM +0000, Jonas Jelonek wrote:
> + max_block_size = SFP_EEPROM_BLOCK_SIZE;
> + } else if (functionality & I2C_FUNC_SMBUS_BYTE_DATA) {
If we want to be fully flexible, then:
} else if (functionality & (I2C_FUNC_SMBUS_BYTE_DATA |
I2C_FUNC_SMBUS_I2C_BLOCK)) {
since if we only have SMBus I2C block, then everything is fine.
However, I suggest asking I2C people whether it's possible to have a
SMBUS that supports I2C block and/or word access but not byte access.
Is there a heirarchy to the SMBus capabilities.
Also, is it possible for SMBus to support different read and write
capabilities (since there are separate bits for read and write of
each size.)
So, maybe it needs to be:
} else if ((functionality & I2C_FUNC_SMBUS_BYTE_DATA) == I2C_FUNC_SMBUS_BYTE_DATA ||
(functionality & I2C_FUNC_SMBUS_I2C_BLOCK) == I2C_FUNC_SMBUS_I2C_BLOCK) {
to check that both read and write capabilities for each are set.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-01-16 13:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 11:31 [PATCH net-next v5] net: sfp: extend SMBus support Jonas Jelonek
2026-01-16 13:23 ` Maxime Chevallier
2026-01-16 13:43 ` Jonas Jelonek
2026-01-16 14:00 ` Maxime Chevallier
2026-01-16 14:07 ` Andrew Lunn
2026-01-16 14:16 ` Maxime Chevallier
2026-01-16 14:25 ` Andrew Lunn
2026-01-18 9:43 ` Jonas Jelonek
2026-01-18 10:08 ` Russell King (Oracle)
2026-01-18 15:36 ` Andrew Lunn
2026-01-18 15:39 ` Andrew Lunn
2026-01-22 10:14 ` Jonas Jelonek
2026-01-22 16:04 ` Andrew Lunn
2026-01-22 16:22 ` Russell King (Oracle)
2026-01-16 13:57 ` Russell King (Oracle) [this message]
2026-01-19 19:41 ` [net-next,v5] " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWpDrdocUvuBt-gS@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jelonek.jonas@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox