From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44F84283FEA for ; Fri, 16 Jan 2026 15:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768576488; cv=none; b=p4QZoMX0xw9ka+nrf/c4FvWhwWDVN/1fw2U5tG2aIkg2UFbsNRi7qG0Ie0oXTnQF5RNPgE/qqVfqh6lg2V5P8jz0xk6HScXP9ZFmtK9KHw3XdvMWc3q1lCil/pY4ljJgfHrrTNZ2KFhi9adrV0uvzsJ9MzZsV8HtaojNjfgedSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768576488; c=relaxed/simple; bh=McpfC188H2CvAHd4+BB7AxJkhXt9KS2RD0jkHVJ/lvs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MdYbweIlgioYKaey7Hw1HskUdBO/GTyMfRG+AudNIGl7j06PZokupTnCDLUHk80HkHDYVgsRLrDHdz4pm1IG3rk+nlszYPgl+QRSDwXsnZyMtPYNfSrvZQ5304Jy9rSdmOtL69vd0M+exZSq5OMMfCu7WDgrYKoV8g+sjSa2AC8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JOq70m4H; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=gW66IG1u; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JOq70m4H"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="gW66IG1u" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768576486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TXd78tLEXLfNJonJWIYvuTIRR+xmUZ49LsLId8Zx2R0=; b=JOq70m4H/LiPJCckg3kjU2VSGcJXrgSuvxt9Y2QUKH/gF6a/wK+c+IdCYKSV/AbSYTjGuK PH6Vz2D7xOvKsIU1qs0oqj73LM9PkFCeS/BRp3s6UDPa96OAiqr6tLkEZ4Bcs+U9moYcPt +JwmipT65+8bsKUhOC8Jb8fbI6kixNc= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-92-G7rmD7X_NmG5WzzvCHM_Ew-1; Fri, 16 Jan 2026 10:14:44 -0500 X-MC-Unique: G7rmD7X_NmG5WzzvCHM_Ew-1 X-Mimecast-MFC-AGG-ID: G7rmD7X_NmG5WzzvCHM_Ew_1768576484 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b234bae2a7so592432085a.3 for ; Fri, 16 Jan 2026 07:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768576484; x=1769181284; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TXd78tLEXLfNJonJWIYvuTIRR+xmUZ49LsLId8Zx2R0=; b=gW66IG1uMCBikAWCbZ+3Ei4hIdsPDOIetOQvSDQxDBx8zwU1+VV2a2s33p6RDTPyBj ZrfphQspmYS9PAPx5+tcvB6K2MJ5keVuDhSN0fXJkdpseTcE1JIfTw1TNasbn/NlZD73 rIEme4blpZ+F0B4JArmiQNt+/e8vbDOzqtFaAj0tqPed2bfFpkeYkEB8iZMJPBsm/e9e 5H0AQg8RxII2Mw8XibQd0D3RDhd5S15FxmI1MhIDKwhGPo/XymKXEQfdiM3652IK8bjY K8pBXfVdg0dREvLS6zUICRuruO7/nC9Pc0t8wPHrIvqjNFbC+L34oo4T3EkhpPM83cmc VLVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768576484; x=1769181284; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TXd78tLEXLfNJonJWIYvuTIRR+xmUZ49LsLId8Zx2R0=; b=tMYoCoAU3foD69t57Ex1FX22x3g0hnwZxu6utATMh3uk1M619yu+kol6b+zAdqyHkp kC5inOLdWlAE4z+5t3wgZyHryGnqTHANvW7rQY3loniDn6gsHldtmpgfYx6oy1IvU1F4 ZSL1otMDqOYuMHwRZl/PhAEGbLmVSBJeYPo8f10eWGKd61+6PMyIyN1stOk7FqZ1O+Dk eOGOSK+se1baskXDPcQ6NnaJg2a24MzYqMPaUysoUgbw4SmTZQLsWKABwm0fhcELTsUH hF9mXN6jzvY/6RKclS6cXeJOgmvF8Gx6S4PKB8sOafhjlL1bACjixZJlYhRQSnlNp2eR hv+A== X-Forwarded-Encrypted: i=1; AJvYcCXMEMKdn24p8JUtlxe3rgy3LWaQGZ7EQv+iA5n05xF172CcyIi6unqtDdhCO+gvL2IWrJb+hqFNGc20GxM=@vger.kernel.org X-Gm-Message-State: AOJu0YzhOyRqTmhVKaq5p20IIkgcw3dClMNGViSEG5JzpyB3ix038LSq BO+udv8SHxQ1aVLrfQuq0QGx3doxuzn9VLuncl9voRSFbSigsrFQTArZ9K2gU54NIPrcGYMKwOC zwaoby9zvmbjor1ay95u6ub6Y5+ZcHRCJ7VOvstSSFTZKxRr4lDTc+Oz1i5Fv3ustFg== X-Gm-Gg: AY/fxX7gn6boVXcCNZvTAw5UIo5Ego1+b4OFGvQXAX+plN84BWq2Ph+syw8zRjjeedc aGWyhkh/163Phq2JshXw+KJYUqZyA3s/XXVkzAAZFo2NWWH/+Jp34oE1pRqyBN7usodMgngQsuk BU58xwXYt84jrz19B1B/YiueiWwGYqEpxF5VXPsOWqlRO8WHmqH4uxrRFwiU2zlzhhzdY62UrBu o/jWXyXE59YrHR+IMo5IdiErfe/H7wAw4oMuu/P4Na+cZKeDcnbNfGE6IAiacXnOF5WFcu6oh/C jb1T2eIldRMkqHmdNvkVqXpkZN+O5iQweiTgZ4cXMJRoowKwvKzxqr6MfyzZVH8AYMaMJp2sG/2 joZjT9CjrvomiGec/jUOc+CY0ST+eTkW8y9RaNDh/Rcqb X-Received: by 2002:a05:620a:28c3:b0:828:aff4:3c03 with SMTP id af79cd13be357-8c6a6789392mr413936085a.61.1768576477907; Fri, 16 Jan 2026 07:14:37 -0800 (PST) X-Received: by 2002:a05:620a:28c3:b0:828:aff4:3c03 with SMTP id af79cd13be357-8c6a6789392mr413932385a.61.1768576477523; Fri, 16 Jan 2026 07:14:37 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c6a71ab272sm256477585a.2.2026.01.16.07.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 07:14:36 -0800 (PST) Date: Fri, 16 Jan 2026 10:14:35 -0500 From: Brian Masney To: claudiu beznea Cc: Thomas Bogendoerfer , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/16] MIPS: pic32: drop unused include linux/io.h from pic32.h Message-ID: References: <20260112-mips-pic32-header-move-v2-0-927d516b1ff9@redhat.com> <20260112-mips-pic32-header-move-v2-3-927d516b1ff9@redhat.com> <4a59d752-7aa8-4687-9618-3994efadebe2@tuxon.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a59d752-7aa8-4687-9618-3994efadebe2@tuxon.dev> User-Agent: Mutt/2.2.14 (2025-02-20) On Fri, Jan 16, 2026 at 09:12:45AM +0200, claudiu beznea wrote: > On 1/13/26 00:47, Brian Masney wrote: > > The linux/io.h include is not used, so let's drop it from pic32.h. > > > > Signed-off-by: Brian Masney > > > > --- > > To: Thomas Bogendoerfer > > Cc: linux-mips@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > --- > > arch/mips/include/asm/mach-pic32/pic32.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/mips/include/asm/mach-pic32/pic32.h b/arch/mips/include/asm/mach-pic32/pic32.h > > index e71c92a7bfde1342be6ea89a4bdf1389aa463b38..660fa4178b3e4e30977c8c4126df4266150062ce 100644 > > --- a/arch/mips/include/asm/mach-pic32/pic32.h > > +++ b/arch/mips/include/asm/mach-pic32/pic32.h > > @@ -6,7 +6,6 @@ > > #ifndef _ASM_MACH_PIC32_H > > #define _ASM_MACH_PIC32_H > > -#include > > Can't this be squashed this with patch 02/16 ? I made it a separate patch because generally if the commit message listing all of the changes has 'and' then that's maybe a hint that it should be split out into it's own commit. That said, if people really want, I can push out a new series with it squashed. Brian