From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 346B63939A4 for ; Fri, 16 Jan 2026 16:59:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768582746; cv=none; b=SMFkmcHxre2IMhpNmUdKr0CBlWg5+ZzEtj8GsXgOCWXB7F5+27lYA9DWi3IT750b9PswFNJ87587l48QAY129D0EsH9pcgePl1jYcAj82KqMlvtpQQl9JdLiRu9BqjNqGwDOyeOcjHuuNpU8cFh/HFGK3C1Ne9/dJkp5EVCYodg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768582746; c=relaxed/simple; bh=YOAJjjvJ0KI3T7moFNpFNWwLaSdhr+TLM+PpaKu/Aoo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iq8VYNJCBvLOGyCVcxDJMafdRsBID2b3gf2MtL0m7Jo9VBlM/8TwPtQn54KkFVoYeE0IEIi8pRWcPQN3jZfCc1F/M+zNlUApa2n8WD+7rewvYUw/yzUA3yisHRd2lbRZ7IHsZEFReythuHKBBJjvtAXIFiwLMrDlJ75jJclAqKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B4G8frRO; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B4G8frRO" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7b22ffa2a88so1011664b3a.1 for ; Fri, 16 Jan 2026 08:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768582741; x=1769187541; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YOAJjjvJ0KI3T7moFNpFNWwLaSdhr+TLM+PpaKu/Aoo=; b=B4G8frROqjrH8+t9zeH1nk9lYqMYkEAvU1PCoErOR4j8Th6W4NMKoBmDlGDN61L5Gf /DU74iYNHB1uTE5fNy2uY60FdoX13YluDt575PmOQFBva36hSruLcMwebR6XeYGy7kIT 9pHl2pq0KPxYjwVL6L/oM0l0zhv+yj/rx6/aOxpn9SQPrb2iFMW929QK3CwPPRCWNJ/U l9O00zZWi5rBhIrE8QxO4/8f+2T+E0sqLv24c8bOLCETGT5HAOgiknjee3TYGvbY3Q// 5Dk84QYZUoXw4THch+zwCfx1ZMvxdZ/+nZfLQdkYVg1cKunrHvMAGyjt5qbYjOSc/stm PD7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768582741; x=1769187541; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YOAJjjvJ0KI3T7moFNpFNWwLaSdhr+TLM+PpaKu/Aoo=; b=miruptMlOZgnfVb+X9s9utuFT1JOtwSLwuH6QY3Y4FIfYoDyzMPdT0hYG1HrI5nr1+ 1N6ITdGebeF6D/Znw2vREBG9KIv6BGP2+2tNE46XeIWdckzvOPrQ9hNrQA98GURLxqCT OM5CK+Ot8qSMadXRUOTrkeIpFTMEo1IBgfbs/euKBJYWgzuePtp2iI4xxCpKqSvHvigH MF+uRp6zJdYRvcfQsR/UOnEMP3xg24IMfjUZM/SMntXMigDTxqgzVWrSdnw08qeJJ2u/ oJAhvBf6v/CnaXJpAFQ02h9UoFR783v7MQFjgSlR+RYKAFrFl2Oh+YClCq2du1lQIXr0 Rjsg== X-Forwarded-Encrypted: i=1; AJvYcCXb/zNOV/m/1PSlDqOOgpUZpWUFdDgs8EBeNf5MwcWh4Rd0ke7EuUanjXDvP60gKGICRj0oMTtzWVqotA4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+lSXJqyiTHuPT9jSpFRkmwHRlNLBUvWQl4OO2Rm/iGX7e5qX/ WFXdn6C0aCyOqiLfO/A5gbmY+UTTDh0wRHUrm5hjpOjOTCs5D4J3HFd2 X-Gm-Gg: AY/fxX6dsrsopoFcRTUt3qwtoKFj1PUU29b5rS4mhvq+MmcpyOCW9PhgDef5RB/3UcA dcsFbO18DQXXubA4ICwfCja7Gue4uD+kwRyf3m5S/xI6a15OtX7zcVaCvfVkt9HaTbiRiWW194g 00pPoxv/mFzQOBtcVDotDD2LMpJKxVjX/qHQF9i8w5VaA/D/bykLbZVbDkJD18kqONJiUqxoY8v CN/tNubhd+m0dzUEV+SZs0D/yy2bHFkNRYdMIzFrPzmWAI/rLajkHyb3xkBKjMPEaFfWxG1Shrl bm9YYj+jYRtz3QpuS9hLRZY/fxvINmqaAsaDukdmit+CMDv3IvAcL8R1gXaNH8zyiCt1rIcj90+ ILqQZ63Ux3AEcecgyXMprFIUCV/ixUZyauXIge91yWCD/yjCnVTMpWb+S/ks5OAvDhYChvzhsa3 p1zMYsZ/I= X-Received: by 2002:a05:6a20:2586:b0:364:134a:2bc1 with SMTP id adf61e73a8af0-38e00c037f9mr3365273637.18.1768582741111; Fri, 16 Jan 2026 08:59:01 -0800 (PST) Received: from fedora ([210.228.119.9]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c5edf249fcbsm2576872a12.12.2026.01.16.08.58.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 08:59:00 -0800 (PST) Date: Sat, 17 Jan 2026 01:58:53 +0900 From: Ryota Sakamoto To: David Gow Cc: Brendan Higgins , Rae Moar , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, workflows@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH] kunit: add bash completion Message-ID: References: <20260115-kunit-completion-v1-1-4de6564962c4@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi David, Thank you for the review. On Fri, Jan 16, 2026 at 05:30:22PM +0800, David Gow wrote: > Two small suggestions: > - Could we add './tools/testing/kunit/kunit.py' to the list of > commands? That's what's recommended in lots of documentation, emails, > etc. Sure, I will add the relative path of the script explicitly. > - It'd be great to rebase this on top of kselftest/kunit -- there's a > conflict with your previous patch. I will rebase the patch on top of kselftest/kunit to resolve the conflict. Regards, Ryota Sakamoto