From: Petre Rodan <petre.rodan@subdimension.ro>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Andreas Klinger" <ak@it-klinger.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Marcelo Schmitt" <marcelo.schmitt1@gmail.com>
Subject: Re: [PATCH v3 00/13] iio: pressure: mprls0025pa: driver code cleanup
Date: Fri, 16 Jan 2026 20:56:45 +0200 [thread overview]
Message-ID: <aWqJ7fg8e1Y2pxVL@lipo.home.arpa> (raw)
In-Reply-To: <aWfNwLRi4ftU5LLC@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]
Hello,
On Wed, Jan 14, 2026 at 07:09:20PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 14, 2026 at 06:55:29PM +0200, Petre Rodan wrote:
> > This series contains a collection of patches to the MPR sensor based
> > on feedback I received for other drivers.
> >
> > major changes:
> > - trigger flag fix (define edge direction only in the device tree)
> > - fix SPI timing violation
> > - fix scan_type struct
> > - fix pressure calculation
> > (does not affect users that define a sensor via the pressure-triplet)
> > - stricter check for the status byte + better error return levels
> > - drop the use of devm_kzalloc()
> > - stick to the datasheet parameters while performing the measurement
> > sequence
> >
> > minor changes:
> > - includes added and removed
> > - rename generic 'buffer' variable to 'rx_buf'
> >
> > Tested on two sensors - MPRLS0015PA0000SA and MPRLS0001BA00001A
>
> This version looks good to me,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> The change I mentioned can be sent as a followup.
Thank you for the review.
@Jonathan: please ping me when the series is pushed so I create the followup.
best regards,
peter
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 870 bytes --]
next prev parent reply other threads:[~2026-01-16 18:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 16:55 [PATCH v3 00/13] iio: pressure: mprls0025pa: driver code cleanup Petre Rodan
2026-01-14 16:55 ` [PATCH v3 01/13] iio: pressure: mprls0025pa: fix spi_transfer struct initialisation Petre Rodan
2026-01-14 16:55 ` [PATCH v3 02/13] iio: pressure: mprls0025pa: fix SPI CS delay violation Petre Rodan
2026-01-14 16:55 ` [PATCH v3 03/13] iio: pressure: mprls0025pa: fix interrupt flag Petre Rodan
2026-01-14 17:07 ` Andy Shevchenko
2026-01-14 16:55 ` [PATCH v3 04/13] iio: pressure: mprls0025pa: fix scan_type struct Petre Rodan
2026-01-14 16:55 ` [PATCH v3 05/13] iio: pressure: mprls0025pa: fix pressure calculation Petre Rodan
2026-01-14 16:55 ` [PATCH v3 06/13] iio: pressure: mprls0025pa: cleanup includes Petre Rodan
2026-01-14 16:55 ` [PATCH v3 07/13] iio: pressure: mprls0025pa: remove redundant declarations Petre Rodan
2026-01-14 16:55 ` [PATCH v3 08/13] iio: pressure: mprls0025pa: rename buffer variable Petre Rodan
2026-01-14 16:55 ` [PATCH v3 09/13] iio: pressure: mprls0025pa: introduce tx buffer Petre Rodan
2026-01-14 16:55 ` [PATCH v3 10/13] iio: pressure: mprls0025pa: move memset to core Petre Rodan
2026-01-14 16:55 ` [PATCH v3 11/13] iio: pressure: mprls0025pa: stricter checks for the status byte Petre Rodan
2026-01-14 16:55 ` [PATCH v3 12/13] iio: pressure: mprls0025pa: change measurement sequence Petre Rodan
2026-01-14 16:55 ` [PATCH v3 13/13] iio: pressure: mprls0025pa: add copyright line Petre Rodan
2026-01-14 17:09 ` [PATCH v3 00/13] iio: pressure: mprls0025pa: driver code cleanup Andy Shevchenko
2026-01-16 18:56 ` Petre Rodan [this message]
2026-01-16 19:01 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWqJ7fg8e1Y2pxVL@lipo.home.arpa \
--to=petre.rodan@subdimension.ro \
--cc=Jonathan.Cameron@huawei.com \
--cc=ak@it-klinger.de \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox