From: Brian Masney <bmasney@redhat.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Andy Gross <agross@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the qcom tree
Date: Fri, 16 Jan 2026 15:05:32 -0500 [thread overview]
Message-ID: <aWqaDCvjs-mR12_c@redhat.com> (raw)
In-Reply-To: <olnhf2ritwl4eh4plujlcthohsortsspagdioaqcugvdlgquad@l6pljrt4k4ws>
On Fri, Jan 16, 2026 at 01:42:56PM -0600, Bjorn Andersson wrote:
> On Mon, Jan 12, 2026 at 06:00:19PM -0500, Brian Masney wrote:
> > + Bjorn and Konrad,
> >
> > On Tue, Jan 13, 2026 at 08:06:06AM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > In commit
> > >
> > > 35a48f41b63f ("clk: qcom: regmap-divider: convert from divider_ro_round_rate() to divider_ro_determine_rate()")
> > >
> > > Fixes tag
> > >
> > > Fixes: 859a7e020b23 ("clk: qcom: regmap-divider: convert from divider_round_rate() to divider_determine_rate()")
> > >
> > > has these problem(s):
> > >
> > > - Target SHA1 does not exist
> > >
> > > Also, the subject in the fixes tag is the same as the fixing commit,
> > > so I have not idea which commit was intended.
> >
> > I missed up my Fixes tag on this commit that was applied to the qcom clk
> > tree:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=clk-for-6.20&id=35a48f41b63f67c490f3a2a89b042536be67cf0f
> >
> > The Fixes tag should be:
> >
> > Fixes: b6f90511c165 ("clk: qcom: regmap-divider: convert from round_rate() to determine_rate()")
> >
> > The SHA is correct. I just have the wrong commit description.
> >
>
> I believe you're saying that both commits should have:
>
> Fixes: b6f90511c165 ("clk: qcom: regmap-divider: convert from round_rate() to determine_rate()")
>
> Can you confirm?
Yes, that is correct.
> It's the top two commits of the branch, so if you can confirm my
> understanding I'll just fix up HEAD^.
Thank you, Bjorn!
Brian
next prev parent reply other threads:[~2026-01-16 20:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 21:06 linux-next: Fixes tag needs some work in the qcom tree Stephen Rothwell
2026-01-12 23:00 ` Brian Masney
2026-01-16 19:42 ` Bjorn Andersson
2026-01-16 20:05 ` Brian Masney [this message]
2026-01-16 21:40 ` Bjorn Andersson
-- strict thread matches above, loose matches on Subject: below --
2024-07-08 8:13 Stephen Rothwell
2024-02-07 7:05 Stephen Rothwell
2023-07-23 22:53 Stephen Rothwell
2023-05-29 21:49 Stephen Rothwell
2023-05-30 14:56 ` Bjorn Andersson
2023-05-31 13:25 ` Linus Walleij
2023-03-14 21:15 Stephen Rothwell
2023-03-13 21:37 Stephen Rothwell
2023-02-09 4:04 Stephen Rothwell
2023-02-09 10:02 ` Bartosz Golaszewski
2023-02-05 21:09 Stephen Rothwell
2023-01-19 6:04 Stephen Rothwell
2022-10-03 20:13 Stephen Rothwell
2022-09-14 7:23 Stephen Rothwell
2022-04-13 21:40 Stephen Rothwell
2022-04-14 15:03 ` Konrad Dybcio
2022-03-09 12:10 Stephen Rothwell
2022-02-13 10:39 Stephen Rothwell
2022-02-13 11:52 ` Robert Marko
2022-02-13 21:02 ` Stephen Rothwell
2022-02-14 4:53 ` Bjorn Andersson
2022-02-16 9:59 ` Robert Marko
2021-11-22 21:08 Stephen Rothwell
2021-09-20 22:24 Stephen Rothwell
2021-09-21 23:02 ` Stephen Rothwell
2021-09-21 23:31 ` Bjorn Andersson
2021-09-22 0:15 ` Stephen Rothwell
2021-07-20 7:25 Stephen Rothwell
2021-01-21 7:41 Stephen Rothwell
2021-01-21 8:50 ` Robert Foss
2020-02-12 7:18 Stephen Rothwell
2019-02-07 13:47 Stephen Rothwell
2019-02-07 17:06 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWqaDCvjs-mR12_c@redhat.com \
--to=bmasney@redhat.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox