From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6BB21E4BE for ; Sat, 17 Jan 2026 00:48:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768610891; cv=none; b=QXKW4963je7f9KE5mXPWkN0r9+EkMj+dLH2nD+VMTX/bWyrGAu0dyMrRn6RvANA3dmBGAx9YRjbjDZDkAQa+rzPKn0jYDX21fao5413auDcLKPNcp8cj2GQQKeAgIvA26Zbf7ycyp2NVVI+WgNYGujBSkNDmD1lo0dhTxpN7XQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768610891; c=relaxed/simple; bh=ftXEYn+NQ1SnIwHJGtXDc7X4HarWN6Q5+so4Xq8sTA8=; h=Date:From:To:Cc:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=DhT2ClFCTOpc93TBQ6k+HNkEN7qN8fGhr9GR7wYluE9hgaDPMR0t07e0DfANYBfLT5VLBEDXlTYEGJnsHwzaJmIkMqXo3LtPIdUX9hNis1VY/b8tFCMojQXEFAyvtW2NW5BjFvn4isOiHBW5RGQ4/GCxeNWjQqlL1BXnWoHSVYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GJBqqLZW; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GJBqqLZW" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-59b76c092acso2549562e87.2 for ; Fri, 16 Jan 2026 16:48:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768610887; x=1769215687; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=Okf3U9QDNGb4UYL7N7Vkacook/dnzzX77oUe7PD87XI=; b=GJBqqLZWTnoN2QIX6SeLS/GoiGC0SYdaz/BipQCMuwmdbTOdnq4MzED0e0KolTINUb AS12YyiNldl/I8uRHF/Y4HHynegYACPMH5M4UZxzYS+LytK7fLgniBSsJZy5kg4Shjud wKXrbJHhG4fU5upwky838W83fG67RHGNw4Cxf57DfsRd6gShPBNutBUL9pm7siBjFzA3 AvcpDPIi/eRSTGqOIkvaaM40QTE2JPd4CLKcwQ/jDxU7p9YQC1+5su9jM28aUPFXZD6p cp+o40T2C/3nFgp60jxhcTkxYwg7Vadl9tC8RWuMo0nCWYXzdd192c4QYuotzV+y+ukU WHQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768610887; x=1769215687; h=content-disposition:mime-version:message-id:cc:to:from:date:sender :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Okf3U9QDNGb4UYL7N7Vkacook/dnzzX77oUe7PD87XI=; b=I9V4cUGxnHN5A0q5CdaGjyi96Xc7dptqfJbumlnQj1G72OJEC0w0x5LOdb2RDwE+sW Jf2EcVR5JQfqzn4XkoGeDeHr4BHhYaKeFj9lDBk46Rfd9KEzhVzTEctEnEA39IFqZ+dc EXBQgpbja5EGsH1WFJmHyTisPSIr5st3IDZWbF+yKXbF1GE0l+XILUAwKshxF04D21OX X1SaBiwEYW6avMERvvrgyTfuLs8mpm0PDIXJ3dwhYfwlAfBbmOX10dVQhIrSxMUr2vpH X0ndUnI4VZclsCafr1DKUyQFonB/I0Dfww1X03dHQhUOm1mm/Q2bd0yOcBIAoCxwF4ur Ty8Q== X-Forwarded-Encrypted: i=1; AJvYcCWROsGdeSXNGrLELxT296/JP7jB5g8KKM9lBfo9+v+TuKEuQqA6QfVc9CCdMAI5oX+vGKwngJBSPxSetAk=@vger.kernel.org X-Gm-Message-State: AOJu0YzOPs3aWqJv9QOLHsCXg8wAwat8O7uN2oFeHsqZXOdTGJPB3p6f MmwSUFo0aKlHGz5aRY+LOHVXGLLqvJjRHvF+ShBxpXuLJZk7/g1ZLSdxBrREfotW X-Gm-Gg: AY/fxX6YP6w1nrjth5Q0vmSNUggQk9CGPYoP2STfBMW3Gpa4BsLVyTBb8zqy8tKZ9Ek 6p4n1zrewfelul47KxOODSNBenqmz2isjXwcEb0Nv5oLYmDJ8TfeKORBTPhYT4tPBBmzAdSfvux RVcZKUkxJgae76qrIkaXDVfS2FIv53jdgQRqoGDUPf4oQljMLRrCgGVk8qL2hnI9t5AbthOLgIB CbB4BipgV8TI3s4yq0IdnxHkwIuy8WJiZWTGruA8pjKkDU3vceCYsrQ5iNV0e8UfVCO7Gb9A2ry Dlh9+b6awppyBYrWC+CC/YovZ79OuKQrfdNZchopJX1o66vy3hBAbINWp+ScGJczYIp09CdOleW c6fRiLM8Nr6rAKoA0FVoHeoifWzGiE1LLZh+3CWG2nyF86h4EKF3W3VH2aPzO79wGogWxfLccsw n3MO1uQDneFtZaKeNai+guSD8bEq9PPEosIddSsy0CEODi X-Received: by 2002:a05:6000:1a87:b0:431:c73:48a8 with SMTP id ffacd0b85a97d-43569bc4a06mr6593543f8f.29.1768604753879; Fri, 16 Jan 2026 15:05:53 -0800 (PST) Received: from eldamar.lan (c-82-192-244-13.customer.ggaweb.ch. [82.192.244.13]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43569926648sm8083339f8f.10.2026.01.16.15.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 15:05:52 -0800 (PST) Sender: Salvatore Bonaccorso Received: by eldamar.lan (Postfix, from userid 1000) id 531A5BE2EE7; Sat, 17 Jan 2026 00:05:51 +0100 (CET) Date: Sat, 17 Jan 2026 00:05:51 +0100 From: Salvatore Bonaccorso To: Greg KH Cc: xiaopeitux@foxmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Pei Xiao , Heikki Krogerus , pdormeau@free.fr Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Bcc: Subject: Re: [RFC] usb: typec: ucsi: Fix array index out-of-bounds in altmode registration Reply-To: In-Reply-To: <2026011617-phantom-diploma-cd79@gregkh> Hi Greg, hi Heikki On Fri, Jan 16, 2026 at 12:22:42PM +0100, Greg KH wrote: > On Thu, Jan 15, 2026 at 11:32:01AM +0800, xiaopeitux@foxmail.com wrote: > > From: Pei Xiao > > > > Add boundary check to prevent array index out-of-bounds when PPM returns > > more alternate modes than expected. > > > > log: > > UBSAN: array-index-out-of-bounds in /build/reproducible-path/linux-6.17.13/drivers/usb/typec/ucsi/ucsi.c:609:18 > > index 2 is out of range for type 'ucsi_altmode [2]' > > CPU: 10 UID: 0 PID: 275 Comm: kworker/10:1 Not tainted 6.17.13+deb14-amd64 #1 PREEMPT(lazy) Debian 6.17.13-1 > > Hardware name: LENOVO 83J3/LNVNB161216, BIOS PYCN30WW 11/17/2025 > > Workqueue: events_long ucsi_init_work [typec_ucsi] > > Call Trace: > > > > dump_stack_lvl+0x5d/0x80 > > ubsan_epilogue+0x5/0x2b > > __ubsan_handle_out_of_bounds.cold+0x54/0x59 > > ucsi_register_altmodes+0x233/0x250 [typec_ucsi] > > ucsi_check_altmodes+0x1b/0xa0 [typec_ucsi] > > ucsi_init_work+0x919/0x9b0 [typec_ucsi] > > process_one_work+0x192/0x350 > > worker_thread+0x25a/0x3a0 > > > > Reported-by: Salvatore Bonaccorso > > Closes: https://lore.kernel.org/lkml/176840984804.2144647.10736984532804520381@eldamar.lan > > Signed-off-by: Pei Xiao > > --- > > drivers/usb/typec/ucsi/ucsi.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c > > index a7b388dc7fa0..00575a8720cc 100644 > > --- a/drivers/usb/typec/ucsi/ucsi.c > > +++ b/drivers/usb/typec/ucsi/ucsi.c > > @@ -599,6 +599,8 @@ static int ucsi_register_altmodes(struct ucsi_connector *con, u8 recipient) > > * incremented. > > */ > > num = len / sizeof(alt[0]); > > + if (num > ARRAY_SIZE(alt)) > > + num = ARRAY_SIZE(alt); > > As Heikki said, this is a broken hardware device, please fix that > instead as it will not work with any other operating system either :) Thanks a lot for looking into it. Pascal, can you pleas report this issue then to the vendor as it is a firmware bug? Regards, Salvatore