public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: jkhall81 <jason.kei.hall@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Todd Kjos" <tkjos@android.com>,
	"Carlos Llamas" <cmllamas@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH rust-next] rust: binder: refactor context management to use KVVec
Date: Sun, 18 Jan 2026 09:36:22 +0000	[thread overview]
Message-ID: <aWyplq9VTFHsyYsE@google.com> (raw)
In-Reply-To: <20260117162242.950194-1-jason.kei.hall@gmail.com>

On Sat, Jan 17, 2026 at 09:22:42AM -0700, jkhall81 wrote:
> Replace the intrusive linked list management in context.rs with KVVec.
> This modernization simplifies the ownership model by using standard
> Arc-based tracking and moves away from manual unsafe list removals.
> 
> The refactor improves memory safety by leveraging Rust's contiguous
> collection types while maintaining proper error propagation for
> allocation failures during process registration.
> 
> Suggested-by: Alice Ryhl <aliceryhl@google.com>
> Link: https://github.com/rust-for-linux/linux/issues/1215
> Signed-off-by: jkhall81 <jason.kei.hall@gmail.com>

The subject says [PATCH rust-next], but this would land through
char-misc, not rust-next, as that's where Binder belongs.

You can leave out the branch name and just say [PATCH].

Also, I usually use 'rust_binder:' instead of 'rust: binder:' for the
commit message.

>  pub(crate) fn get_all_contexts() -> Result<KVec<Arc<Context>>> {
>  pub(crate) fn get_all_procs(&self) -> Result<KVec<Arc<Process>>> {

These two methods need to use KVVec instead of KVec.

Also, I think some of these loops could be replaced with simply
Vec::clone().

Alice

  parent reply	other threads:[~2026-01-18  9:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-17 16:22 [PATCH rust-next] rust: binder: refactor context management to use KVVec jkhall81
2026-01-18  6:51 ` Greg Kroah-Hartman
2026-01-18  9:36 ` Alice Ryhl [this message]
2026-01-18  9:37 ` Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWyplq9VTFHsyYsE@google.com \
    --to=aliceryhl@google.com \
    --cc=arve@android.com \
    --cc=cmllamas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jason.kei.hall@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox