From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2B752EC563 for ; Sun, 18 Jan 2026 12:00:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768737606; cv=none; b=W2WMctwa/ypL7QmVQ/hHHQLhJlH2hWP3KlMj0Wuw8H+WVoU8HF7wHiCrZBKbs6bn/JRYjAukiAISf+4UJhQs498xqBONQxsM4a8F2g6K8qpI9HRSJ3juj1EGKdGa/wxHV7FMGykbG+AeGyWXsrMkhw+QltxHQ08NEQcUD302Ry8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768737606; c=relaxed/simple; bh=QUKIFy1KWubu+ezyqm0bzmv5XxIFJWUxkjA3Ia/WDx0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fkTo0VeiEmLJU5zuj/KDLLjD8002+8SSbi5hAGlI2VRjgcfOk61V95/aIgQoCGVsk+KMJDAYXeMEEpg2UUq73iCIWhK11A82uKRC/gdiR2tvAct2swDrRbQj1zL8EHuTmVGP0DOGlLaI9T5pBpQZhsntLc5ZufKRNl1QQYG3JG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uCsu3jmV; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uCsu3jmV" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4801c2fae63so18476595e9.2 for ; Sun, 18 Jan 2026 04:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768737601; x=1769342401; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zNKmOWM7uuU0kWQqBwwC50MktRgwdlry/VNrCjqKFfk=; b=uCsu3jmVgIASF0+M0MXzgP5/ULJObqT9jOrFscod2tq3kVdeCSXSGFeR8H7OwnJlTU /7rKsOsojM2+iEf0r6QXpy//XZze6HAHs3HdpFkA+hggfLFVioNnN/WJ8xLFZC575Ny8 4GqWXDWcBCH+zI/x8SFXlnhjFLIFGqa/TdKDwYqvRFnSwzNFGcC0KnmVdTBmNVWhpUi0 1KOjX92D21Htr68DYfvgXyprKnx/lK4fT8Q1pqu5By2E1+37T/h+sDl0Kshn45UFoPHF bsjd1IGGz99YHfecWSzBhM3EUzdX/IxQZUE03rFnKhOsI9tkww26cPBnMJxe4pmAE+YS QAPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768737601; x=1769342401; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zNKmOWM7uuU0kWQqBwwC50MktRgwdlry/VNrCjqKFfk=; b=aMQdBV8dhHMK+Lr8+anppgFx/unDG50/GrsY1A32017TJf8d13tYY+sdpS1qRGyjSb EcqP4ecy8hV/2khzFjGVVYehh1sotLJ1n9aj5/fXTmooGYdME9/zy6OnDmuG7Bp3lX5Z 3bLrw1KKmPWnn8RbRkgtQM55ZDkp5lp3zSXquZw0FyTqjI1V2V6i91TivCz4FA7jbVd/ 1/g5aR107DyLyy0NAD5RXaJ/zg7IBaGUSzlG1N91OTvbC9l2fz08tISMK0AMWmDNrEy+ aIeWWUh4CXKJt3l13BNnKp2PkWdXhBM2jggpDIE/uqbpTv6Mjwn3qM6uzJFwgHa0VJxT Nw/g== X-Forwarded-Encrypted: i=1; AJvYcCW+JrxCCXSALhl3mq3GLo2+TLjYQncmSg1qElmPjH0YFH95tTBkkl12iy+jojEw4hHnijpi/VWoxpGuGDs=@vger.kernel.org X-Gm-Message-State: AOJu0YyLe5lUFdZmjfVOg7GiwgndzylwSY5rI6WQbHYxriXEYOPOjOgU Lj8I3aLzwigZmIVgjDdbJ4Gjp5u8uJqi4xRUIaQ9Etjbtab2NZ5uE5apCx4O8KEkg5E= X-Gm-Gg: AY/fxX6T1W1tNI3qmhVxjVPajPVdqfrn2zIrIXBFsM7oyqbLVuKzVMPd90fxdMQOBmi IfqR3QIpxmWVmbh6Px9f0AtDd2vtuj7F4MiAQFu1Fx4YmwhFfCe487zFveOI0IwVRKyq6RfxeTE toaWugTm6bBYtIQ+/G+JVoD72G7q43V9kQGgPsasd2i1ADB0K4VqlFIqYX4bVePwUZlqYxzV57u Q1ip755xaPKyooqwqNbnhiXXQX8IYLQ4f1tZDGHT37NL1X4N5Ss8Vt+AQyV0G68MB6E544dEWh7 Z7EZ84Gcv3ZNsFxWdXe3amYwYT1lLDXGMLLM7l0F+YObL7p2VZUUgy23btomMcvbrIIlPw9c0Sp XYBFGyUuwdKEqtYufkHLQZgQ0AGnwxPSfddxSaGlSBe6I2y8TYSIHZGsBejeFR3fMhYs1dVhfu6 arLtLPeZ6sFqIfQs+QHvIkDfkzD+Y= X-Received: by 2002:a05:600c:3555:b0:47e:e20e:bb9c with SMTP id 5b1f17b1804b1-4801e2f8e63mr105795515e9.8.1768737600669; Sun, 18 Jan 2026 04:00:00 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801e879542sm142833875e9.4.2026.01.18.03.59.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 04:00:00 -0800 (PST) Date: Sun, 18 Jan 2026 14:59:57 +0300 From: Dan Carpenter To: Khushal Chitturi Cc: gregkh@linuxfoundation.org, hansg@kernel.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] staging: rtl8723bs: simplify boolean expressions Message-ID: References: <20260115102910.10018-1-khushalchitturi@gmail.com> <20260115102910.10018-3-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260115102910.10018-3-khushalchitturi@gmail.com> On Thu, Jan 15, 2026 at 03:59:08PM +0530, Khushal Chitturi wrote: > Simplify boolean expressions in rtw_xmit.c to > comply with the kernel coding style > > Signed-off-by: Khushal Chitturi > --- > drivers/staging/rtl8723bs/core/rtw_xmit.c | 38 ++++++++++++----------- > 1 file changed, 20 insertions(+), 18 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c > index bbc42db1c828..97e38ef62ac4 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c > +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c > @@ -384,7 +384,8 @@ static void update_attrib_vcs_info(struct adapter *padapter, struct xmit_frame * > } else { > while (true) { > /* IOT action */ > - if ((pmlmeinfo->assoc_AP_vendor == HT_IOT_PEER_ATHEROS) && (pattrib->ampdu_en == true) && > + if ((pmlmeinfo->assoc_AP_vendor == HT_IOT_PEER_ATHEROS) && > + (pattrib->ampdu_en) && What are these parens for? > (padapter->securitypriv.dot11PrivacyAlgrthm == _AES_)) { > pattrib->vcs_mode = CTS_TO_SELF; > break; > @@ -420,7 +421,7 @@ static void update_attrib_vcs_info(struct adapter *padapter, struct xmit_frame * > /* to do list: check MIMO power save condition. */ > > /* check AMPDU aggregation for TXOP */ > - if (pattrib->ampdu_en == true) { > + if (pattrib->ampdu_en) { > pattrib->vcs_mode = RTS_CTS; > break; > } > @@ -482,10 +483,10 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p > memset(pattrib->dot11tkiptxmickey.skey, 0, 16); > pattrib->mac_id = psta->mac_id; > > - if (psta->ieee8021x_blocked == true) { > + if (psta->ieee8021x_blocked) { > pattrib->encrypt = 0; > > - if ((pattrib->ether_type != 0x888e) && (check_fwstate(pmlmepriv, WIFI_MP_STATE) == false)) { > + if ((pattrib->ether_type != 0x888e) && (!check_fwstate(pmlmepriv, WIFI_MP_STATE))) { These parens? > res = _FAIL; > goto exit; > } > @@ -639,8 +640,8 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p > memcpy(pattrib->dst, ðerhdr.h_dest, ETH_ALEN); > memcpy(pattrib->src, ðerhdr.h_source, ETH_ALEN); > > - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true) || > - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true)) { > + if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) || > + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { These etc? regards, dan carpenter