Re: [PATCH 3/4] staging: rtl8723bs: rename CamelCase identifiers to snake_case

Dan Carpenter
2026-01-18T12:02:12Z

On Thu, Jan 15, 2026 at 03:59:09PM +0530, Khushal Chitturi wrote:
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index ef2d92b5588a..005e6737e1af 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -1148,10 +1148,11 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
> BusyThreshold = BusyThresholdLow;
>
> if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold ||
> - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) {
> + pmlmepriv->LinkDetectInfo.tx_ok_in_period > BusyThreshold) {
> bBusyTraffic = true;
>
> - if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > pmlmepriv->LinkDetectInfo.NumTxOkInPeriod)
> + if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod >
> + pmlmepriv->LinkDetectInfo.tx_ok_in_period)

This is just weird now. NumRxOkInPeriod vs tx_ok_in_period? The names
don't match and the tx_ok_in_period name doesn't make sense.

regards,
dan carpenter