From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4EE31DB13A for ; Sun, 18 Jan 2026 12:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768737734; cv=none; b=gjRFDe2zeprzJGdQAmFARwr9F1nSJAREvB1h8Dduy/IMNrO6VJ78Yzu3IZEF0hMam9PudB41mlm/anpBeW4Pnfavp7mwwL1nq+RjDJ3YJbRy1fH4XL1MNlJvrOAi1H9rPc3+Tax1ZlO/sHfNh+45/0NZGDENh8rNSiiYUscYJbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768737734; c=relaxed/simple; bh=GaRLsDYVHAIpsLkPUuBEekQPKkEikAudPJ8AsCSh3us=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ApB3ptyZNVZXfUnPS2nVSv4tuoIb6fhyNwlapZvAT1DNhimKpaHmKDd5KcYIQg2BOJKWa4hvJtA6WAXLQtuKon/UTBwP5PMz/UqE/sMLb9LOVaKMiJJt/2oyvBCdkRlnoGQ8CKcuY85eQgOBYqDbcHhoC7BZFHG9q7LX/wOqiaw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bFy+IJrI; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bFy+IJrI" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4801c731d0aso18561665e9.1 for ; Sun, 18 Jan 2026 04:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768737731; x=1769342531; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fsOjmXq861+B8+piq64axGGmhncgWMIggfsLJIoRT+8=; b=bFy+IJrILYk6yyIlEZna9DtquXmw8dxJ2K1Q83ib/rybk1WL4hlZZSJbySRbRl2udu 87HvRYDjU5ICzON6wOGhMSjZkZS+BKKn8pEI+9o2hdPVJA0O2Xv9cJofG/DXdqAF52ZW y6NmY5bP3dotcU1zekzwQ1mI+QwsfGQtiXtyZ55zfEYyv2PcEDVdSNEXPlecgoaiYGCO D/NswbsT2LqeN5R6vLpAJs5qmFh/yUJAc961wTS/cBwF4a4qlcmmx0mvf4h5huEHyBiN NEgOjgSUZSoJIZrlQB544RzH+MyRKmx5ufRKkMk9P1H4dr8nLQK/xJNwvJL2BzU8paNs oZtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768737731; x=1769342531; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fsOjmXq861+B8+piq64axGGmhncgWMIggfsLJIoRT+8=; b=dtZhjgK+xEUF2gdgUeJAXRQl6n3vrfPPS6TN46FDJCJ8ahHCfa/jmXjbp55RetL0qf XYmsX9kv1NxXSRw2FtKKtSeb2SKVQyykmYUFJgjH9++7/Vv+BZm0YFAcINqfSsE1EmrV cVrXhU1wz+vwmu5vPylpvs4LJIbb88sFlnCxd0HD6DglGfVAA8ev0p4uxBQ6AM7K+cNh 2wPhdJSDYqveY2RjFpSEpeNbKf85oXRzkcrXWJuYsaHm6yervMHMKBo64qKU9/Jzmq84 ii/HoD50S0gf4sEdpyuQlrVSzW34uvtTFuSNeHc/7q+bNrm2S/g9gL3qUXE4xNNb3Zs3 YcFQ== X-Forwarded-Encrypted: i=1; AJvYcCWYIRTs3IxLX9FaBGO82GnmNxs9D7kR4hFB7VkST9h8pxQS9G+3eQgcFQLVk6h1TZtxAIk4itSWbD+GucY=@vger.kernel.org X-Gm-Message-State: AOJu0YxJVqnr+5CHQGdE8MNc2mhf/MNtrZsxixGlm2H344eCYVFw/4uw EOXskpNUI62txUWq3MKXUochjCoLlbrSNRt5kXJugz9DhF4H18khdCU0GwYPy+FHp6c= X-Gm-Gg: AY/fxX5NuQVfe1aia5/FZws04GToYGXKlcAozyjtR9hwpZnKha209iEBaocdCgC0OLx 6wdjQ5AkBoV0wpNLw4t3oAQJVvD+CNlAm9dQQ6uoDANFpvxGNJnSknx7oWFdgsAdw4CB3lqAYEz iGM5pWDPpUD+aelhzWn5BD3daIvjOW6fpG1MV6U7fDsUFEFA3EZG/62GTdKckoA6Kqobhu0e1m7 Kgk9gzEPLDLqo7rsNBTwJANmeqTYT6zMId2GMmRNBwH5xm+onr2+kS/tYhYEYCgvGGcOPOkKNHl hWdBC2NHXAMnpzUgxT/sIyu3kT4/tSFud3phfhWDcaJO1SrARg3HAu0D7WTg9gcp9XjvJitKQoQ qYqG+ilthgoQrnql8dmfE9FByNbpsZ+wIVsSkiO/RnboG1NJpziGw1pykNS3vsk3ywaZyIkxaHO wfIn3W+rXyWX2fcbDp X-Received: by 2002:a05:6000:2911:b0:431:327:5dc2 with SMTP id ffacd0b85a97d-43569bcc0acmr10070937f8f.51.1768737731039; Sun, 18 Jan 2026 04:02:11 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43569926648sm17117733f8f.10.2026.01.18.04.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 04:02:10 -0800 (PST) Date: Sun, 18 Jan 2026 15:02:07 +0300 From: Dan Carpenter To: Khushal Chitturi Cc: gregkh@linuxfoundation.org, hansg@kernel.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] staging: rtl8723bs: rename CamelCase identifiers to snake_case Message-ID: References: <20260115102910.10018-1-khushalchitturi@gmail.com> <20260115102910.10018-4-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260115102910.10018-4-khushalchitturi@gmail.com> On Thu, Jan 15, 2026 at 03:59:09PM +0530, Khushal Chitturi wrote: > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c > index ef2d92b5588a..005e6737e1af 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c > @@ -1148,10 +1148,11 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer) > BusyThreshold = BusyThresholdLow; > > if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold || > - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) { > + pmlmepriv->LinkDetectInfo.tx_ok_in_period > BusyThreshold) { > bBusyTraffic = true; > > - if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > pmlmepriv->LinkDetectInfo.NumTxOkInPeriod) > + if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > > + pmlmepriv->LinkDetectInfo.tx_ok_in_period) This is just weird now. NumRxOkInPeriod vs tx_ok_in_period? The names don't match and the tx_ok_in_period name doesn't make sense. regards, dan carpenter