From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: abdurrahman@nexthop.ai
Cc: Michal Simek <michal.simek@amd.com>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v7 1/6] i2c: xiic: skip input clock setup on non-OF systems
Date: Sat, 31 Jan 2026 12:10:58 +0200 [thread overview]
Message-ID: <aX3VMloJdfsrLh9i@smile.fi.intel.com> (raw)
In-Reply-To: <20260129-i2c-xiic-v7-1-727e434897ef@nexthop.ai>
On Thu, Jan 29, 2026 at 09:43:13PM +0000, Abdurrahman Hussain via B4 Relay wrote:
> The xiic driver supports operation without explicit clock configuration
> when clocks cannot be specified via firmware, such as on ACPI-based
> systems. This behavior is implemented in xiic_setclk(), which returns
> early when either i2c_clk or input_clk are zero.
...
> - i2c->clk = devm_clk_get_enabled(&pdev->dev, NULL);
> - if (IS_ERR(i2c->clk))
> - return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
> - "failed to enable input clock.\n");
> + if (is_of_node(dev->fwnode)) {
Avoid dereferencing fwnode. Use dev_fwnode() API.
> + i2c->clk = devm_clk_get_enabled(dev, NULL);
> + if (IS_ERR(i2c->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
> + "failed to enable input clock.\n");
> + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-31 10:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 21:43 [PATCH v7 0/6] i2c: xiic: use generic device property accessors Abdurrahman Hussain via B4 Relay
2026-01-29 21:43 ` [PATCH v7 1/6] i2c: xiic: skip input clock setup on non-OF systems Abdurrahman Hussain via B4 Relay
2026-01-29 22:43 ` Andrew Lunn
2026-01-29 23:29 ` Abdurrahman Hussain
2026-01-31 10:12 ` Andy Shevchenko
2026-02-01 1:30 ` Abdurrahman Hussain
2026-02-02 13:21 ` Andrew Lunn
2026-02-02 18:26 ` Abdurrahman Hussain
2026-01-31 10:10 ` Andy Shevchenko [this message]
2026-01-29 21:43 ` [PATCH v7 2/6] i2c: xiic: switch to devres managed APIs Abdurrahman Hussain via B4 Relay
2026-01-30 10:48 ` Jonathan Cameron
2026-01-31 10:31 ` Andy Shevchenko
2026-01-29 21:43 ` [PATCH v7 3/6] i2c: xiic: remove duplicate error message Abdurrahman Hussain via B4 Relay
2026-01-30 10:49 ` Jonathan Cameron
2026-01-29 21:43 ` [PATCH v7 4/6] i2c: xiic: switch to generic device property accessors Abdurrahman Hussain via B4 Relay
2026-01-29 21:43 ` [PATCH v7 5/6] i2c: xiic: cosmetic cleanup Abdurrahman Hussain via B4 Relay
2026-01-31 14:35 ` Dan Carpenter
2026-02-01 2:14 ` Abdurrahman Hussain
2026-02-01 22:23 ` Uwe Kleine-König
2026-02-02 2:06 ` Abdurrahman Hussain
2026-01-29 21:43 ` [PATCH v7 6/6] i2c xiic: cosmetic: use resource format specifier in debug log Abdurrahman Hussain via B4 Relay
2026-01-31 10:55 ` Andy Shevchenko
2026-01-29 22:36 ` [PATCH v7 0/6] i2c: xiic: use generic device property accessors Andrew Lunn
2026-01-31 10:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aX3VMloJdfsrLh9i@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abdurrahman@nexthop.ai \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox