From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D210314A7A for ; Sat, 31 Jan 2026 23:59:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769903946; cv=none; b=bXryt+iwdMqQxGkDAPFuJMJzn0pKibOyH9eXNeDglvkqi3Vo9QthGKAPeMXMuJZxnbEywQbLJfVcnDTSPzoyrCk4XG2GugwEJyecFs6gaDscT6fwwxQvAG/Wt4gopHrRXfNlxH3mDOY7JsANoW/dpju+LrWCdkrmaeV4n6WAJsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769903946; c=relaxed/simple; bh=6eBJ6TImiTKj76ywie74xPnLw98jDK7LvXzNwK0KWIc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V39d/Yk6mwPADgkeBLHl3Gcw6v9JI+8xIYYCj3ooz9C1qgjPveIWlVPCCGnPP2/egCzxKdEspePUmS+Mu8z0rIECoJL254DYKdNcaBSWc1OidvIiIATxqL8+J8acQFjnHu6aeWLNNidU5f7zRQa+sDd9YtbhCcCb5UWgULRoE2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zGawk60f; arc=none smtp.client-ip=209.85.214.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zGawk60f" Received: by mail-pl1-f196.google.com with SMTP id d9443c01a7336-2a1462573caso61345ad.0 for ; Sat, 31 Jan 2026 15:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769903945; x=1770508745; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YtBPPhj1ayBDt09op5lwhUL/PZ+SFYgWzXzV09l+lfI=; b=zGawk60fBITUuy7VxylzO49SIkBPtddJ5ZqF/wGe94ovS3wM4+KNCBCp+DfGyAX7tS pql6GxBW/e8WR+9njAbYoOq3E56TwwJtfJ8VQEoXS9rbOIlGRKuS1maKLJcNKVfJNHss i4zXZrl9iZ1pAasb2uir27C27PDL0usKJlBclUJzMfjo6hagX12mW6vlNwwy9B0E9/r0 I5vhExN0NPxpDj6QcD428OhDBA/dOzytaD/p6FZ5lcr+Qlhln+5RUUwlKIXNWHPcM1NX b0gHOuqDur16NMCa3F0/X5JwTVR/aoRqdfllBfqk2IV4MRwjk83bcTZvtIK1uhd8gJbz 5dUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769903945; x=1770508745; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YtBPPhj1ayBDt09op5lwhUL/PZ+SFYgWzXzV09l+lfI=; b=l7pEIC5JM4ktU1IGQoRKRO0aTqrfZRbP7QhJVcogXMfj4K6MQcOdArBdN+Azgfiq82 GGgZRSPfePCump1cJmmPqbDrK3IKV2dXBbBYZpq1Daein629OepZMzOq+KzdbBzzsTXL OxrVzYiKsK7w93/jaNn5lEWZ2FDYVw5tdHTg8Pc02sqvTrgpNnGz+l2C6epTO32f43Rg uqmAoPdzyN9WADe4qfmRGO3c3zyPPqozga2EW4V06IphSdi7wmPFQhQS+fQeYoCByZ/4 1g4KWNBV/bRmb0GDEnS7zTdnJn2OyLhJOJROD8a0KxnhvpnHUIZRRyxC0HnDiqAb//e/ Kfew== X-Forwarded-Encrypted: i=1; AJvYcCVPvdtpJRXUx5VlagVEjykFrRHPyF/cgl9Lrxhp3eMbNnrRjwiiOdpNQ/END0SmPGYcui9U7aKxdZ+OWBU=@vger.kernel.org X-Gm-Message-State: AOJu0YweoMb1Vgc0eWrxAWeTkAEmotjTiwM392reXlLX5iMSNCa4EpfB y0Cd2A+yzyu+arjOuztwbLuUfdQz1ITqxTctmcjWQfz35/kQLjJ//mLnPezJJxxJwQ== X-Gm-Gg: AZuq6aLS1w9iIWREXAIhyGQT5M1ErkoLsM5H1yuvWVJCnMbr3NN2VNxqj7CsYG3qGSA Sxl/rFEnJzCXbujWmP1Jjg7aEbEoQBj90Hwbcqtti5FiRlwpRdAsz6To17wZqLaSWQlc99/KiPl d8ljh/sq30es09AaiVYCMePMWMZmEtaRiAdaTzfgKEBUVqoK118Mszg8a0tdtdeesRwddmvIX2c 2+0jr1jZy8jShsJDOCW/qDC1fzUSSdS8S1ophEiFRs9etMjA9tUoBWNx6FwtrCwkLozr0Edx37L mTkFsbv86Py/Ylwsf4NlIlS5h5cyQXYxuhEVzA5tiSEcD2eO9ABLI3mlugDx8Sb/0oWwDsn4Daj g9ZgWYalHLuM/brVFdkFVvbcfuJDuiSoHnayyuyr9yVu0TJ0DBUqPQOPMIAPUExbeheJe9QBpWe N9ArddCLRPdYNhsUYrOUy3C5N99DkNPwRKpe8Gmf445Sj2phxoJw== X-Received: by 2002:a17:903:110e:b0:2a0:867c:60e2 with SMTP id d9443c01a7336-2a8f50d2ee6mr1807895ad.19.1769903944481; Sat, 31 Jan 2026 15:59:04 -0800 (PST) Received: from google.com (130.15.125.34.bc.googleusercontent.com. [34.125.15.130]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6427da8441sm10057645a12.9.2026.01.31.15.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 15:59:03 -0800 (PST) Date: Sat, 31 Jan 2026 23:58:58 +0000 From: Bing Jiao To: Shakeel Butt Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Axel Rasmussen , Yuanchu Xie , Wei Xu , Johannes Weiner , Qi Zheng , Gregory Price , Joshua Hahn , muchun.song@linux.dev, roman.gushchin@linux.dev, tj@kernel.org, longman@redhat.com, chenridong@huaweicloud.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v9 0/2] mm/vmscan: fix demotion targets checks in reclaim/demotion Message-ID: References: <20260114070053.2446770-1-bingjiao@google.com> <20260114205305.2869796-1-bingjiao@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jan 30, 2026 at 03:35:26PM -0800, Shakeel Butt wrote: > Hi Bing, > > Please don't reply (i.e. use In-Reply-To) to older revision of your > series. Send each revision independently. > > On Wed, Jan 14, 2026 at 08:53:01PM +0000, Bing Jiao wrote: > > This patch series addresses two issues in demote_folio_list(), > > can_demote(), and next_demotion_node() in reclaim/demotion. > > > > 1. demote_folio_list() and can_demote() do not correctly check demotion > > target against cpuset.mems_effective, which will cause (a) pages are > > demoted > > pages to be demoted > > > to not-allowed nodes and (b) pages are failed to demote > > page fail to demote > > > even > > if the system still have allowed demotion nodes. > > > > Patch 1 fixes this bug by update > > updating > > > cpuset_node_allowed() and > > mem_cgroup_node_allowed() to return effective_mems, allowing directly > > logic-and operation against demotion targets. > > > > 2. next_demotion_node() returns a preferred demotion target, but it does > > does or does not? > > > check the node against allowed nodes. > > > > Patch 2 ensures that next_demotion_node() filters against the allowed > > node mask and selects the closest demotion target to the source node. Hi Shakeel, Thank you for taking the time to review this patch series and for the helpful corrections. I also appreciate the reminder about the patch replying rule and will make sure to send future revisions independently. Have a great weekend! Best, Bing