From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Vishnu Sankar <vishnuocv@gmail.com>
Cc: mpearson-lenovo@squebb.ca, hmh@hmh.eng.br, hansg@kernel.org,
corbet@lwn.net, derekjohn.clark@gmail.com,
ilpo.jarvinen@linux.intel.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net, linux-doc@vger.kernel.org,
platform-driver-x86@vger.kernel.org, vsankar@lenovo.com
Subject: Re: [PATCH v6 1/3] input: trackpoint - Enable doubletap by default on capable devices
Date: Sun, 1 Feb 2026 08:09:34 +0000 [thread overview]
Message-ID: <aX8JwB7F8_ypJRAz@google.com> (raw)
In-Reply-To: <20260127103907.20269-2-vishnuocv@gmail.com>
Hi Vishnu,
On Tue, Jan 27, 2026 at 07:39:05PM +0900, Vishnu Sankar wrote:
> @@ -470,6 +509,14 @@ int trackpoint_detect(struct psmouse *psmouse, bool set_properties)
> psmouse->vendor, firmware_id,
> (button_info & 0xf0) >> 4, button_info & 0x0f);
>
> + /* Enable doubletap by default on capable devices */
This is obvious from the code, please drop the comment.
> + if (trackpoint_is_dt_capable(ps2dev->serio->firmware_id)) {
> + if (trackpoint_write(ps2dev, TP_DOUBLETAP, TP_DOUBLETAP_ENABLE))
> + psmouse_warn(psmouse, "Failed to enable doubletap: %d\n", error);
> + else
> + psmouse_info(psmouse, "Doubletap enabled by default!\n");
Drop psmouse_info(), no need to make the driver too noisy.
Otherwise:
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
--
Dmitry
next prev parent reply other threads:[~2026-02-01 8:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 10:39 [PATCH v6 0/3] TrackPoint doubletap enablement and user control Vishnu Sankar
2026-01-27 10:39 ` [PATCH v6 1/3] input: trackpoint - Enable doubletap by default on capable devices Vishnu Sankar
2026-02-01 8:09 ` Dmitry Torokhov [this message]
2026-02-02 3:56 ` Vishnu Sankar
2026-01-27 10:39 ` [PATCH v6 2/3] platform/x86: thinkpad_acpi: Add sysfs control for TrackPoint double-tap Vishnu Sankar
2026-01-27 10:39 ` [PATCH v6 3/3] Documentation: thinkpad-acpi - Document doubletap_enable attribute Vishnu Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aX8JwB7F8_ypJRAz@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=corbet@lwn.net \
--cc=derekjohn.clark@gmail.com \
--cc=hansg@kernel.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vishnuocv@gmail.com \
--cc=vsankar@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox