From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4EA22D0622 for ; Wed, 21 Jan 2026 00:52:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768956727; cv=none; b=XjjmSmX0nwPqcq87COzs8M5B6YBzCYaq8THjmpmd7DeEUsnidgirKcSuiiDDMV5+izXxkr5S5oLsDgRl2DhIW6Vn3Al4OiNcRJ07qzNK9q47bMU1V0RSdMzGaUgtBRu3/YLGdEwAreaMfR4CAcLl5a1gkTmatVs9et5x8OB67N8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768956727; c=relaxed/simple; bh=EkVcNVO1CNLIf3T/s28sXrF08YLCrCvJ5AM2yKBw9Zg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Dg6q5qqVXe7syIcDCcJP+ZUmQiUlkYZLXlfTXkOAihG1s6rrpRunYm1jmTxGZQpXv0GpTmMRNV0TsTrhZWlteSM+pa3tb271vTJkZ+RzIhQJPIn7FM/EANZ0CTUjV5Yo59dH+3ReraR/SOuUf5RUSYI94/rULaHlC3RWKVerelI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=foEPk1Px; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="foEPk1Px" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2a78c094ad6so5394945ad.1 for ; Tue, 20 Jan 2026 16:52:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1768956725; x=1769561525; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=+MdgG0Ul2crpYgoSbV/KPCK+3WNDc/xDp+a+HIFVTx8=; b=foEPk1PxlmMmBL/K5FC3+xojidM8Udkpz0XkmLQGlFju2kBm/dmXLwIIspG8CT5rtV cl6kzo4URhDm/pke7/1Bdvp9c1tR6CjZ3TnpG3QxmP6x8B1TxH8UqNMcKo3SaPD70mzr yxYWxiksno5Z2VaNR2/ifWI9tOIX8Ja/TvEYyZUqVlsgdApSMqh863BIDg1VQy8n0QlS wJaZnIPqk3QUBe386fze6KmupD6532cAYLvKH/04sr7PojrbE9Kad31XHAGS9EOFvoZe pSPKnRdQAzUfYzeDsclPZaXp93Cg5k/QS8ZTlb2QNhlIjmzgLbOtXqmPEXTY6LYDsQ54 AeRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768956725; x=1769561525; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+MdgG0Ul2crpYgoSbV/KPCK+3WNDc/xDp+a+HIFVTx8=; b=kc7ANMPSZU7sLU0jtCYv6P5mqmJnDfB4D1hI55iWHgrpDh6GtSMrtWXSHkc5Hl4/ny c2tIrAeJCsgNHdaiLSdKg4urUDKq1/WN37CZBNKxjLZ1z0slS6BhvZvcIY9hOXoDcnsC whTAz1SbRFHrGKTlgkBJzhcSG9pSISUmSF4WN1PUVFHRSyX+9qqjxpd2BwLziCg6vzwX zyB2rMj0HZVpRomzzRWijLPlMJcFtMnS9wCmjHmXRq80J1vz4+xxjTOhSXYwGuApA5VG RmyFje4XIWtKPDoVbxmzKnNUnGF7TUisSUqUdUyM+FdHQT6qvejIeL1pxHmPt+UZP2FI Vgcw== X-Forwarded-Encrypted: i=1; AJvYcCXjr1aHxWo95u7n6fBt2v49T5R/xORdPyL72jOHyEMD8puRB+KVjbYVRaHTIPJIBrcpd8dj5qL8LG4A1aI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/2j6h7e1QvSqBHP676Ex4F8F5fvMfT+uB5sZMPqQSu7xZvgdN ryLEnloN4Fjt6WNOOsp1C2U/6KeaGPvqo2OBjL7Rh89YRQYLamEC4S2dkO8J3cRqz/fXIycmUe4 2rRH4aQ== X-Received: from plbmt16.prod.google.com ([2002:a17:903:b10:b0:2a0:c208:8799]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:db04:b0:2a0:bb05:df55 with SMTP id d9443c01a7336-2a76951f3a7mr29795775ad.21.1768956725049; Tue, 20 Jan 2026 16:52:05 -0800 (PST) Date: Tue, 20 Jan 2026 16:52:03 -0800 In-Reply-To: <20251121005125.417831-13-rick.p.edgecombe@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251121005125.417831-1-rick.p.edgecombe@intel.com> <20251121005125.417831-13-rick.p.edgecombe@intel.com> Message-ID: Subject: Re: [PATCH v4 12/16] x86/virt/tdx: Add helpers to allow for pre-allocating pages From: Sean Christopherson To: Rick Edgecombe Cc: bp@alien8.de, chao.gao@intel.com, dave.hansen@intel.com, isaku.yamahata@intel.com, kai.huang@intel.com, kas@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, mingo@redhat.com, pbonzini@redhat.com, tglx@linutronix.de, vannapurve@google.com, x86@kernel.org, yan.y.zhao@intel.com, xiaoyao.li@intel.com, binbin.wu@intel.com Content-Type: text/plain; charset="us-ascii" On Thu, Nov 20, 2025, Rick Edgecombe wrote: > static int tdx_topup_external_fault_cache(struct kvm_vcpu *vcpu, unsigned int cnt) > { > - struct vcpu_tdx *tdx = to_tdx(vcpu); > + struct tdx_prealloc *prealloc = &to_tdx(vcpu)->prealloc; > + int min_fault_cache_size; > > - return kvm_mmu_topup_memory_cache(&tdx->mmu_external_spt_cache, cnt); > + /* External page tables */ > + min_fault_cache_size = cnt; > + /* Dynamic PAMT pages (if enabled) */ > + min_fault_cache_size += tdx_dpamt_entry_pages() * PT64_ROOT_MAX_LEVEL; The caller passed in number of pages to be added as @cnt, don't hardcode what could be conflicting information. If the caller wants to add 50 pages, then this code damn well needs to prepare for adding 50 pages, not 5.