From: Breno Leitao <leitao@debian.org>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
pmladek@suse.com, john.ogness@linutronix.de
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
asantostc@gmail.com, efault@gmx.de, gustavold@gmail.com,
calvin@wbinvd.org, jv@jvosburgh.net, mpdesouza@suse.com,
kernel-team@meta.com
Subject: Re: [PATCH net-next v2 1/5] printk: Add execution context (task name/CPU) to printk_info
Date: Wed, 21 Jan 2026 03:41:49 -0800 [thread overview]
Message-ID: <aXC6MNOJidrYuSy0@gmail.com> (raw)
In-Reply-To: <20260120-nbcon-v2-1-b61f960587a8@debian.org>
On Tue, Jan 20, 2026 at 08:23:47AM -0800, Breno Leitao wrote:
> Extend struct printk_info to include the task name, pid, and CPU
> number where printk messages originate. This information is captured
> at vprintk_store() time and propagated through printk_message to
> nbcon_write_context, making it available to nbcon console drivers.
>
> This is useful for consoles like netconsole that want to include
> execution context in their output, allowing correlation of messages
> with specific tasks and CPUs regardless of where the console driver
> actually runs.
>
> The feature is controlled by CONFIG_PRINTK_EXECUTION_CTX, which is
> automatically selected by CONFIG_NETCONSOLE_DYNAMIC. When disabled,
> the helper functions compile to no-ops with no overhead.
>
> Suggested-by: John Ogness <john.ogness@linutronix.de>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> Signed-off-by: Petr Mladek <pmladek@suse.com>
> ---
> drivers/net/Kconfig | 1 +
> include/linux/console.h | 8 ++++++
> kernel/printk/internal.h | 8 ++++++
> kernel/printk/nbcon.c | 15 +++++++++++
> kernel/printk/printk.c | 52 ++++++++++++++++++++++++++++++++++++++-
> kernel/printk/printk_ringbuffer.h | 4 +++
> lib/Kconfig.debug | 20 +++++++++++++++
> 7 files changed, 107 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index ac12eaf11755d..12e47cb27ffa5 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -341,6 +341,7 @@ config NETCONSOLE_DYNAMIC
> bool "Dynamic reconfiguration of logging targets"
> depends on NETCONSOLE && SYSFS && CONFIGFS_FS && \
> !(NETCONSOLE=y && CONFIGFS_FS=m)
> + select CONSOLE_HAS_EXECUTION_CTX
This is wrong as detected by Kernel test robot.
https://lore.kernel.org/all/202601211304.r9ecHy9L-lkp@intel.com/
On csky, CONSOLE_HAS_EXECUTION_CTX is set, but not
CONFIG_PRINTK_EXECUTION_CTX
https://download.01.org/0day-ci/archive/20260121/202601211304.r9ecHy9L-lkp@intel.com/config
The execution context fields were not available, while
NETCONSOLE_DYNAMIC, causing a compilation error.
It needs to be:
+ select PRINTK_EXECUTION_CTX
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-21 11:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 16:23 [PATCH net-next v2 0/5] net: netconsole: convert to NBCON console infrastructure Breno Leitao
2026-01-20 16:23 ` [PATCH net-next v2 1/5] printk: Add execution context (task name/CPU) to printk_info Breno Leitao
2026-01-21 11:41 ` Breno Leitao [this message]
2026-01-20 16:23 ` [PATCH net-next v2 2/5] netconsole: extract message fragmentation into send_msg_udp() Breno Leitao
2026-01-20 16:23 ` [PATCH net-next v2 3/5] netconsole: convert to NBCON console infrastructure Breno Leitao
2026-01-22 21:09 ` Simon Horman
2026-01-23 10:48 ` Breno Leitao
2026-01-23 18:04 ` Simon Horman
2026-01-20 16:23 ` [PATCH net-next v2 4/5] netconsole: Use printk context for CPU and task information Breno Leitao
2026-01-21 5:40 ` kernel test robot
2026-01-20 16:23 ` [PATCH net-next v2 5/5] netconsole: pass wctxt to send_msg_udp() for consistency Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXC6MNOJidrYuSy0@gmail.com \
--to=leitao@debian.org \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=asantostc@gmail.com \
--cc=calvin@wbinvd.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=efault@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=gustavold@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=jv@jvosburgh.net \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpdesouza@suse.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox