From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com [136.143.188.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 774F8480958; Wed, 21 Jan 2026 09:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768988928; cv=pass; b=UAnyTUIxn/SoFBIA7seyvmQEgVsaNGpABA9LZhAV8ZVxCXla4uxe7w/EEVkoj8j6JzIxLqX5hSI/+0hhxXx2pC2kzeyHvjh4av14VnsZmAKrOETJfGTzcPc/CQPHmLtxFz9xDYYB7z2iTkPoWsPOVTAkWeYb1qB76OxHn54R9fA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768988928; c=relaxed/simple; bh=sd7IA0A7SQWL2T3hI/68jTZfSCthKxNTO4tyqSxyWBw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GoGxfalc8V3YxG3P1wUTNNcYT9Uq0cks+wPA4de/GbCtt5fiv4VLwM0lRau9Jjw3J1Np8W09rI2w9CiJRtbgwdhDsfaQ5HZyVZ9DZRuAYmvTsId9l4C/Ewn5pC69P1EeZdPqX2AjdbEpk2VMY6LqSHJHPfTsVp32NTfIOktpfbo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ziyao.cc; spf=pass smtp.mailfrom=ziyao.cc; dkim=pass (1024-bit key) header.d=ziyao.cc header.i=me@ziyao.cc header.b=EnhSRich; arc=pass smtp.client-ip=136.143.188.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ziyao.cc Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziyao.cc Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ziyao.cc header.i=me@ziyao.cc header.b="EnhSRich" ARC-Seal: i=1; a=rsa-sha256; t=1768988912; cv=none; d=zohomail.com; s=zohoarc; b=bD2gp45kFPvNMwF3ySU1AMZfN1sFmTE7Xt+QTbOj6iJge6qIgzPo67l/PxzlZoGXrOZBal0KQTKc27WYISBjNmA61s5rt3idyOt6AsguIkHfW8KeX81+E3HB/l+FFaxJ7eUFpYL/2GYJAZBJFI6pPbIQ8wv/XuBBUp+rILn/uFQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768988912; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=ufXXGD5mAV0c390kumAehnWTdRsR7RIJF5HIUbbINyE=; b=QksGkK7pE7yHtBoDPFiKXPc0abDGyjlDOHtrGGi80yCI+wy9NKPXeTJo691VUGeZCUYVKenczQNPeUNgaMC+q3vgLj/iAoHYPIq4j3tC1zq8i/qb7ExD3/HpYiJCQaflzF4sznXEcCvR/P15wGZdr32WrIqJnncCTLxk7VaZ5Ro= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=ziyao.cc; spf=pass smtp.mailfrom=me@ziyao.cc; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768988912; s=zmail; d=ziyao.cc; i=me@ziyao.cc; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=ufXXGD5mAV0c390kumAehnWTdRsR7RIJF5HIUbbINyE=; b=EnhSRichXNJut4xGlUb1vfKj2oR2wVBdjsmeaFWIJa7v/9FxEFOwDVUeRRGSDySK PZckRIoKS6hkqpxlxnrxTSfxjYV17/g3CgAY2J4UXJJEDhRTBlQ/+47nfj7oRREioTD kWtdAAYvNVdMafUv/3/jLxYo1GfLR1Otx5/4CtTM= Received: by mx.zohomail.com with SMTPS id 1768988910308507.3525632519347; Wed, 21 Jan 2026 01:48:30 -0800 (PST) Date: Wed, 21 Jan 2026 09:48:19 +0000 From: Yao Zi To: Yixun Lan , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Adrian Hunter Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mmc: sdhci-of-k1: spacemit: Add support for K3 SoC Message-ID: References: <20260121-07-k3-mmc-v1-0-ff77c07bfdf6@kernel.org> <20260121-07-k3-mmc-v1-2-ff77c07bfdf6@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260121-07-k3-mmc-v1-2-ff77c07bfdf6@kernel.org> X-ZohoMailClient: External On Wed, Jan 21, 2026 at 03:27:36PM +0800, Yixun Lan wrote: > The SDHCI controller found on SpacemiT K3 SoC share the same IP with K1 > generation and introduce a compatible data to denote the change that broken > 64BIT DMA issue has been fixed. > > Signed-off-by: Yixun Lan > --- > drivers/mmc/host/sdhci-of-k1.c | 22 ++++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-k1.c b/drivers/mmc/host/sdhci-of-k1.c > index a160e1d5d9bd..a56cb8a36982 100644 > --- a/drivers/mmc/host/sdhci-of-k1.c > +++ b/drivers/mmc/host/sdhci-of-k1.c > @@ -259,8 +259,20 @@ static const struct sdhci_pltfm_data spacemit_sdhci_k1_pdata = { > SDHCI_QUIRK2_PRESET_VALUE_BROKEN, > }; > > +static const struct sdhci_pltfm_data spacemit_sdhci_k3_pdata = { > + .ops = &spacemit_sdhci_ops, > + .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK | > + SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC | > + SDHCI_QUIRK_32BIT_ADMA_SIZE | > + SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN | > + SDHCI_QUIRK_BROKEN_CARD_DETECTION | > + SDHCI_QUIRK_BROKEN_TIMEOUT_VAL, > + .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, > +}; > + > static const struct of_device_id spacemit_sdhci_of_match[] = { > - { .compatible = "spacemit,k1-sdhci" }, > + { .compatible = "spacemit,k1-sdhci", .data = &spacemit_sdhci_k1_pdata }, > + { .compatible = "spacemit,k3-sdhci", .data = &spacemit_sdhci_k3_pdata }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, spacemit_sdhci_of_match); > @@ -271,10 +283,16 @@ static int spacemit_sdhci_probe(struct platform_device *pdev) > struct spacemit_sdhci_host *sdhst; > struct sdhci_pltfm_host *pltfm_host; > struct sdhci_host *host; > + const struct sdhci_pltfm_data *data; > struct mmc_host_ops *mops; > int ret; > > - host = sdhci_pltfm_init(pdev, &spacemit_sdhci_k1_pdata, sizeof(*sdhst)); > + > + data = of_device_get_match_data(&pdev->dev); > + if (!data) > + return dev_err_probe(dev, -EINVAL, "failed to get platform data\n"); Is there a need to check against return value of of_device_get_match_data()? It isn't a user input, instead missing the data seems a kernel bug to me, and shouldn't happen in production. Regards, Yao Zi