From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 383C2328B49 for ; Wed, 21 Jan 2026 12:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768997601; cv=none; b=JMjDmISl03hHoJe9rjWMIo2xJXmU1L0Q8pYE3uYCfosYvzOdViZqcj4UcWru0cvEgTukCQbcZ0N3RkPY4iRtXgoFpqdPHiVaLmqByAF0eBDBJc4sjmwQvYQ4rPNNqfZww0bVol37B/UbApMujlFJkQDlGifd9mZMlqX8yGwPYqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768997601; c=relaxed/simple; bh=qDFiPsQd7u1wnrVS3oazet16Ydulh8g1v7jumUh6+Bk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MqSx2QU8VPWNC3PPz5qxXQkuX7Tw5K4fuDQ/EnMLnQWG88nOkCW2AmrbCZLPJcqqRA3Rw3H/fDtoUKeJDGSUm4mkI+xEZ6A+AGlzevIbYnLWirubSn5BiduYBjQeOxnvUj45z9y8936PifFdWMlx+0hMRs3js8ET5GkmH0esqVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eA3bkvMt; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=s8lMIiSC; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eA3bkvMt"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="s8lMIiSC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768997599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pR1+T8ar2wUy/+ZR9alOHlg05/eYLbiG2l/Es9gVEDs=; b=eA3bkvMtsf9o3hPE2nOLaEvBjD2RI5ly12Ep4pJ7c3gFGM/vmqva5/bv8bNS5yfXCcLqTM 6F2JEsqw/P4Zl6MRl2S6+0yoia49dnWCxcAf6mYmVJu7aiKTpCQRgkPSdZH6S4fpavgM+/ 5o5kccGBG6QVnFZ8Xpmh90iUY4Kd0Y4= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-cNhraBrxM_-8lkGRZ-2_zQ-1; Wed, 21 Jan 2026 07:13:16 -0500 X-MC-Unique: cNhraBrxM_-8lkGRZ-2_zQ-1 X-Mimecast-MFC-AGG-ID: cNhraBrxM_-8lkGRZ-2_zQ_1768997595 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-890586c53e0so173769366d6.2 for ; Wed, 21 Jan 2026 04:13:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768997595; x=1769602395; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=pR1+T8ar2wUy/+ZR9alOHlg05/eYLbiG2l/Es9gVEDs=; b=s8lMIiSCqEVd/RivFftjKTGaB4ikH2hLtYg0d5g8/L2hwDV6q5/ipGQOPC+NwStojf MzRfZAur/RFkRotOR1UIvIEh4kvnYZh17NG9dloGpsMo7Zro62YD8yBN0l6h96NFeXO8 50tcHDbdWwEBEjeuhuR4svWemIGZ6UshOjDZfK7HqStnyCbAiXmIXC3TI8LbIUvmC7DB iaj+sTyClqocF7ctuFzJXvkNfFSAtcu3se1HXddarBQpO5iYOBnFdFBRXU9FHTykTGbO yOoZw1zIAO4zdADigbejMT0holBesBdD8vVIOy2SmrUu+0CP8Kl8PYf/nQORT7ZVNEI+ 85tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768997595; x=1769602395; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pR1+T8ar2wUy/+ZR9alOHlg05/eYLbiG2l/Es9gVEDs=; b=t3BOY2NW1b0g7nEhEzfu9BEdnUurjZro0qDWcd0SbK0ECqn3cPprDXFpE2JGP66twm J+XCgx/dX8A47sNVy5yh0JPtap9V1OwUC6uU1JGpJjv+WJgxvoG0YxUMIENrUSF0M07r ABrYi3JUAvCR2giNUspVfinO9ulWT//tRnda4IPecWxrq9Wh5iUA62Be6QRy2+7pBDJW I6UCckhowVEOOMwOe0au2kVxqSglIte4aWQLU5BBTSp2x7cj+eH5qMa8pAJ6on/WjF+k OBM6cX29QaGwUE1S/Y3H8o2XpQVqNzGJdhDceXwaA9bP4c8MNu0uONOFkaR874iK1mtY k2tg== X-Forwarded-Encrypted: i=1; AJvYcCUkZML5DT5sdNJPgS26D7rn8w/kSJ1dVzr8u5tAPUxvAZNqEkl8p0L39ibB76Cetgdbylv2FzCamycCyqg=@vger.kernel.org X-Gm-Message-State: AOJu0YyVTF1XuFsM+n20MSwsxvR6bwk3WIlIJ8neYwI82lkrVPJsE/Gz h6S780lvG6wygzRa0vpM9e1WhsMySjd59+5ttUoltKcpSNWeQ+IORUbiN4SqID4ewF2uNUY/bIu vaY0iYtL0o4XKS4GMBGlo9fSLicFiUVZuLiPjLxF///PUkk2O0qrK3LgvF3GzYtz8Zw== X-Gm-Gg: AZuq6aKQ7MDloUVvFdvAdqQgOUQmXkBJliSMvkQKU9w/E9tl42jdRGcSYhjvN2aETXG 6ZIeaNmG69iasCpuW3N4JBrA4f/h20PMNzf7og48uIJCuRmnPByQNZWVwKNaBE+VQSpJ6Q2yZk4 pNwXx93Y+aW3vKfvf4kYEejDjV8RSZtA/Njn8OU4smQxCs+yuqRDtzl1wZI2/qCU8EqQtqjnTMn 5wQyKpt8lXZzg/TrBjFM9s1PkuHYG1+N2gn1ZIRmnUUDuYjWSV7v+SqYfR524aZWT3ZE9g2lL7P 6JXPhlF/oH+TQVBfD6COyTHvf24Mc8Flqqqiphk8gy/K6HCfUHPZTu+4dDr6PMiKuw9kuOm0fib TF6LM6LC1RhZ9gOHCFcWvmM1bBuxYvAFYH/zNhGcRaZEI X-Received: by 2002:a05:6214:5181:b0:888:4938:49e5 with SMTP id 6a1803df08f44-89463ec1bbcmr67876396d6.69.1768997595493; Wed, 21 Jan 2026 04:13:15 -0800 (PST) X-Received: by 2002:a05:6214:5181:b0:888:4938:49e5 with SMTP id 6a1803df08f44-89463ec1bbcmr67876096d6.69.1768997595126; Wed, 21 Jan 2026 04:13:15 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8942e60428dsm133105716d6.22.2026.01.21.04.13.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 04:13:14 -0800 (PST) Date: Wed, 21 Jan 2026 07:13:13 -0500 From: Brian Masney To: Vinod Koul Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , linux-phy@lists.infradead.org Subject: Re: [PATCH 25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate() Message-ID: References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> <20260108-clk-divider-round-rate-v1-25-535a3ed73bf3@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) On Wed, Jan 21, 2026 at 01:26:05PM +0530, Vinod Koul wrote: > On 15-01-26, 09:18, Brian Masney wrote: > > Hi Vinod, > > > > On Wed, Jan 14, 2026 at 07:47:18PM +0530, Vinod Koul wrote: > > > On 08-01-26, 16:16, Brian Masney wrote: > > > > The divider_round_rate() function is now deprecated, so let's migrate > > > > to divider_determine_rate() instead so that this deprecated API can be > > > > removed. > > > > > > > > Note that when the main function itself was migrated to use > > > > determine_rate, this was mistakenly converted to: > > > > > > > > req->rate = divider_round_rate(...) > > > > > > > > This is invalid in the case when an error occurs since it can set the > > > > rate to a negative value. > > > > > > Acked-by: Vinod Koul > > > > Thanks for the Acked-by. > > > > However, this patch depends on this other series of mine that's merged > > into your phy tree: > > Should I pick this one then..? If there are no other dependencies... Yes, this patch stands on it's own, and it would be great if you could pick up this patch in your tree this dev cycle. Thanks, Brian > > https://lore.kernel.org/linux-clk/176661322399.4169.14248756511703978007@lazor/ > > > > Stephen asked for an Acked-by for that series or an immutable branch. > > > > This will allow us to remove round_rate from the clk core. > > > > I also have a small series to post that's dependent on all of this that > > lets us get rid of the noop determine_rate implementations that only > > 'return 0'. I haven't posted that because of the dependencies. > > > > Brian > > -- > ~Vinod >