From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5291F43CEC3 for ; Wed, 21 Jan 2026 13:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769001775; cv=none; b=UtaHZE9B5JSaty+BNsPyAnDrJV9xQPsNUgKxD0To5CKem5j0vP6W994wJnSaRUhCrQXOfSlwKhqVBV7nrYVOUD0MoZiVqZLA9OEbypTq2enRfTGCVcyjX+xJ2unAC2fnFxmwqhHdZOcXyOzwsx4kNEwdjxyAiOGQqPUbJwSNBbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769001775; c=relaxed/simple; bh=ZavgKeWDWFbzS7ugt3+EwFwUx0NLOnAlsk8Wzc8/CD4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Whx7Y7A9BycBHLkujblth+Dtr9rW9p3yDwUuzj+qkfJiUffzAXp5cKFtQXRAWTEFAeMh3uUWe7EgD6z/+WE2mLwAC+8dUveTyfcbPjh9wXf86owzCnkz6zt4MuI9jlp+qSVcJTFKlKA3awKw9psWnqY9G6/qbwY+xoyo8IO53Cw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V6jOl9p2; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V6jOl9p2" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-42fb4eeb482so3718071f8f.0 for ; Wed, 21 Jan 2026 05:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769001768; x=1769606568; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ib6Jai1GIKJu0DpRL1ZJv9udL93XPA+w/9VXfQNMmzg=; b=V6jOl9p2uvOdPEHod1oC/IJ4s1utB99IWrj1WZDmLLc3sp58qGgWYxvX7Yq9xAEIZn L6jVJnVi0iMIFb9YHnR6b0DTqU4ZeL7zP6vgX89rU3wYB4XFgLDmaHzTVGIBBCaauw50 ZA94QWRjWEI2PxlAjg9JRJMPdtuhurUwXVchELLxAdP9lCQSElz0RXJby6wLYWlJboEV DBPjdEaxzNX9UHJ4OreLLaGuT/9k6quMrEV3KEDcSVZ2etyNEh4Ob0DAMkYl5lmtek89 iPvk2zIcRAUkuNXlJ/Tcb985jNmRGDA5g/PbajcDqh9Hwt2owpdw+ISAAshPKaOz2ExP TX2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769001768; x=1769606568; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ib6Jai1GIKJu0DpRL1ZJv9udL93XPA+w/9VXfQNMmzg=; b=HlQONaMmer5eBMdRCdejPO+rd4K/Tspec4PuVZUf5/oRF8LqNWNTfZRwNSWazioFFP KLWL3VhOeyFBpQxHZ5mHN2Mez9+X96FurCHw2cr5MEwleohe/Cc+w4jPo3afeqU9knwM juhNX2m7Ifr0Efr4V1gwd3Z+7pJ5QfxUGKgmv9rEtkSJGgew/fBxRt/JeCH1iLlXBwMJ FpubNBjXGbwH3omst7elJLGs91Q+5eBJs9XBJZVn3Eb9a/Vu6RT2PTJOxCOvfQnGyN97 E1gNj63TaE7FgvWHsP6GT6X7NL+khx6CI0I09WsQ+sE13SzF6sTcq/i4BlZhLXbHmTSL /JMQ== X-Forwarded-Encrypted: i=1; AJvYcCUV4Xwk5w1gE7yQ70Qu5gxJs5ttAvTRommtda6XbsmCSt9idSOj2ISY+vP7lRnd3HSeWPtQR2aTVtotP68=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2Lt1d/Tet6MUamRJva7fc4w++RvgzMAPnZrwb9g+D2j4i0tEL QpFX9weAIDL+3roEdUDGw6l5K5fRMSXuuobpGJwocld22fMae60haQhkhjKVMoT9jm4= X-Gm-Gg: AZuq6aLJYKPNNWdqqUYgbD/xWstRXdMFlZQKr209C3kS9TDc5EZp0gzoaU2kZMTS+Ft ylpaM6d5eYnKs2hdn3NbF72o5mw2vPz1MLt9Ky82DXfTh3lEwbNklMfvt+3RfNwToNMXy+xk6wo QZo1DN4lNdiQA449qzFAfMgK4RuCgKDrbwHUsirqRlZlXRDTsxKAV2lf/8rAwr6UAecJ3fm26f1 SmHXvvkJUpdmPBaX9YvDYCK+9GEYazfQlGlaJMihKOQgrji1Jq4815E4Y3aGR6BnRTaP6QlXVDO LRB9+I0N8PB49CcycdUxVp+t2l3iXo/2gEmoVaGxdj17L7QJdyJauTV1+2HY6Z9uQ6PwZooTZRi JqfZSfBQ+62rIB9HnRQ/Y3wNc5Qnp3LC/AtnF8/x/DIwWQQ4Pfb2oSSNT5yXEYZzoLHf0toaEoR evY0/uZ3ZQ/ZzVipgx X-Received: by 2002:a05:6000:184f:b0:42f:9f18:8f59 with SMTP id ffacd0b85a97d-4356a060d83mr27589585f8f.42.1769001768495; Wed, 21 Jan 2026 05:22:48 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43595609c8asm8914386f8f.34.2026.01.21.05.22.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 05:22:47 -0800 (PST) Date: Wed, 21 Jan 2026 16:22:44 +0300 From: Dan Carpenter To: 2023060904@ycu.edu.cn Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org, guagua210311@qq.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] rtl8723bs: Refactor continual_io_error check Message-ID: References: <2026011937-snugness-movie-9e32@gregkh> <5A122A378F3E53A7+20260120141129.8262-1-2023060904@ycu.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5A122A378F3E53A7+20260120141129.8262-1-2023060904@ycu.edu.cn> On Tue, Jan 20, 2026 at 10:11:25PM +0800, 2023060904@ycu.edu.cn wrote: > From: Changjun Zheng > > Refactor the error count check logic to follow kernel 'single responsibility' principle: > 1. Move the increment logic (atomic_inc) from rtw_inc_and_chk_continual_io_error() to its callers in sdio_ops_linux.c (line 226/302) > 2. Keep only the check logic in rtw_inc_and_chk_continual_io_error() (use atomic_read to get current count) > > This change addresses Greg KH's feedback to move increment to callers, while keeping atomic operations to ensure no compilation/run-time errors. > There are a lot of style issues in this patch. I also still don't really understand why we are doing this. Was Greg's email this one? https://lore.kernel.org/all/2025121757-crowbar-junkman-a96a@gregkh/ I'm guessing that Greg wants you to change this to refcount_t. regards, dan carpenter