From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53C9743900B for ; Wed, 21 Jan 2026 22:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769033069; cv=none; b=OMKgiBg8J1BxnipNhtb1Tke9PDoYX4dQ6p51xLiIpw+siUgQwFw2wwNq06TQOPDzK/ZmYV8mbmD/Sm2juRRBTAcYNQCeHto/mzQ6S5j8z3l7XGse1frg0Zxa4udlHIqX8lTklV5ALq6fPITOUR4WfH63fo8fCV06nks/EUZ4MMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769033069; c=relaxed/simple; bh=BPC40cd+PK6beKXkMEkAPgW8Vuk6zBAwXi60FwrFXDU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F3TSwfdMqTNc7nqZXxDC8XY8SSUPXaKGU54gRMyPuWnnCh8qfAkrSr4Y94knNPD/7ckrViAfyMpZJNxTEbsrhFo+Qhw/UmERs3961s8JKMXZeTy1AZe4CLqE/YIDV3ICyYFsELbh2V8JRiPVORUSyYWo5ifMnZ73DBb7Hc5wOX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lnc/OCVx; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lnc/OCVx" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-47fedb7c68dso3190585e9.2 for ; Wed, 21 Jan 2026 14:04:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769033065; x=1769637865; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CJ68qOu/lJJCVxKn/HKtPSCAAtAx0dItgoT8Dw3lvcE=; b=Lnc/OCVx4gJnZ/x2tFPCQgcXmDatmD16iiKDPuMLI0gEK1O0lsFjr5I/dukAODtwMD +KxvBiUbQLJiayd5eR3ePPd3pKxFrptiCURDoW0YHhfOHz8nwFyVS6V3gTFeoM7D15/O 3A2kBjXUon0I904hqTm5S14EzBoYiYHnmHz2ifopkmCKaTTeYBQUGceFSzq4bkcxHyRU Fo1wBVblhit2N3Ko+3fYX4ie84/zFjQWPtmvFogS1hvshclw1rFVQxdVVRrE8D1l9dJR J1amcpEbZEvzuHKTLHoU5XIoHHKk4iATqQSD8BE0lJVoYnAoqYKNvn20DBiXWTEAEQZg ruTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769033065; x=1769637865; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CJ68qOu/lJJCVxKn/HKtPSCAAtAx0dItgoT8Dw3lvcE=; b=IgpDscWbLLgyxd0Z2kttE82PNtys9tVhe+4V/43HXgDV5hYsH/yKaTqFxe9zDNRuMx PL77P3bFxIl+p3/fK50iGHz543OnuyVjUiHEbeOkiTkaHTAWHY9ocLQMogJyn9Dnf6NZ 1gH6ZAIdzPLpN149k/hpHQXUdRDApCi3W6BOS8FWzXvsIEZDklgKAFOMnB8drcNmJDZJ yGUEpmdEqUGgH0SFOBwbhxBcwRqF5Pe0SUzTq9hWAagRk/eapVfpwcAKuGL+KGwaNK70 EHehNR49lkq5U8LnsBPnRitpGWsltptKwgNPoe6w4uYdqjPzwMPZ5Y3m7KgAFuzqMZiv 6rxQ== X-Forwarded-Encrypted: i=1; AJvYcCVx7Dd4Dt6umKoO0IN8bEmmjjMuPwCC5vzjIbA9/e2l0n0TJ+6vXnbLmGhXirVIZChXnKB4/NjY7ERwkLs=@vger.kernel.org X-Gm-Message-State: AOJu0Yyso8CTlGh3uv6OTKmed5rB1FMKLrKp+dXVdvhRdphYSsU92msE 0BlqjAmYnbhW3R4++O98uBC+FeTtcVm5LwWdnKpt2qQsfVfj/EAvKCP0 X-Gm-Gg: AZuq6aL5ZZg5G+79dHgqG5tWDSiz0/hnVfGr2NmDr2UL2fCwH+g2b6DZQvVUCoqhAcv Hozxb+pkUJE6SZkxmiR0ciOzJSHnKGvIEXHuhxQu3zXX+vqaVOhhOuI7WeolQMeCHVOz7aLVQKo 3ASOcOZgjuDdJD6N4X3WpO81bLMsAjsFtwN68UsiwkDPOkpzMDcEgLVFojamKY3GIgcBb/mDuHU jhZQBCSqF9bpwrp981rnrCSkHT+PSf3kLVcRBfA+Hddu41v+8016xBMczBYTDEpTkrbzW2fQ+xX tqZUYx/wdRlgEEW8b9m78MoPGPYs7XHld4D+KfMrYqxqZ8iK3yiJe5swmVccKRJIKVmvsMcs/Vw Tg7Xw6Qx60LrfGEdrAueQf4p6uGD95/EM7UnO5hF4oxjP6Ex45GxBKgI38kon/DrKlkeLDAZLQu +XRmVkvg== X-Received: by 2002:a05:600c:8b27:b0:46e:32dd:1b1a with SMTP id 5b1f17b1804b1-48022668fd4mr258559955e9.7.1769033065384; Wed, 21 Jan 2026 14:04:25 -0800 (PST) Received: from archlinux ([143.58.192.3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356999824csm39410535f8f.39.2026.01.21.14.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 14:04:24 -0800 (PST) Date: Wed, 21 Jan 2026 22:04:23 +0000 From: Andre Carvalho To: Jakub Kicinski Cc: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Shuah Khan , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next v11 7/7] selftests: netconsole: validate target resume Message-ID: References: <20260118-netcons-retrigger-v11-0-4de36aebcf48@gmail.com> <20260118-netcons-retrigger-v11-7-4de36aebcf48@gmail.com> <20260120172057.6600eefe@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260120172057.6600eefe@kernel.org> Hi Jakub, On Tue, Jan 20, 2026 at 05:20:57PM -0800, Jakub Kicinski wrote: > On Sun, 18 Jan 2026 11:00:27 +0000 Andre Carvalho wrote: > > +++ b/tools/testing/selftests/drivers/net/netcons_resume.sh > > There's too many of them now and they keep failing on real HW. Since these tests are only using netdevsim I was a bit surprised about the failures on real HW runs. I'm suspecting a race on my workaround to trigger reactivation and these runs potentially running on a host with systemd with MACAddressPolicy=persistent as I'm able to produce a similar error on this conditions. Any chance these are running with different configuration then SW runs? When the device is recreated with the same MAC address as before, there is a race between my workaround and the resume. netconsole will immediately resume and UP the device, then my workaround goes and: ip link set dev "${SRCIF}" down ip link set dev "${SRCIF}" address "${SAVED_SRCMAC}" # Rename device in order to trigger target resume, as initial # when device was recreated it didn't have correct mac address. ip link set dev "${SRCIF}" name "${TARGET}" The problem is that the rename won't resume, as the target has already not deactivated and nothing will UP the device. Doing "ip link set dev "${TARGET}" up" at this point should address this gap. Alternative, we can skip restoring the mac addresses if they are the same. Does this make sense? Perhaps there are other conditions that can trigger this, but running it with MACAddressPolicy=persistent is a reliable way for me to reproduce it. > We'll keep this series in the queue but I think it's time to move > the netcons tests out to their own target or move them to netdevsim. Given the above, let me know if you prefer I send v12 with the proposed fixes or a separated follow up patch to fix the test on HW runs. Since you mentioned keeping on the queue I want to make sure a new version of this series won't mess up your process. > With absolutely no error message getting printed :| Yes, debugging these has been quite challenging. I'd like to improve all netconsole selftests debuggability in a future series, looking to work on this as soon as I wrap this one up. > > TAP version 13 > 1..1 > # overriding timeout to 360 > # selftests: drivers/net: netcons_resume.sh > # Running with bind mode: ifname > # ifname : Test passed > # Running with bind mode: mac > not ok 1 selftests: drivers/net: netcons_resume.sh # exit=1 > > https://netdev-3.bots.linux.dev/vmksft-drv-hw-dbg/results/482560/4-netcons-resume-sh/stdout -- Andre Carvalho