From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078AD335555 for ; Thu, 22 Jan 2026 06:05:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769061962; cv=none; b=gt0wlilhnygJs7kxsyjjm2PXi3bDxTO0WNsH/i66Yul8mSlqpMtV4ZLXr9HAMM9DsKaqq0qXZBLdJjwX5/5dFeqWg8Mu4l8kFFBM2P1en4/jc1++b/Yrli0ZwpMWw/DgFHc0kZIj52C01VjR5elzCysBees7+Pti0YSCJmi/E6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769061962; c=relaxed/simple; bh=xOEbz33bUt9FQPy96H0PFGJJ4MHPtNrRYqYVcOnX5XI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QFY7Ffy/Mg0ymTtpBVhPrpLnNjlx+mbS3KVPTErywW91jerRQoy1Q8IklfdfN7vZ2MR11V1bzWPqOdK3jm2la+KSqIgi+wbL1qdu2J7pC3mPf8n8E/sbfUVk7MDA0QFFauQdjZwyE1tPLvKMOv316b1toJqvBnAn7EvBHN3bt6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=L6zRyiE/; arc=none smtp.client-ip=209.85.221.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L6zRyiE/" Received: by mail-wr1-f65.google.com with SMTP id ffacd0b85a97d-432d2c96215so459736f8f.3 for ; Wed, 21 Jan 2026 22:05:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769061958; x=1769666758; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dKKYv/QwjgamZm0Z+gBpDqIRHu4ljUK+NYA0+iwZjfs=; b=L6zRyiE/dTOjfNvZKhIrJ8IdkTIVOiYlrlKyoQf2lT+Zc48zCOCT4rNyer/PMFlZA7 283xT7/eZqUecI3IDRtl9OI7QdCqkd4B5+zS82JG+iwcmfZ+Ly1twwFk2NzAPV0xZf9s cHavPtHsK/C386H8b/Mg4lP5CIoLxwt+aJIW93dHvbvBe71iJytQKOOrYL1Fa3pyrw3P jY9a5AVMoT065BKjHdHDgZ7EBhJSfyuuY4/G2oGB6T4hSh+WJH+x8NRjuLzRGcu8QmZk 9phidGmdVC2gbBtXgrTSeG1GJUrwLglYG7FHux3We+vd/QoaC/WzwGUOorgUbrQN7Q+M yL/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769061958; x=1769666758; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dKKYv/QwjgamZm0Z+gBpDqIRHu4ljUK+NYA0+iwZjfs=; b=PKYCim8qOnS969OMc3ZrE9MDmBaHyTHyQ0+tL8NaZ6feR9bb4V3W312oeb6menuxyC D189CeP67BGyYPgjK495Jie9hm9Sm2eN8IIOT6+Ij8UXt6LAmfeyJlDj7KWKi7/rCXpB xVzONIsaYA7MDJMclt2eRzjgOZzBpVbkqIE+PxF9BttRALRuoVljDc6TXus8QssKDnhe xFrfkUkLbtO5oMinnmOjmLUCRnn+aI5aiPx+PYfQRQRFJ/u0XVNxn+BykS1DRV3h2RcM IIssHo3jyIma9bDM5J9u+ODaN2HOvdLUbbjMV8sTx+lsgFKOGxTfqDCHrP4prTPnJFmx tbsw== X-Forwarded-Encrypted: i=1; AJvYcCV3/WWWvn4uhisyXDdevh+MuX9HqcIP2HsmNf5vRMBYMCTegxBYOuW816iVA+GEaK0QJZ1OwVlzAGh+RJA=@vger.kernel.org X-Gm-Message-State: AOJu0YxPaW0MNL8SRGzfTgnztoGeceGKxuccgBQE6VEtDCVkfyKMKIZE ngNSO8wM2clFC1Suhu1kEy8ia4hY88C9I7m7nCgeGntplxAw1oGjiV6ewWO9MmUTA8c= X-Gm-Gg: AZuq6aJKrI5xzHmfJar2cccHMpVpjFalAbosxjce2SVWu1f8/EYH3968OLK27wfQrSw fbid3QM3DB3+v5X3s4HbbSyvIlnbqRnYP43lzF/kVoiRsWk6VZp7MYcgCZ2AyhHT9ACyd0ORSJQ r4jBrr/c7UNwZGQj+m02DAHQyxsrgfPgtTCCow/NjStbX4K7G8wtvKRnmWXOdEO+M7zv8grNB7f tC4gfzWYQDM0ImNl/jmWY7ol7Wq5wj4NdwGft1xhcx4BLE+n7kBmirfE3CAIS93uqcOLYZocvNB 5Pkjj+oOWJeP4q/47qkH8lUW3+qwCGnun8r+W72KKfHhohzo5DRNZHlS1/5df7g788gD+0hIA5G oS2ISAew9FczGGpAg72ThfS9ZNM9+RCkExAUDN6dB/tKiU+RDVHDbmUSVunkB+FsTM6qSAmPV2C 8kolCqyu+wKqdT2k9a X-Received: by 2002:a05:6000:290d:b0:435:ad52:31d4 with SMTP id ffacd0b85a97d-435ad5234ccmr515333f8f.26.1769061958037; Wed, 21 Jan 2026 22:05:58 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356997ed8bsm42957976f8f.36.2026.01.21.22.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 22:05:57 -0800 (PST) Date: Thu, 22 Jan 2026 09:05:54 +0300 From: Dan Carpenter To: Andy Yan Cc: Andy Yan , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc_sdp() Message-ID: References: <5f9e8942.7fec.1990997b4de.Coremail.andyshrk@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Ping again? regards, dan carpenter On Tue, Oct 14, 2025 at 11:13:15AM +0300, Dan Carpenter wrote: > On Tue, Sep 02, 2025 at 04:42:41PM +0800, Andy Yan wrote: > > > > Hello Dan, > > > > At 2025-09-02 14:33:44, "Dan Carpenter" wrote: > > >This dw_dp_video_need_vsc_sdp() function is type bool so returning > > >-EINVAL means returning true. Return false instead. > > > > > >Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library") > > >Signed-off-by: Dan Carpenter > > > > > > Reviewed-by: Andy Yan > > > > Ping? > > regards, > dan carpenter > > > > > >--- > > > drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > >diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c > > >index 9bbfe8da3de0..33be4eae2b20 100644 > > >--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c > > >+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c > > >@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp) > > > > > > state = dw_dp_get_bridge_state(dp); > > > if (!state) > > >- return -EINVAL; > > >+ return false; > > > > > > if (!link->vsc_sdp_supported) > > > return false; > > >-- > > >2.47.2