From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7684B43DA35 for ; Thu, 22 Jan 2026 05:35:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769060117; cv=none; b=YHnPK03KLUg4B7VQ3ui4HncoOb7InKLEBdH8/VSyykNRgXehgYD7fR7Mwzq2xsbq/CVKji7CJX/vVj03L685oTy6U7kvffTEiurG7hqqXc9by8AZrsjDkX7ag2hblCkpRaZd2PBDhms9nu3NmjM60rFRNREFJKNENgUsgu+Rbs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769060117; c=relaxed/simple; bh=QLC0cefX9RbqfzbWgR+dlU9xiaUFt69geoQDWLAvrCo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BtXX1YQoM+F90I7zrpVIYOFtuCQbJezIIzCpTkLkKxG9X1DMHaFwyOtGmUxWRt0zNbUd83Hbpat9+YTICx+y9tHgfKPbo268Qr26K11kxmpzFnMTVtqRWLCAqA78c1Cph/llzEwqtTx5D/DYxTiZTQqoOx96efSVU7QBvOgYHeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bLqDvEoq; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bLqDvEoq" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4801d7c72a5so4049765e9.0 for ; Wed, 21 Jan 2026 21:35:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769060114; x=1769664914; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pGDKCZ3+vAXOARnphfTvf//nYofjqcqGd3IChsKVzcc=; b=bLqDvEoqEkInHgrDQzHZVZ55ODJMd6FmIyxhLZQCgWVZba4lQ7Q8whNHIRhnyKG9iM gB/l8ApFFJQrTvxRivRRanPLuFzIlD2HUO98qHHMQJ2C1wNzVgPKKWGLLaLSDqlocaEg THQbvWWOxsNLbo5yqLY2V50h1hoVoDSS7bbzQ/guz8vvtIwAExYoBt5e+ANvzZ5PrSK2 yqHTtk1RDXfsTB3MQnyWVgTBZV7vQAN9CTRCkAcYep7V6As/RE6YFsUafzieY4l8y7ZI hi9BbhUIwdcdGIcW8csQ/ZTP+QHAd97/FbGcd9tVmsZCEIv2kKEP0WyEDV37DlYT/tzl bTYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769060114; x=1769664914; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pGDKCZ3+vAXOARnphfTvf//nYofjqcqGd3IChsKVzcc=; b=q/mCZrAAszm9z9jkOLEjGzy2X45J1ZeEX9CXIrzxAF//ErZp++7PTigibhSyB4VMuf 53E1CUcdmUrZ7jfKHhcMQeo+meWbOwLpZLoJs6ocH8koThuUL72AQV4eCP0aDogFZDz8 KphuwI66jHWqf4HRhh89yJq2JawDdhwKs3/rl1o9KC0kKATlDJ6rPC4o4OXsvemmmfvL FXx2c0EYEfPGrBMw298/FisYhzeyKuwU8732OA4a3OxN84s2CAOza7ooLMDiQ2fQMQRK FbNspiEfHSJ6C9OCQxDkLInMl0gedE2Wx+Zx14PrSsL8bO+RwEGWZrKLaV0gS/MwYkB8 R1nw== X-Forwarded-Encrypted: i=1; AJvYcCVEvuOh7sclXdiPrCI/VNPIpNmhwmksCd+C3R8XNS6RdqGOgq7FZjkISKCQ7TFyiMEEdR41UoY6AV2xP40=@vger.kernel.org X-Gm-Message-State: AOJu0YwYISPBMrKwbdsyLThnV9Y+z8nqFBrAZx2WWMMiBtM2C7fuIXZg MZTu5nq+FZG+A8SDSl7j24K+oWrG+k2PtJY7P5AukmDLSksAPehhEEshbtEZxKx/uT4= X-Gm-Gg: AZuq6aIxJPZAlVgWBcxg8pRUFEZ2Lbu/H95+m6cDOA46eC6os8EnSrw6/x7z9gB75WY 0dSs7iYGWppImtUCUu6gLRvBFO98z5V6Ie7MMEbErvp4f2R9sHLNlZVTRpo33CJjfrDpn16FgzJ QuNZc+W739Je8kQkQM1Hj/MUR0k/66yI4PyyubLDX5CM27LinXcRCEoIuggGtxT6ef+RSETxZbz s+uwhZkoDU/8J8ZGnmSbC5pFY0mNzGsDCVmY1ry+wp8/hGut+rlIjklaNf/Dv9nb6iu6L0Ns2/n e6vP40GMfXK9pHUrZHnJWtthiv/Dldt5vCuJG6JL3/kFJAR7QaQOVXqu6Jyd5YA259R43nad4pX sH/Ak3Ny6E6R4BbPnyBP5MSl67FJdKOaC7NmFBFjw6v2O/u3GRNtxzzk6Dgu0BpVe9p04sl+jJT KyVtJlT9VDzVIgQ5+q X-Received: by 2002:a05:600c:6206:b0:477:8b77:155f with SMTP id 5b1f17b1804b1-4801eab5255mr310638445e9.8.1769060113455; Wed, 21 Jan 2026 21:35:13 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-480470403d3sm40235045e9.5.2026.01.21.21.35.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 21:35:12 -0800 (PST) Date: Thu, 22 Jan 2026 08:35:09 +0300 From: Dan Carpenter To: Minu Jin Cc: gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com, abrahamadekunle50@gmail.com, zxcv2569763104@gmail.com, milospuric856@gmail.com, karanja99erick@gmail.com, weibu@redadmin.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/3] staging: rtl8723bs: change return type of _rtw_pktfile_read to int Message-ID: References: <20260122041450.2325560-1-s9430939@naver.com> <20260122041450.2325560-2-s9430939@naver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260122041450.2325560-2-s9430939@naver.com> On Thu, Jan 22, 2026 at 01:14:48PM +0900, Minu Jin wrote: > The current return type of _rtw_pktfile_read() is uint, > which makes it impossible to propagate negative error codes > from internal calls (skb_copy_bits()). > > In preparation for returning proper error codes > (eg, skb_copy_bits return -EFAULT when error occurs) > when data is insufficient or copying fails, change the function's > return type to int. > > Additionally, update the type of the 'rlen' parameter, 'len' variable > from 'uint' to 'unsigned int' to comply with the kernel coding style > as suggested by Andy Shevchenko. > > Signed-off-by: Minu Jin > --- > drivers/staging/rtl8723bs/include/xmit_osdep.h | 2 +- > drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 14 +++++++++----- > 2 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/xmit_osdep.h b/drivers/staging/rtl8723bs/include/xmit_osdep.h > index 8704dced593a..880344bffe2f 100644 > --- a/drivers/staging/rtl8723bs/include/xmit_osdep.h > +++ b/drivers/staging/rtl8723bs/include/xmit_osdep.h > @@ -35,7 +35,7 @@ void rtw_os_xmit_resource_free(struct adapter *padapter, struct xmit_buf *pxmitb > > extern uint rtw_remainder_len(struct pkt_file *pfile); > extern void _rtw_open_pktfile(struct sk_buff *pkt, struct pkt_file *pfile); > -extern uint _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint rlen); > +int _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, unsigned int rlen); > extern signed int rtw_endofpktfile(struct pkt_file *pfile); > > extern void rtw_os_pkt_complete(struct adapter *padapter, struct sk_buff *pkt); > diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c > index 944b9c724b32..ea54a573e025 100644 > --- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c > +++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c > @@ -21,15 +21,19 @@ void _rtw_open_pktfile(struct sk_buff *pktptr, struct pkt_file *pfile) > pfile->cur_buffer = pfile->buf_start; > } > > -uint _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint rlen) > +int _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, unsigned int rlen) > { > - uint len = 0; > + unsigned int len; > + int ret; > > len = rtw_remainder_len(pfile); > - len = (rlen > len) ? len : rlen; > + len = (rlen > len) ? len : rlen; How did you generate this diff? The before and after lines are exactly the same. > > - if (rmem) > - skb_copy_bits(pfile->pkt, pfile->buf_len - pfile->pkt_len, rmem, len); > + if (rmem) { > + ret = skb_copy_bits(pfile->pkt, pfile->buf_len - pfile->pkt_len, rmem, len); > + if (ret < 0) > + return ret; No, you can't do this or it will cause a bug in rtw_xmitframe_coalesce(). So that also means don't change the return type from uint to int in this patch either. Normally, we would do the bugfix first and then the cleanup in the follow on patches. That way we could backport the fix and leave the cleanup. It doesn't matter in a practical sense in this code but that's the better way. regards, dan carpenter > + } > > pfile->cur_addr += len; > pfile->pkt_len -= len; > -- > 2.43.0