From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4608F34E745 for ; Thu, 22 Jan 2026 06:20:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769062818; cv=none; b=unpjxiZDRa8jU50kof+b9YjUpMiikMWiejcRxal3AG/doEkO0oUbc0voWJn31/KbH9oOuqgQHGAJX41XVadORzgIaHi5bsJAx+jQ+ys/r8YEG9Xb4k1eIeWXob6+JqBOsOiP+tJ3cxRtnKvOJo3E2uM/7+Dvz+lIJkYBdRXpn1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769062818; c=relaxed/simple; bh=OzXuQ4xbN7FDjWTjEfE80G+1ONvRaNcTZOStSmt5pH8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g/nGW4fWEULCVxCnU03BT3XQgBJnTw1cxEuL3FMP20XqrQHqCFpdtqpShMUSn0QIa61klqhOfpCZVVte3BD0SlrAV32tzOPB3LOxdUKjwITkUhYUzMJ9mCaC6/UpEvNe7BhuGX5i8m6yFSln/iaRMD8wNKHzbwtOd3lG5P1ax4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pry6OiXW; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pry6OiXW" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47eddddcdcfso3033675e9.1 for ; Wed, 21 Jan 2026 22:20:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769062815; x=1769667615; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lOTy2622GXa3UDPHBgR4VCjibhjN7Qyx2Oj8387gVe4=; b=pry6OiXWlDqDAoyw/VW7oAJPqHO+5kUCZnbanktpdLrekmhrfKx5zqpXy06Yx2UOv3 /2KP2NnFooHNMzJpvtTfqw9N0EKeUk3/TBei4BE0LFaUpZ6RDGtlUeSZFoL0fdRs/TrX yZIy3qnNYeDhioH26a6tk2O9KiPAtyqdyqRVgLo2iIU/xaB74ycI2FPTo9nzOJSew1KB EUudue1VDsj6jjPdHT/pOGGOZCm3QoOPw+9TugGPbDzYPohL+GQGsM2WOmu30TeGKxc9 SzZsMufXsTFHvZBKAPljyjxgyE1rmSzx48g3uy3P+tfNZM8hYHC4F9J8jm/wIS0eefjo D+lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769062815; x=1769667615; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lOTy2622GXa3UDPHBgR4VCjibhjN7Qyx2Oj8387gVe4=; b=FaeJPlsgkGmn9fmDYa582xmq3QwoNyxChuiBqHDoUhtgVmWRPbOl3V63hPJHmu2q/X cAabcF3ib2S9+8nQliGO1iyCCw6i5Ac/oMzPSmSJeLVBXUc7Sm4gA4YAYm7uQdtJL8b8 yNc/gxA0BycrG15BXlNrOTbUgNwqRSuozSDNjI5ja2BALiXI0uLS/0IKuKGJ3zh0WE3j Nm5+WRA3vwwUCOAeDdCoTj83idHKEybGYI/gHHH+C8gbU0hPiuU844X3176a9sBXlXcO pTA9k1tbKZogq6LEP2whL5geVwxH+NJSsxk+Nm1Sf+4yzcGO/kPVcF53pysiz06GjFjJ AoSw== X-Forwarded-Encrypted: i=1; AJvYcCXjPtfkINQ7IjNH9AJu3AQgIA83n8Tl6E7k9+u3SExoM/Mu9Of8ErFTBwVo9gL411qQRFCSP9DXQBC6O8U=@vger.kernel.org X-Gm-Message-State: AOJu0YxByEO1UVjFiB1+IVXmrBCrkZDL5dzszYG7zsT2yOXUfqLYnkX+ Z5DjoxJVFfNRkmZTaNj6/34TmrtdOTn6+DNB1YW7QAyUDPjgMwS01GajN0cEMGa8QDI= X-Gm-Gg: AZuq6aLI6peatgd1Ea5H0Z1rojlmmV4+FiHmEWO9PxKN3Kpvxyvqd/tUjeQYIhPg00d +9uky9bgi3Oq+3VtNuxgvt7ZMVglmzj7RPxWqskVLwCNLZ6Bbp3ItSh1t3FEfqVUnBAKgEJHmul wQeQYSDWkMsaec2a4G8ORrQaKpXIfzexrTRaBkEjb/axHzpnNfZB0U1l8wUJ3iy3TmAI1VRs9gv J66gamF6xs9WNQQzi9GuvJ9ukrE23IKfstEPyHSnnl9KMsidA202wdUG5k6fIf+EJvPz8hyUKQv hbWbGwVYoZl8bNZkJjnerMfjTbpxtsRNAsP3Hr6suo9i+9/1rQbl4n7rND7WTsEdBg9/Fcrn4M/ wcmxouOaXXNZ3pypATumywOUheOrqYUM1S2LTnWKonZhmEl2a2GTFjAa2cbqs1kmdCHiBdNbD7l z0ghwavrsvp581dazn X-Received: by 2002:a05:600c:8b82:b0:480:1b65:b744 with SMTP id 5b1f17b1804b1-4801eb0e10emr271572955e9.28.1769062814484; Wed, 21 Jan 2026 22:20:14 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43569926ffcsm40813054f8f.18.2026.01.21.22.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 22:20:14 -0800 (PST) Date: Thu, 22 Jan 2026 09:20:11 +0300 From: Dan Carpenter To: Minu Jin Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: use kzalloc directly in _rtw_zmalloc Message-ID: References: <20260120054036.3783680-1-s9430939@naver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260120054036.3783680-1-s9430939@naver.com> On Tue, Jan 20, 2026 at 02:40:36PM +0900, Minu Jin wrote: > Replace kmalloc + memset with kzalloc for simpler and cleaner code. > > Signed-off-by: Minu Jin > --- > drivers/staging/rtl8723bs/os_dep/osdep_service.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c > index a00f9f0c85c5..be46132a533a 100644 > --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c > +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c > @@ -24,12 +24,7 @@ void *_rtw_malloc(u32 sz) > > void *_rtw_zmalloc(u32 sz) > { > - void *pbuf = _rtw_malloc(sz); > - > - if (pbuf) > - memset(pbuf, 0, sz); > - > - return pbuf; > + return kzalloc(sz, in_interrupt() ? GFP_ATOMIC : GFP_KERNEL); This in_interrupt() is garbage. We should use GFP_ATOMIC if we are in an interrupt handler or if holding a spinlock. The right thing to do is review all the callers and figure out whether GFP_ATOMIC or GFP_KERNEL is appropriate. regards, dan carpenter