From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC98C29DB64 for ; Thu, 22 Jan 2026 11:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769081584; cv=none; b=IdN/asgVTUOgJlfrdt0tUve1w8C8vmk9tLm4zWD/iDiXSrcsRHg7tzaSUfDP3tG/dqsffypRIzAvHQdm0U0EIu1jCOkGg53kG2m8J6Ekkz7QJhimgCarQbKgFrx4IK0sAe9BwidWzpzkKu1QtLI9O+lyHPRXzNXq4R+1YJXA+Uc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769081584; c=relaxed/simple; bh=MT9pFV75h0kEmZC8bIWLFiHCACTEbTBp++ksnQFyvoc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CmcRytde8jJ6ve6JCziPQPGPe77COYIK1eGUlQbupnMRB+EpBLq1SENrx9W3ZZLDEY5u4S8RMIQNrmOesowTOgY6EU3VTh5hQ9wTzK41qW5Nw7jQCBzuRBh5hrsSpDTrOxtCA7Ona3UawUzM3Qe0LZAOdt+X58J9SlraBZIRqLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=elXN6kAD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="elXN6kAD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A708C116C6; Thu, 22 Jan 2026 11:32:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769081583; bh=MT9pFV75h0kEmZC8bIWLFiHCACTEbTBp++ksnQFyvoc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=elXN6kADHsYbxw7riLecWjrnoHwzXUqXB0BHU6NtMjlC/TRgi6c5iq18AS+JGg/7p GAXSrk2TGJSdoSvtU/gnNY/0xbNnLM5BMYJgV5zjWtjbyduX0kIqp/LLhoJAkJGnPl Zg/hVqzht+qvSNzrRLGcZiqeV54nQufdxn6K6aDfoUbnIXvxgoliiNkdorrVJCMxqh ry7uB9fFUBOZwkCmUPd+ZtAWEeUeYJl5k82Y1W5+fYIepLhv4nd8M1L/GdBmKnRQvL eygIHwdBhAoexps7q5rHryWJLO8rQDDya4lPdFcaLVpXNUaYRdGAV+FRWmjACK+Ltj 5uu74gQGbTJRQ== Date: Thu, 22 Jan 2026 13:32:55 +0200 From: Mike Rapoport To: Tianyou Li Cc: David Hildenbrand , Oscar Salvador , Wei Yang , Michal Hocko , linux-mm@kvack.org, Yong Hu , Nanhai Zou , Yuan Liu , Tim Chen , Qiuxu Zhuo , Yu C Chen , Pan Deng , Chen Zhang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 2/3] mm/memory hotplug/unplug: Add online_memory_block_pages() and offline_memory_block_pages() Message-ID: References: <20260120143346.1427837-1-tianyou.li@intel.com> <20260120143346.1427837-3-tianyou.li@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260120143346.1427837-3-tianyou.li@intel.com> Hi, On Tue, Jan 20, 2026 at 10:33:45PM +0800, Tianyou Li wrote: > Encapsulate the mhp_init_memmap_on_memory() and online_pages() into > online_memory_block_pages(). Thus we can further optimize the > set_zone_contiguous() to check the whole memory block range, instead > of check the zone contiguous in separate range. > > Correspondingly, encapsulate the mhp_deinit_memmap_on_memory() and > offline_pages() into offline_memory_block_pages(). > > Tested-by: Yuan Liu > Reviewed-by: Yuan Liu > Signed-off-by: Tianyou Li > --- > drivers/base/memory.c | 53 ++++++--------------------- > include/linux/memory_hotplug.h | 18 +++++----- > mm/memory_hotplug.c | 65 +++++++++++++++++++++++++++++++--- > 3 files changed, 80 insertions(+), 56 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index 751f248ca4a8..ea4d6fbf34fd 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -246,31 +246,12 @@ static int memory_block_online(struct memory_block *mem) > nr_vmemmap_pages = mem->altmap->free; > > mem_hotplug_begin(); > - if (nr_vmemmap_pages) { > - ret = mhp_init_memmap_on_memory(start_pfn, nr_vmemmap_pages, zone); > - if (ret) > - goto out; > - } > - > - ret = online_pages(start_pfn + nr_vmemmap_pages, > - nr_pages - nr_vmemmap_pages, zone, mem->group); > - if (ret) { > - if (nr_vmemmap_pages) > - mhp_deinit_memmap_on_memory(start_pfn, nr_vmemmap_pages); > - goto out; > - } > - > - /* > - * Account once onlining succeeded. If the zone was unpopulated, it is > - * now already properly populated. > - */ > - if (nr_vmemmap_pages) > - adjust_present_page_count(pfn_to_page(start_pfn), mem->group, > - nr_vmemmap_pages); > - > - mem->zone = zone; > -out: > + ret = online_memory_block_pages(start_pfn, nr_pages, nr_vmemmap_pages, > + zone, mem->group); > + if (!ret) > + mem->zone = zone; I think we can move most of memory_block_online() to the new function and pass struct memory_block to it. I'd suggest int mhp_block_online(struct memory_block *block) and int mhp_block_offline(struct memory_block *block) Other than that LGTM. > mem_hotplug_done(); > + > return ret; > } > -- Sincerely yours, Mike.