From: Andi Shyti <andi.shyti@kernel.org>
To: "Benoît Monin" <benoit.monin@bootlin.com>
Cc: "Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Jan Dabros" <jsd@semihalf.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Clark Williams" <clrkwllms@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Dmitry Guzman" <dmitry.guzman@mobileye.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH v5 1/6] i2c: designware: Optimize flag reading in i2c_dw_read()
Date: Thu, 22 Jan 2026 14:29:48 +0100 [thread overview]
Message-ID: <aXImLrvsLBExAX4f@zenone.zhora.eu> (raw)
In-Reply-To: <20260120-i2c-dw-v5-1-0e34d6d9455c@bootlin.com>
Hi Benoit,
On Tue, Jan 20, 2026 at 10:28:01AM +0100, Benoît Monin wrote:
> Optimize the i2c_dw_read() function by reading the message flags only
> once per message, rather than for every byte.
>
> The message flags are accessed both in the outer loop and the inner loop,
> so move the declaration of the local flags variable to the outer loop.
>
> The message index is only modified by the outer loop, so reading the
> flags in the inner loop was always getting the same value.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
This patch has already been applied. If you are going to respin,
please take it off.
Andi
next prev parent reply other threads:[~2026-01-22 13:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 9:28 [PATCH v5 0/6] i2c: designware: Improve support of multi-messages transfer Benoît Monin
2026-01-20 9:28 ` [PATCH v5 1/6] i2c: designware: Optimize flag reading in i2c_dw_read() Benoît Monin
2026-01-22 13:29 ` Andi Shyti [this message]
2026-01-20 9:28 ` [PATCH v5 2/6] i2c: designware: Sort compatible strings in alphabetical order Benoît Monin
2026-01-22 13:30 ` Andi Shyti
2026-01-20 9:28 ` [PATCH v5 3/6] i2c: designware: Add dedicated algorithm for AMD NAVI Benoît Monin
2026-01-20 9:39 ` Andy Shevchenko
2026-01-22 13:31 ` Andi Shyti
2026-01-20 9:28 ` [PATCH v5 4/6] i2c: designware: Implement I2C_M_STOP support Benoît Monin
2026-01-22 16:25 ` Andy Shevchenko
2026-01-23 14:25 ` Benoît Monin
2026-01-23 14:37 ` Andy Shevchenko
2026-01-20 9:28 ` [PATCH v5 5/6] i2c: designware: Use runtime PM macro for auto-cleanup Benoît Monin
2026-01-20 9:28 ` [PATCH v5 6/6] i2c: designware: Support of controller with IC_EMPTYFIFO_HOLD_MASTER disabled Benoît Monin
2026-01-23 7:03 ` Andy Shevchenko
2026-01-20 10:01 ` [PATCH v5 0/6] i2c: designware: Improve support of multi-messages transfer Mika Westerberg
2026-01-20 15:17 ` Benoît Monin
2026-01-22 13:33 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXImLrvsLBExAX4f@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benoit.monin@bootlin.com \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=dmitry.guzman@mobileye.com \
--cc=gregory.clement@bootlin.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mika.westerberg@linux.intel.com \
--cc=rostedt@goodmis.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox