From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4455D392B62 for ; Thu, 22 Jan 2026 15:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769095925; cv=none; b=L0kvoZxkwojbB71c6A2YlmG834XS8i0rtRa8+EwiYvkplizX5YZttz+F/2QwxPDPCLLwsvBoX+Z5DpvDQ21g1VMbysei2G3KwJ8RJlK+P8bq9SWY7Xc3zzOI1PHTlAP0SLCWizzrw3sBaU710QVBM8zAlKR6OMLDTtDN/2G7ppg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769095925; c=relaxed/simple; bh=3OkE4HhnJQtBO7tgZ4igiMABadrGvCo8beeOHA1xdQo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WKuAAPf0Oknc+11yWn/wubMFaO4Jsw7B5gd7rA7CIbgUIqvpdSBmnXcFcbrTn+paV6NEabXnZ6oQaS1MhMcToLza+5UCfsO9/sx5dpDnb8pSRTSsWNEz0hxAo5ArZnxpQldbB1GZmEFOn+x8auWzsxFKut37bydunCxO85cOnZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=G8bzTOXr; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G8bzTOXr" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-42fb6ce71c7so1015888f8f.1 for ; Thu, 22 Jan 2026 07:31:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769095917; x=1769700717; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=4bkWjHpOvcH5gz/C25tqPbs4mKVsSfHP43ZInYU7sBc=; b=G8bzTOXrV1IMU2dmdMf1SFwfoRSecRY+9zrXvSz4UUb+Ewyx5xIuPdxbZnrrGj2goM qOIqtBRhknGzVAdsUvi/Eaq68Ra95+FMA3GBnW+fAsf47IFaUHo4IAAAR/zDydfDkk+i CSjQwNDBeEqjHtqVGyhv3/BVXeDD/Pgo/0MCvfO18XAuIgc5ADh69DHpZPauDb/HisBv E23nAUsitkbI9ravXtZq2z4MtjvbuV732TbUhXnCJGy7Lo6NdvmtdFNWAJPVcpTacXlS EfrJU5lcOlvmoK0eFR4fliM4SG47vm9Ba6Q2yg8inSVMhNtVMJ/RDcrr8nCOK6MTsauV EP0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769095917; x=1769700717; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4bkWjHpOvcH5gz/C25tqPbs4mKVsSfHP43ZInYU7sBc=; b=cT7g0lsIwAqbBwkev1n+kovFbZJcjtMshADzcE4rrDBkkcyZEEl3gy2BqS10a2rhty +dhmfbRJVwg5UvTzVQPKYuozzB7nsmfXBB5lHOHQg7JL5APg3K4bY2zUt40dqANUhaUA Ht8q2HJ5EMM6/FxPtE2MjAeFL9AABVrEMol+EFOJNCe9Bo8V6c7ZNhdiFztPYg1idLyr y1nYKBIV3yT1R2RfXGvT99y7NAn0H9vqmTl62xIu2ckug83l9HriolKoQjq3Kf7538cD CW3EszAYlwL7lj3jAuPGTTTmidOjxDprsrbGpSPXDxT8C7pEQKHMLSRtW7G2MlaSLGet s3JA== X-Forwarded-Encrypted: i=1; AJvYcCVJHfdDUNKSb3B5/wW5m6R2CSV2hNltKX9As0wM3k/VedG10944D+JJINaQ0Xi59qtrD9fEZUjW15eOdPo=@vger.kernel.org X-Gm-Message-State: AOJu0YxygxcJOYOO89tCAXVBoEo0dGupnUhmydrC9cgihiN3KfBfA4DT gNq1bkiwyRTGqt0Vwbk9dvVQw1DB2QV3sxRMhNkSQPUxkVpMZj/yFnN7qJVHSXWuGbg= X-Gm-Gg: AZuq6aL2iRhiDZ2+NplUMX0qVb5qb4tLRnmydBWCvk0rDjl0dhLWOdBkfqO2FmT9SmU KyA1njuhwBlALyJ6BOImfCvlzLo4BsPHAgxVU6O4kOeAjAYo33Tt9YFNE8jROdpbF7Nd3MdFbiB QBR6cFxN6cR14vu5gLpeptEfIEcb24rBwqOE+laJLCuoKGp7NomzhYS92aytYpSI5P35doNK4rC NHVUYfQtExnuO6YAutlV6VhQsPs6R3mXnUArLaB+QhGJ5E3aXapLA1XVbg6ctlikvp4v0mLg82v oOBOdc85+OxnxELYz8gGl9SRfshaMGTlo4iM1L9H4xqbxB86CrnkxCHt/HZgHkvukloCJVRmj2c pDtmNuaGZJceZ5q9iKN0KWV7C8VzeBbzlakJYO1d0cYeVrjBJUnOayXxajwZtByhcv3XyiEMwx7 m79JlMfIEUopBbGwuQ X-Received: by 2002:a05:6000:4382:b0:435:abbb:fa77 with SMTP id ffacd0b85a97d-435abbbfb7emr3910335f8f.20.1769095917136; Thu, 22 Jan 2026 07:31:57 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356999824csm44923679f8f.39.2026.01.22.07.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 07:31:56 -0800 (PST) Date: Thu, 22 Jan 2026 18:31:53 +0300 From: Dan Carpenter To: Minu Jin Cc: gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com, abrahamadekunle50@gmail.com, zxcv2569763104@gmail.com, milospuric856@gmail.com, karanja99erick@gmail.com, weibu@redadmin.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/3] staging: rtl8723bs: change return type of _rtw_pktfile_read to int Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Jan 22, 2026 at 10:23:11PM +0900, Minu Jin wrote: > Hi Dan, > > Thanks for the feedback. > I'll drop the type-change patch and reorganize the series > into two patches for v6 as you suggested. > > Regarding the return type, > I’ve audited the call sites including set_qos(), update_attrib(), > and rtw_xmitframe_coalesce(), along with their callers rtw_xmit() and xmit_frames(). The issue is the ordering of the patches. You introduced a negative return and then fixed up the callers later. There was only one file which used the return but it treated the negative error code like a byte count. You can't break stuff and then fix it later in the series because it break git bisect. regards, dan carpenter