From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 453CA262FC1 for ; Fri, 23 Jan 2026 08:57:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769158632; cv=none; b=u19xSJtJMB9qDlaeQuZdIrLEF5ZJlUmgagrmDjNPOypVB+9xJaWiYQHNdcLdSZpdYsRmj205OaqYx0Ge7SoSPqTBUgcMunXH11K53Qi2/XAEnCCjlYRwSfKVohmh6BoRESVarqGujZEb8WTOrBiUns79C04IpoprWBZeYx/GlWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769158632; c=relaxed/simple; bh=in2+HbXL6vJZGvl/5y1AduWFMILMPmL+sKkvSbTV0hQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DHuLr3fGImnR8OT1rsw/OYK3w2D2SggaszMKdv9cnyWpKhEY5Tp4HnlV2U0PbSexzCP+3OINRUSgehwe1Cc+Cx2RjJr7wV/EVyw+BwPNclNPeVItmE6zgsNOU+nE3Rc5TevrQezW6tqvSwAFidbL+4IxqO8pc2cV7fOlL1yPrbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UdsnYts1; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UdsnYts1" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-432da746749so1047432f8f.0 for ; Fri, 23 Jan 2026 00:57:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769158630; x=1769763430; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OpGV0KMqhrPi7c5LKp7937Xrcab70gH+N2HXs8/3ITA=; b=UdsnYts1lIph03mlEJLpjmQ/HOKHNe9TG6wnTQfFuCMhfwSgp+yt94QgbFqj5tJQZo V8Tx/zyrlsJ3GeFRutCDOtpg8+lYixa+uC0r0XbzmJFfkElwRLAZo2L4OGlJcNn8kjdS gcJsGuuax4E7qJKAEsDccQrfznXwnfWvWGhvoS08rBalkhpd48nMJ67rRoKYtaC+mUSH F4pCM+8nhkV6otvfpbS45GM8uoCLq0fB7jTCxmYhiWFwv5o8TuyBYhqfSGZKrxJiBQyk GA+rNp0ndCs+FJB2rQ3nT3emKHFPSlub5VG44NugANkvhu6R+lViJeUjWc5X3DOpAjb3 8jvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769158630; x=1769763430; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OpGV0KMqhrPi7c5LKp7937Xrcab70gH+N2HXs8/3ITA=; b=cT49mQvLD4YfC6spRBwrSAHlh+CcuYgJ9HYm9+sVd+EyISvsyETxHZ9eq0lThsod2d FK8mPJ2MI+KO2Qq8EkXE08z7j36IW2bL/2j3g8kwGxdk1nKWDwFgQRs83vlgTqCxM3bs 0PJdJPkSUKqvAHUh3AK8zqDsH9FB6nFHtdWaT1DBmfk2EowQfRqIpdUBqPcUksh25p0N uoRUM4bzN0YH9jVvB4TWCsi4Dz7gtgU8sXzafj1Ccv01tJxUExy0vVgnyG9/QP4c+IdA f5GDavmiC5ymzsNZy1h1zrY4MXD8MTvDfKWvEBiNwjdi/MNNAvITAKKhxNPBUrZaCD5Y LkQw== X-Forwarded-Encrypted: i=1; AJvYcCX4BieVswlXTAbeJHLorXh6Jc2iTnq1I/7GBsPQIqQUf15g/G4rS0mb1iT9CSYUvmDK4KUl44O4aiFBfNE=@vger.kernel.org X-Gm-Message-State: AOJu0YzIU8nwxgC6eZ4bQFYyzcUPi80HEvMUh+mVlsMqBg6zD8u4Vg2r gN+4LWb9ps5y/fh0I/T37Rhy0lovP7BJIHbnCa/ZEugB0sYFHPNffTsI2C/eg9MgD1U= X-Gm-Gg: AZuq6aLk0HcmcOYachfI0cLiMhuTBEiwrut4BUC719m0mI6FSDR1bYl45o+Ds94TxBE 02zL12NJcrwDn9CdJ9DcKdlqnE1TmywoYDZ7wN7fLivqtLBcwMkDSt5eijl8MP+AaSQDALxA2aA VXYf9oj3iK+YXv1FuC698PHbaP6DmBiJBQXeyUnmK2y64lATwDp4Da7rVwmxjn37nvOQjvh1C/i jfGr4oA1lYm4px+p50llVzdF8Xg7TC7E4BT+Gf7mXOic5cL4caUC/RNdkD/QmH+mKNbO6peRVZM CIjDuwOfy4rjMcaqC3prMDQ7ciNmn8ztV+hy3YEynY2eBGslJ4Sz+os0CVU2ztdF/qM2h5SApP0 hXNM3SvkdZOPEnmbKkQvKT1hiG3E/arDKj1TWozBuTRxTOc1iz/IUyqsm1hEkS+yJEyfbS2rlOP Xw97GRjUu/CGsiIFGo X-Received: by 2002:a05:6000:26c2:b0:431:266:d13a with SMTP id ffacd0b85a97d-435b966a659mr869750f8f.48.1769158629521; Fri, 23 Jan 2026 00:57:09 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1e7156dsm4865119f8f.20.2026.01.23.00.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 00:57:09 -0800 (PST) Date: Fri, 23 Jan 2026 11:57:05 +0300 From: Dan Carpenter To: Michael Huang Cc: gregkh@linuxfoundation.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: fix coding style issues in rtw_mlme.c Message-ID: References: <20260123003205.33898-1-tehsiu.huang@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260123003205.33898-1-tehsiu.huang@gmail.com> On Thu, Jan 22, 2026 at 04:32:05PM -0800, Michael Huang wrote: > This patch fixes several checkpatch.pl issues: > 1. Remove redundant else after break/return. > 2. Remove unnecessary boolean comparisons (== true/false). > 3. Fix trailing whitespaces and overly deep indentation. > > Signed-off-by: Michael Huang Split this up into multiple patches. > @@ -1560,10 +1559,6 @@ void _rtw_join_timeout_handler(struct timer_list *t) > do_join_r = rtw_do_join(adapter); > if (do_join_r != _SUCCESS) > continue; > - > - break; > - } else { > - rtw_indicate_disconnect(adapter); > break; > } > } You accidentally deleted some important stuff here. regards, dan carpenter