From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D249318EC0 for ; Fri, 23 Jan 2026 09:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769158952; cv=none; b=ET0yJklcBCwz8GSyZm6K/BPU2Q3eWaXhy7XrqhSfxBsy+lj3ohH7DSmq4j7+1kfkdxNicOiZAd6paFED+vZKgs2bm2J/XZGWj257Rhwfl97sJ3pjH1h5i4W66eMIeSn1AqeHsVRT6tWXcs0RIFB2m4td62ENU94z5ojDCU3L3gg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769158952; c=relaxed/simple; bh=aWwB09OHfzjrEGJ1WjLbt4jhfPVsDmb2oqk3Uy4yxdM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a2MQJN/EbOZTk+PFO5TIItnlWwwsPoxH0woFlndPqka7cWCFI01Klfvs+/cWPx/AKAJ7jN6D59EU4SbMTeIFE89UUgHpwEtgrWQ2ZOje6talYm35oF8qa6o3anRugoFNhTSEO88xTNWmjxK54ObTD2u98no8nxFbytRQ4cA5t60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=d1Z6TQe5; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="d1Z6TQe5" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b8850aa5b56so215816066b.2 for ; Fri, 23 Jan 2026 01:02:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769158949; x=1769763749; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sbX16+sGtOKpaVoSIjx13QfQPgcDS419pJdlbx5EMvg=; b=d1Z6TQe5g3p55tSelnpsRk3P4p/CHpQJ9pHpLGU48/StYpbmwVLdLJm9FL4IDTqwbD DdrvgeOHaRhlYeLw5PysjNN4mfhWwi34YHogn7dE/87NVC71ljmJg6FCdG5xOg3lWtSO bKLmB3n62Da1tV7Wxew6AgaqeZDaBnC/kycZnz2un27Zulkl0zzei83NZzPmofQPIzmU a2xwqlF/+NgDH/A1A6+pJ/2O4l6lF8St6bU09OJ/dCoOA6Nk1CRHaTghKykLEdHW8xro A02JLDVJSMdxIV5hCs4CK6VnAAQCBOYsPYBAhIdUB3OJb11sF6GiiDxKAGK7oqVqZ1GQ NKxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769158949; x=1769763749; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sbX16+sGtOKpaVoSIjx13QfQPgcDS419pJdlbx5EMvg=; b=XpsA1TfVVFo5lwvQkhcnuRK+GN3Lz5XxWZgPMqGbhRsZN5wAIq1/GiNrenOhrdGdd2 lIy73YJBGkRu5GxNRycha0x7XS7mbY+l7kTJv4648PNFUeK+G1XCM2w9YmWz2Aq/4Ojg HJONdMq8GPo0TcpaypgHDmtKAQw0h/MAaCf0ecY+EWRXIqukIVbCQ3tPNpcjoDIJg3Ib ZwLrUc5IfLEreWhgf+Al0kP0/v9WVtFUMAHsVD8KSGZJtFXN+4P9U6aFepnUd06dGKFA g02zsga17s6mLtNGIGijoPkCUAp4+lRHBjA9jr4yiKzQTm4HMZX8Y7piGuQWCJ0JAuJ2 X02w== X-Forwarded-Encrypted: i=1; AJvYcCXTPijg88QNRgo3+3Oj3ZphXOVCVoChzlyFJEh9yResfBSPNFkj3sJcUzJR6oXJ/5qiM8MOrSVK7xI3yKc=@vger.kernel.org X-Gm-Message-State: AOJu0YzwCJBF12ruD04jMCza4j0ACS/1vwAOpKZ7DeJ9bHexkKWsnf+g 8c0wIQ/QMsu0b1uc6lO8GCMkiMCVX7vvMxRhzd3cDRZlEGBoLFMqFd8u8jNFBMrt0yM= X-Gm-Gg: AZuq6aLvj2/pGy2NWeNxppHoaWhO2PG9y0lKdorv4Slxv1HH/GjUavPgNGAaxVMlw2o rmdH92A8gh89STTtKCJdr6XvP2On1s6YxzcwNd2mpvvf5joHqejbEcZAQxkgEpU+Q5+0pxv+1sY 1sTSV/n4X0rlVDft3y6C9A5TCfu3JxBX1g/zvRVWiIrKoZse6OK4tQAsGsVjsRGBDmG09Uo674e n3N5uk4kl+DX9B7FBzSQUnKYK7KMxijWaQh8D+vkGsNN9fM7DqIFCpdUqTw4zNZc69Si84SojlG iRfvQTnBFNO6lHjDc1vNDbzXlD6wsFS8suD4cjv/z1QMETnLC+t5zDDlKbjFalir9Bt3fU8DSJy DOAnuDRjTTfjZk9Mjx0tem0bM8S7c/1JSsMreSDAtpUdavkg8BfNv2q2L88B6x8oWBvc3QnNwco qLseDUwfqtKW/eZWzLYb2QsBLq41E= X-Received: by 2002:a17:907:944e:b0:b87:1d71:f44d with SMTP id a640c23a62f3a-b885ac0fd3dmr137875866b.11.1769158948448; Fri, 23 Jan 2026 01:02:28 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1f73855sm4997958f8f.29.2026.01.23.01.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 01:02:28 -0800 (PST) Date: Fri, 23 Jan 2026 12:02:25 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] staging: most: dim2: replace macro with static inline function Message-ID: References: <20260123054708.11140-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260123054708.11140-1-ethantidmore06@gmail.com> On Thu, Jan 22, 2026 at 11:47:08PM -0600, Ethan Tidmore wrote: > Replace unsafe macro with static inline function to avoid side effects. > > Signed-off-by: Ethan Tidmore > --- > drivers/staging/most/dim2/dim2.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > index dad2abe6c0c9..a075a2df349e 100644 > --- a/drivers/staging/most/dim2/dim2.c > +++ b/drivers/staging/most/dim2/dim2.c > @@ -113,10 +113,12 @@ static inline struct dim2_hdm *iface_to_hdm(struct most_interface *iface) > return container_of(iface, struct dim2_hdm, most_iface); > } > > -/* Macro to identify a network status message */ > -#define PACKET_IS_NET_INFO(p) \ > - (((p)[1] == 0x18) && ((p)[2] == 0x05) && ((p)[3] == 0x0C) && \ > - ((p)[13] == 0x3C) && ((p)[14] == 0x00) && ((p)[15] == 0x0A)) > +/* Identify a network status message */ > +static inline bool packet_is_net_info(const u8 *p) These days we tend not to mark functions as inline since the compiler is smart enough to do it on it's own and it's mostly going to ignore our inlining suggestions anyway. If it really matters in benchmarking the use the __always_inline annotation. > +{ > + return p[1] == 0x18 && p[2] == 0x05 && p[3] == 0x0C && > + p[13] == 0x3C && p[14] == 0x00 && p[15] == 0x0A; This should be aligned slight differently. [tab][space x 7]p[13] == 0x3C && p[14] == 0x00 && p[15] == 0x0A; regards, dan carpenter