From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f73.google.com (mail-ej1-f73.google.com [209.85.218.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AC6A2F6596 for ; Fri, 23 Jan 2026 09:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769159885; cv=none; b=sGSfqN5lWp9XvaSEM/9ns0yzU/Xv4fltMzJwscStnmGKc0Oxxlbr6LxhVaDj9i7WYVaJmVPCs5cmtAuV1H7G+bzkODX6dWKsEghkd8EZitMM1OWshHJEq436rEP++np1LqU+BSW/Rv1X78Ie2ld+nSrG246YgGllwBcDeLyA5hs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769159885; c=relaxed/simple; bh=XVH95s01MqloQH1J7IdnagDFHxf/iHAeNk0s14uQMvc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=em0EStGM/bsO5Zrvn4VERxlOBrjgyV6QCH2J9RPM/l8tEyMjbiGm1fL4gqrBlQoCL6bM5oi48Jmd8UCiKNOpkIxOqJuMr9lXdmAUkZbH2YhO+2v19QnkNoQ9t0DPdqQf/7Wqn8WSYhg5VE49VVJX2ES6efDW/o/daU2/Rxdw9Qw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bBCmB3/P; arc=none smtp.client-ip=209.85.218.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bBCmB3/P" Received: by mail-ej1-f73.google.com with SMTP id a640c23a62f3a-b8773bf3ddbso155568166b.1 for ; Fri, 23 Jan 2026 01:18:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769159883; x=1769764683; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=9Ua9w7UEf7xgcdVIusVPQYkd37tPBqbwBjiHWdVEgXw=; b=bBCmB3/PRQlg21+v04SN+KgncglLaC+vjw0iW1XjTX2wiyYC7ZKtef++wsVS13Qm16 pkQ3sOccOGri6uSrxZCwPv4ixBuCgJkneFQNcRYQ6R+sq9mSBfwvPFUoQPghCbeMniUd nRXjZfAaXyY5MFSbLWGH7zH+jNcMOXuWMtmsE64kQt959v68fpADqkX91TntrhziA8yO 4h+TTIH2lUEkMzKPFeL0UKQLxXW8ooSoW634FqAEkNcKz72S1ZIZdJD5CydtYeQpDOSV Pk6mZ9CTmk+vYAmAzG0jlXmjGUykCdKVLpa6CRV3vEchTQeAC2tfFfwj2qKbZX8ZCrQc 9MQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769159883; x=1769764683; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9Ua9w7UEf7xgcdVIusVPQYkd37tPBqbwBjiHWdVEgXw=; b=ucvtF8OBGPzIRbHFd2XJOfZwc5RtKbIqHdRRsSrASdX9MoOxFJ5x35eO0zdP+vcAMm 6mR9n6yUlSz8HmRXjFUoyRYc+EnWZm4FSj3KNEnRBjwemk+kgPNj5uKwo5yyB4OyHfKE N+IpujVRMhnHuShdFdcpuE8OP0LeCgMgUg2KG7kSO4LZEdeBnImzP60MWdPJvogiqQ7n CKmitXnNGLobr4yhAuuhJ/yAyvbSojWktnUDIvtLTlbqcp7k+fhNiNDpt9YhEUfToxJ+ QWesMREexKD8pjPSc5zF7TpHYQGDZciHlCntBjLUP8Hy0MZVOxJ5nA9YYbDx/prt/Qwo lIpw== X-Forwarded-Encrypted: i=1; AJvYcCX1KhxLqBk+en+FaILjpEWAmtwGqY7jDRaEP9vVAYOIAy7VtjhdSJqCwJ/oSulDYfX5IqWFhjWmdOBqXY4=@vger.kernel.org X-Gm-Message-State: AOJu0YxA1ilTnQfyz88ziCYyJ+/wVAwXZbItR17Fw7aS3Lql9FtR8xVV TJcg4Ke5DE4fz0So4LcyCcfifc/TI8HGgz3okb+jfrD9iMCdhKLrWNzLVCpMmA/UZghlwbky7pA KjLrd23i/2s5Y/qw8bQ== X-Received: from ejqh18.prod.google.com ([2002:a17:906:5912:b0:b87:20a7:41e8]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a17:907:1c94:b0:b86:e937:d097 with SMTP id a640c23a62f3a-b885ae0a088mr139955566b.38.1769159882639; Fri, 23 Jan 2026 01:18:02 -0800 (PST) Date: Fri, 23 Jan 2026 09:18:01 +0000 In-Reply-To: <20260122180203.1502637-1-cmllamas@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260122180203.1502637-1-cmllamas@google.com> Message-ID: Subject: Re: [PATCH v2] binder: fix UAF in binder_netlink_report() From: Alice Ryhl To: Carlos Llamas Cc: Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Li Li , kernel-team@android.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Thu, Jan 22, 2026 at 06:02:02PM +0000, Carlos Llamas wrote: > Oneway transactions sent to frozen targets via binder_proc_transaction() > return a BR_TRANSACTION_PENDING_FROZEN error but they are still treated > as successful since the target is expected to thaw at some point. It is > then not safe to access 't' after BR_TRANSACTION_PENDING_FROZEN errors > as the transaction could have been consumed by the now thawed target. > > This is the case for binder_netlink_report() which derreferences 't' > after a pending frozen error, as pointed out by the following KASAN > report: > > ================================================================== > BUG: KASAN: slab-use-after-free in binder_netlink_report.isra.0+0x694/0x6c8 > Read of size 8 at addr ffff00000f98ba38 by task binder-util/522 > > CPU: 4 UID: 0 PID: 522 Comm: binder-util Not tainted 6.19.0-rc6-00015-gc03e9c42ae8f #1 PREEMPT > Hardware name: linux,dummy-virt (DT) > Call trace: > binder_netlink_report.isra.0+0x694/0x6c8 > binder_transaction+0x66e4/0x79b8 > binder_thread_write+0xab4/0x4440 > binder_ioctl+0x1fd4/0x2940 > [...] > > Allocated by task 522: > __kmalloc_cache_noprof+0x17c/0x50c > binder_transaction+0x584/0x79b8 > binder_thread_write+0xab4/0x4440 > binder_ioctl+0x1fd4/0x2940 > [...] > > Freed by task 488: > kfree+0x1d0/0x420 > binder_free_transaction+0x150/0x234 > binder_thread_read+0x2d08/0x3ce4 > binder_ioctl+0x488/0x2940 > [...] > ================================================================== > > Instead, make a transaction copy so the data can be safely accessed by > binder_netlink_report() after a pending frozen error. While here, add a > comment about not using t->buffer in binder_netlink_report(). > > Cc: stable@vger.kernel.org > Fixes: 63740349eba7 ("binder: introduce transaction reports via netlink") > Signed-off-by: Carlos Llamas Reviewed-by: Alice Ryhl