From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0D21FC7C5 for ; Fri, 23 Jan 2026 09:24:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769160277; cv=none; b=TmzlbxDLbFo80HDjy1EOb1fxxqisUOgdlxQ/HBY0DUERbP+NtfmjxRo1JK/b2LDCy6XGmEZpE47twGGTh1/OzrnHdmeGKZwShzNtm6IXvgUqBmdVPP0Wg10g32b8sYxtvPnIIjFhROJgtfT8byurVaojXeahvCSVrUJsO+Pysz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769160277; c=relaxed/simple; bh=08vQ2ckKTjFYbYRQ+G/M+j80/z3wYZ305U4WTqtcjAk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T3p7MxusjA5iDKMh2qMcl9asYc/ZiRiCXFBigZNwXrOiZ6/OG58kKQoOUcoWMjEjsfV+jPAmARR8ta0deIXvGYObxPffVWtWDfuLcaVGDHPTEsV5IN12rRTybW+gXk0k0PXApn20KViQJBlIiP1wIotc/dI4Yjbb9b2q5SFNEe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=JOW/0Z+q; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="JOW/0Z+q" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0/GQIiXa4atZMjYkCFcefWTVS4+uBblsXhsD3SJlLl4=; b=JOW/0Z+qGdrbBAuwYrrXf5GRLN bEMI7zmEQRC1Gz0Wjtut6XMT2shUAHN/SSrUpG13DcqjFe8ZmOQnVF2zy9Hr5257Bneg/ytGbtZSK 9z5qTyQN1Eam+mctXOddZhrs2FV6Ra3ktHtWhHuw7njSaH7rqPrRC5t6iAos67brbPiGYj2DNBVpE XL+Ur1PRS6W4OthWWYHdTzyi1Qbho27HVEvUcwJL6d+ZezLcRUEdQPHyaFQCh1621utn+YWOD+bpu AWIv0NUzkKvF6wBfCKqBcOoIVsdhq03pLKLUHeVpcb70PDS8MyIGy495o5C/gpYYFKxsuo5NhsyGs +o4iuxCw==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1vjDOw-00DjgV-IA; Fri, 23 Jan 2026 09:24:23 +0000 Date: Fri, 23 Jan 2026 01:24:17 -0800 From: Breno Leitao To: Baoquan He Cc: akpm@linux-foundation.org, vgoyal@redhat.com, dyoung@redhat.com, xueshuai@linux.alibaba.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, osandov@osandov.com, kernel-team@meta.com Subject: Re: [PATCH v2] vmcoreinfo: make hwerr_data visible for debugging Message-ID: References: <20260122-fix_vmcoreinfo-v2-1-2d6311f9e36c@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Debian-User: leitao Hello Baoquan, On Fri, Jan 23, 2026 at 08:19:40AM +0800, Baoquan He wrote: > On 01/22/26 at 02:39am, Breno Leitao wrote: > > If the kernel is compiled with LTO, hwerr_data symbol might be lost, and > > vmcoreinfo doesn't have it dumped. This is currently seen in some > > production kernels with LTO enabled. > > > > Remove the static qualifier from hwerr_data so that the information is > > still preserved when the kernel is built with LTO. Making hwerr_data > > a global symbol ensures its debug info survives the LTO link process and > > appears in kallsyms. Also document it, so, it doesn't get removed in the > > future as suggested by akpm. > > > > Signed-off-by: Breno Leitao > > --- > > Changes in v2: > > - Add a comment to explain why the array is global (akpm) > > - Link to v1: https://patch.msgid.link/20260121-fix_vmcoreinfo-v1-1-39e96fab670e@debian.org > > --- > > kernel/vmcore_info.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > LGTM, > > Acked-by: Baoquan He > > BTW, is it worth a 'Fixes' tag? I am not sure, but, if we prefer to, this is the correct tag: Fixes: 3fa805c37dd4d ("vmcoreinfo: track and log recoverable hardware errors") Thanks for the review, --breno