From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
"Thomas Gleixner" <tglx@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 19/21] iio: Use IRQF_NO_THREAD
Date: Fri, 23 Jan 2026 16:50:58 +0200 [thread overview]
Message-ID: <aXOK0vqIQbCAw7mx@smile.fi.intel.com> (raw)
In-Reply-To: <20260123113708.416727-20-bigeasy@linutronix.de>
On Fri, Jan 23, 2026 at 12:37:05PM +0100, Sebastian Andrzej Siewior wrote:
> The interrupt handler iio_trigger_generic_data_rdy_poll() will invoke
> other interrupt handler and this supposed to happen from within the
> hardirq.
>
> Use IRQF_NO_THREAD to forbid forced-threading.
...
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: David Lechner <dlechner@baylibre.com>
> Cc: "Nuno Sá" <nuno.sa@analog.com>
> Cc: Andy Shevchenko <andy@kernel.org>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Michael Hennerich <Michael.Hennerich@analog.com>
> Cc: linux-iio@vger.kernel.org
Same comment about Cc list.
...
> ret = request_irq(st->i2c->irq,
> &iio_trigger_generic_data_rdy_poll,
> - IRQF_TRIGGER_RISING,
> + IRQF_NO_THREAD | IRQF_TRIGGER_RISING,
Maybe swap their positions as it's done everywhere else for the consistency's
sake?
> "itg3200_data_rdy",
> st->trig);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-23 14:51 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 11:36 [PATCH 00/21] IRQF_ONESHOT clean up Sebastian Andrzej Siewior
2026-01-23 11:36 ` [PATCH 01/21] genirq: Set IRQF_COND_ONESHOT in devm_request_irq() Sebastian Andrzej Siewior
2026-01-23 11:36 ` [PATCH 02/21] platform/x86: int0002: Remove IRQF_ONESHOT from request_irq() Sebastian Andrzej Siewior
2026-01-23 11:49 ` Sebastian Andrzej Siewior
2026-01-26 14:05 ` Ilpo Järvinen
2026-01-24 10:21 ` Hans de Goede
2026-01-23 11:36 ` [PATCH 03/21] iommu/amd: Use core's primary handler and set IRQF_ONESHOT Sebastian Andrzej Siewior
2026-01-23 11:36 ` [PATCH 04/21] mailbox: bcm-ferxrm-mailbox: Use default primary handler Sebastian Andrzej Siewior
2026-01-23 11:36 ` [PATCH 05/21] bus: fsl-mc: " Sebastian Andrzej Siewior
2026-01-23 14:28 ` Ioana Ciornei
2026-01-23 11:36 ` [PATCH 06/21] Bluetooth: btintel_pcie: Use IRQF_ONESHOT and " Sebastian Andrzej Siewior
2026-01-23 11:36 ` [PATCH 07/21] scsi: efct: " Sebastian Andrzej Siewior
2026-02-04 3:02 ` Martin K. Petersen
2026-01-23 11:36 ` [PATCH 08/21] ARM: versatile: Remove IRQF_ONESHOT Sebastian Andrzej Siewior
2026-01-23 15:26 ` Sudeep Holla
2026-01-27 9:42 ` Linus Walleij
2026-01-23 11:36 ` [PATCH 09/21] char: tpm: cr50: " Sebastian Andrzej Siewior
2026-01-25 16:50 ` Jarkko Sakkinen
2026-01-27 15:45 ` Sebastian Andrzej Siewior
2026-01-28 23:17 ` Jarkko Sakkinen
2026-01-23 11:36 ` [PATCH 10/21] EDAC/altera: " Sebastian Andrzej Siewior
2026-01-23 11:36 ` [PATCH 11/21] i2c: spacemit: " Sebastian Andrzej Siewior
2026-01-23 20:53 ` Yixun Lan
2026-01-26 4:21 ` patchwork-bot+linux-riscv
2026-01-23 11:36 ` [PATCH 12/21] ASoC: codecs: rt56*: " Sebastian Andrzej Siewior
2026-01-23 11:36 ` [PATCH 13/21] usb: typec: fusb302: " Sebastian Andrzej Siewior
2026-01-23 16:07 ` Greg Kroah-Hartman
2026-01-26 14:21 ` Heikki Krogerus
2026-01-23 11:37 ` [PATCH 14/21] rtc: amlogic-a4: " Sebastian Andrzej Siewior
2026-01-26 6:05 ` Xianwei Zhao
2026-01-23 11:37 ` [PATCH 15/21] thermal/qcom/lmh: Replace IRQF_ONESHOT with IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-01-23 11:37 ` [PATCH 16/21] perf/cxlpmu: " Sebastian Andrzej Siewior
2026-01-23 12:05 ` Jonathan Cameron
2026-01-23 11:37 ` [PATCH 17/21] mfd: wm8350-core: Use IRQF_ONESHOT Sebastian Andrzej Siewior
2026-01-23 14:52 ` Andy Shevchenko
2026-01-26 8:01 ` Sebastian Andrzej Siewior
2026-01-26 9:46 ` Andy Shevchenko
2026-01-26 9:56 ` Sebastian Andrzej Siewior
2026-01-26 10:05 ` Andy Shevchenko
2026-01-26 10:13 ` Sebastian Andrzej Siewior
2026-01-26 11:22 ` Andy Shevchenko
2026-01-26 11:28 ` Andy Shevchenko
2026-01-26 9:32 ` Charles Keepax
2026-01-23 11:37 ` [PATCH 18/21] iio: Replace IRQF_ONESHOT with IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-01-23 14:48 ` Andy Shevchenko
2026-01-23 16:47 ` Jonathan Cameron
2026-01-23 21:00 ` David Lechner
2026-01-26 8:15 ` Sebastian Andrzej Siewior
2026-01-26 9:51 ` Andy Shevchenko
2026-01-26 10:10 ` Sebastian Andrzej Siewior
2026-01-26 11:01 ` Andy Shevchenko
2026-01-26 14:29 ` Konstantin Ryabitsev
2026-01-26 14:57 ` Andy Shevchenko
2026-01-26 15:09 ` Konstantin Ryabitsev
2026-01-26 15:16 ` Andy Shevchenko
2026-01-28 10:45 ` Nuno Sá
2026-01-28 13:53 ` Konstantin Ryabitsev
2026-01-28 10:07 ` Sebastian Andrzej Siewior
2026-01-28 10:15 ` Andy Shevchenko
2026-01-26 10:53 ` Marcus Folkesson
2026-01-28 11:39 ` Nuno Sá
2026-01-23 11:37 ` [PATCH 19/21] iio: Use IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-01-23 14:50 ` Andy Shevchenko [this message]
2026-01-26 9:25 ` Sebastian Andrzej Siewior
2026-01-23 20:56 ` David Lechner
2026-01-26 8:09 ` Sebastian Andrzej Siewior
2026-01-26 16:34 ` David Lechner
2026-01-23 11:37 ` [PATCH 20/21] iio: magnetometer: Remove IRQF_ONESHOT Sebastian Andrzej Siewior
2026-01-23 14:51 ` Andy Shevchenko
2026-01-27 19:37 ` Geert Uytterhoeven
2026-01-28 11:40 ` Nuno Sá
2026-01-28 12:34 ` Andy Shevchenko
2026-01-23 11:37 ` [PATCH 21/21] media: pci: mg4b: Use IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-01-26 18:45 ` (subset) [PATCH 00/21] IRQF_ONESHOT clean up Mark Brown
2026-02-08 2:01 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXOK0vqIQbCAw7mx@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=nuno.sa@analog.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox