From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35A6C2EF64C for ; Fri, 23 Jan 2026 20:45:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769201135; cv=none; b=k1XyB8EpjSWiwQVwZt1mqYkr23D67U9e9DmwuFoLqBlHCjvY/WjiHLYVeksy9suH4xVSOWjzw2Robz1Znx9x9RXuOo520q4Sm8r1LuMs94U4SlRpfj+jBbOWzrIWjqOLI0mjrVLwDEiiwlpZpIzeaxdQDh7WF4hMjV8vwQR6cpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769201135; c=relaxed/simple; bh=umLB6rOEr3GkGF61tcxwckM/8U3WZrQ/4qv93IEA1H0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OtIINof2Rs53vQ3N/XB5IcoFD6M0oKMx+7VEEGzyN4cQp0qOPCWZMN9fGI+FB8B1oc+Hf6+s+2DFQrkiKtcuU6100a9Dd5oDIGmeJ/JSPKffFleKPJ21gr5rrtsVxuf1+h1dhNW43w/ANwc4m0+ygBHQotR6JVyV4AX6bZZUFl4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=le188lxa; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="le188lxa" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-47ee4539adfso28297345e9.3 for ; Fri, 23 Jan 2026 12:45:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769201132; x=1769805932; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZW/tiNOTCqEygs1+4rLDniih84DtCcxkDnEgvERK+7s=; b=le188lxa6XAGzz6ZWywSkzs3t0Up0KInNym7Mpf3iEA2ZiW9T/JlaH+v/h+aS5gnP0 4iCnlXYY7ATIZhGnu/IsO6thQ1H2loVVW78tULFIInWY5yj/FVGvCKTrU9vg/yaqkpmO y4IsVLV6muZvhaGynO6tjjSqCoGQjjzsR7r0JHlVcfB1ZngjvyVTH8VDT0p5GGT4I0FV V39UhJNX3eCElavi13OKXW3aB3TD2G3ctFufGAVZxafKHoDMLr9u1veCZL9z/xS3mvpW JyIRzxM/TxJmg+Ij+E8SyQ/OVJJWOPkk9viXDhCp/tNmqi2kWb4/dhmuc7iiPmdl2YsN 1usQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769201132; x=1769805932; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZW/tiNOTCqEygs1+4rLDniih84DtCcxkDnEgvERK+7s=; b=IX7q8xP5HiwqMbnk5rqDGdtD9m2huqAG09ICQl7LGqseYR7mkRYk5zebvs7C+lgzfo wldxJFPhlnM+lgXkJjVaLDqDBGbkrRgPPweEm2QK1RAdouviE0EnMt9+z7qaWIBUdqxF z5id7tioErgPnBkjl5T9g8wmGZN4VQmGbxB8N84CSmnODZYveVy69any18Q1pXOVgeIa x4CVyYcCqcYz/dn4K/YPKMV7Rf7B31depfOv5bfl4cM7v9EUDMi+ak/tDqLCjdMeEg5Q J3FbnO4YywSxhmhvECznzixq478CXNSIb9PfIGTqvqNVdbkbZUoQK6GrNFdp2334V42Z 8MwA== X-Forwarded-Encrypted: i=1; AJvYcCWbfet3df8UdjnFcO/5MVplhCZ1eIm7r0/Qrvmot0/OXF0KjTPnXArdL6oyArDJa04hgOoTYEmWCTvqOMk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw39C9AnSCpide3Ilf6Odmy9ceGjN2Lj9ekTpM736jT0tZ0TB2L Hub0ZJgXg9z/uAcapMGC6zFk5LZMjxgBpgAsG541i9zHgF8QRdiU5CpocBPKznsCpy0= X-Gm-Gg: AZuq6aLomkYK4+p6P2v7Dw8I1EdBKPUJG+AIiHNbC9/hx4D+KfC5DHAKuricaujG10u 6MpCXrbPcJxQjBT6n9ZCMI6FrIgkR/+xTQvoZz3cqIDrDbCvMsq5iolaDVAzvb/rRpGeQFuD+Ft 78IX6iX7t4E1JWuyxKJpqWU7cFQTVUi8qJRxGlhz+/Yz5OOn3usCT6hyVK7x+C/dQN7RIceJ7gD WamQOrRinZokeAIoOOFfQpmBQ49V76H9JeY3r4WXiR1XUiEu8Y2luGd+E+PkBF3l9yY0NPorreC 5L0Y8MuzXf7rZF9iZ4Bpstq23oXvLIUU23Dn1tZG8adE/Ce4apkJsE0oA24PyO8kFu1Oozxj83R ryXqit81iZNWAJSwpMfq6GMKnddr32cg9/VJhBOfkBF8avtL0xbuWlF/0xiwC92EgJhX2iYoBvt CxJVsw/Y2LPvCA6C3v X-Received: by 2002:a05:600c:8283:b0:47f:b737:5ce0 with SMTP id 5b1f17b1804b1-4804c9b4cb3mr74893575e9.23.1769201131982; Fri, 23 Jan 2026 12:45:31 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4804703b59esm168362405e9.4.2026.01.23.12.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 12:45:31 -0800 (PST) Date: Fri, 23 Jan 2026 23:45:27 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: most: dim2: replace macro with static function Message-ID: References: <20260123191150.3281-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260123191150.3281-1-ethantidmore06@gmail.com> On Fri, Jan 23, 2026 at 01:11:50PM -0600, Ethan Tidmore wrote: > Replace unsafe macro with function to avoid side effects. > > Signed-off-by: Ethan Tidmore > --- > Changes in v2: > - Removed 'inline' keyword. > - Fix indentation alignment in return statement. Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter