From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3294199252 for ; Sat, 24 Jan 2026 00:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769214059; cv=none; b=Weh/rg6tLvoJXBTJ8TiURSZCYaK4Bh7LWTmMtXHB1FPyzwniVYTVNuu1GKjsjYoxhminI5qD/fBC7m8FENdqBGmYAVwmWo3DZ/DAejgSxSZT8ndy9ADIyzTMpspGGKjjN0yzfoGNPTVmj9soSP4pMUh8foQriXyck2j22zXJph0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769214059; c=relaxed/simple; bh=j2cnf66j7Tyeo03Ht3nxIfKsvE0nQ1mv6D7kqhjkBJ8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OLL6ksQNsfOWw2xo9zkJHt/8dok0IGhj33m+sxmEQGdMEoQRzviU+CiKSEoLG7JmbWjoE/ZjIVwpJyqV19+OKiS01DF5cnQQIZ9cTKwvzyily0MAO0PX+g10f4bTx3p8/i81RoVVrb+L9Y8NNLzd5ro3Bh1vJNhruwfRnnfVimM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gPqAskv8; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=cywcp0Nf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gPqAskv8"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="cywcp0Nf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769214056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xhgLPiYR6xEsxXnQ/SeaMjXXghHvMuOe7YsndhfrobA=; b=gPqAskv8/iuAIelkAE02Mn5AzPTZq+2afA8ZwLjZq6cnB+hM2uk9a5HD1oPkITCfuYbXHx +rKoOhUta5LfNYV+2z8Yy3XT9ueZYtv3n+bT9J9aGBcAaf6Ew1rZaPWdz+E0FLTZKK8Q/b 2+LbOmXOchBuzQEPEdQ8Dlt75VTeVJw= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-xvfr0oO5Naem7PyHmNUyHQ-1; Fri, 23 Jan 2026 19:20:55 -0500 X-MC-Unique: xvfr0oO5Naem7PyHmNUyHQ-1 X-Mimecast-MFC-AGG-ID: xvfr0oO5Naem7PyHmNUyHQ_1769214055 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a76f2d7744so23237575ad.3 for ; Fri, 23 Jan 2026 16:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769214054; x=1769818854; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xhgLPiYR6xEsxXnQ/SeaMjXXghHvMuOe7YsndhfrobA=; b=cywcp0NfT4qTxGKtlk4pEqV6LpdD2LHnGGFpE3nSVwX6aejnZN0oJvvH7X6ppckev0 NmqEYd5Khy+qEN6tU3NtowvlifS9f5TYdQSBjOcsQCcGVc+RmvKDumIaEQEhJWwINLex hhqAjZWSHn2PTSZq4GxgEPdbo8qOPEufVWkNR+R+QKN3IAaysiZ/wfeRpsWD12D/pC6n V1+30S6cbMs94/493Z85O0QCOG2NdQRTmD8cGu5QS44aZeHChCfDkXOGWnPFH4fo19mb xdBm0R0HwUmQUWcLNVMGErySfUJtRKE2LcPVRXO1kGLdRVehd/EA0YoR5sOOoRjQmZca 8AXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769214054; x=1769818854; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xhgLPiYR6xEsxXnQ/SeaMjXXghHvMuOe7YsndhfrobA=; b=ftkNqtSpBxW4Onc722Up344Ok9p5z+jJjiIGJpjXMdJ3yos0ihpUiHW7AMxiibtm5D FHuvDP2gs0rTMMlRXkY91FzBxRwrJU18BgeKArialuOLJwnczbyNcvhCKGK1rLG3ptkx Sh9zwZaMaZ89dBY476u51jHXJMgIGUCDahQP4h2oZ3ZovIeeiPPXvOKVeyI6SPbQpTPl djcceBMVBOP0KN6aL2J8myVA4a2q6nNY6PkdwW3yNoK1+oHHziYF39eiMqAWJ9HzeXcK Du4OtsjYLsd1JYGE3Da4gjNI2Ndukgl5mlZRa7THRpfjR9jOHVQHEISNeZ3fj6MbJtvA 0ifQ== X-Forwarded-Encrypted: i=1; AJvYcCVHBrSGIci5Bgix3Cm+05+c1o624+hNR2KHhcBf5SYovUayAvxDZnxGUp3No9l1WVW5O8ER5bAad1Ap1CY=@vger.kernel.org X-Gm-Message-State: AOJu0YwrPAw2IDocuff0/XwjN4BsK+tNpEWPKCvSn9vW2gLyN9A7kT4w 4jJX7Dq2TCNAH+lZ9uuRkN++MNDgwiiVYOWqNl01D+XVNEqWBKXYFxKLBKPeneTuAIE3zA0d1e3 9BS9S3BJd1smBdACoPbjBXn9AvJcgKbqm88fnTtgYJ7+HG040aZpZvwEMlZ4yQYOtfQ== X-Gm-Gg: AZuq6aLW2ZISQNAB+H/oyHIaWgvMGoGpn+whBv3D6wT1O8ZF6L3/T14S0W//L4cRLZg Zy+6prIlLk8hz4wwYUJ2Rn9x0VIdrdsJDutdYklS6wXp/dMdExduv9y+F33RBWU9/kCpnkymwGh cqaZYZ3iQkxV2cyZH19XOSjL33+0zm8jy4oXKxPbFylLcERx4S6O3Hd1Is5A0Rb7KcofMmqco52 l+LxMDilunHhrSU+wLkXHMquPShS0si6IwjKeRQ3TbMXibkjj4p1w7DrMMH6fFNHAh1ld8BDC0d 0evzYwbTWLLC+mmFhhPfwIXH9BYB8JdNEK6tsuo0wyf3yfFEqkF/x6ziAqc5ZAtHP2+EaxEBxgx g X-Received: by 2002:a17:902:e54d:b0:2a7:682b:50ac with SMTP id d9443c01a7336-2a7fe625118mr44257545ad.28.1769214054355; Fri, 23 Jan 2026 16:20:54 -0800 (PST) X-Received: by 2002:a17:902:e54d:b0:2a7:682b:50ac with SMTP id d9443c01a7336-2a7fe625118mr44257045ad.28.1769214053812; Fri, 23 Jan 2026 16:20:53 -0800 (PST) Received: from localhost ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802faf6f9sm29695045ad.71.2026.01.23.16.20.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 16:20:53 -0800 (PST) Date: Sat, 24 Jan 2026 08:18:46 +0800 From: Coiby Xu To: Ard Biesheuvel , Mimi Zohar Cc: Dave Hansen , linux-integrity@vger.kernel.org, Heiko Carstens , Roberto Sassu , Catalin Marinas , Will Deacon , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" , Jarkko Sakkinen , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , open list , "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , "open list:S390 ARCHITECTURE" , "open list:EXTENSIBLE FIRMWARE INTERFACE (EFI)" , "open list:SECURITY SUBSYSTEM" , "open list:KEYS/KEYRINGS_INTEGRITY" Subject: Re: [PATCH 1/3] integrity: Make arch_ima_get_secureboot integrity-wide Message-ID: References: <20260115004328.194142-2-coxu@redhat.com> <8bfa859ed3a4f1cf0db0ab64d8c1c3b24684582a.camel@linux.ibm.com> <97b69bc79a5d9246f7a399510908c7b95b2e95e7.camel@linux.ibm.com> <1a0b6e5601a673a81f8823de0815f92b7afbeb60.camel@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Wed, Jan 21, 2026 at 05:25:39PM +0100, Ard Biesheuvel wrote: >On Wed, 21 Jan 2026 at 16:41, Mimi Zohar wrote: >> >> On Mon, 2026-01-19 at 12:04 +0800, Coiby Xu wrote: >> >> > diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig >> > index 976e75f9b9ba..5dce572192d6 100644 >> > --- a/security/integrity/ima/Kconfig >> > +++ b/security/integrity/ima/Kconfig >> > @@ -311,6 +311,7 @@ config IMA_QUEUE_EARLY_BOOT_KEYS >> > config IMA_SECURE_AND_OR_TRUSTED_BOOT >> > bool >> > depends on IMA_ARCH_POLICY >> > + depends on INTEGRITY_SECURE_BOOT >> > >> > >> > Another idea is make a tree-wide arch_get_secureboot i.e. to move >> > current arch_ima_get_secureboot code to arch-specific secure boot >> > implementation. By this way, there will no need for a new Kconfig option >> > INTEGRITY_SECURE_BOOT. But I'm not sure if there is any unforeseen >> > concern. >> >> Originally basing IMA policy on the secure boot mode was an exception. As long >> as making it public isn't an issue any longer, this sounds to me. Ard, Dave, do >> you have any issues with replacing arch_ima_get_secureboot() with >> arch_get_secureboot()? > >I don't see an issue with that. If there is a legitimate need to >determine this even if IMA is not enabled, then this makes sense. Thanks for the confirmation! Here's the updated patch https://github.com/coiby/linux/commit/c222c1d08d90ef1ec85ef81ece90afc9efde7937.patch If there is no objection, I'll send v2. -- Best regards, Coiby