From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A26221643B for ; Sat, 24 Jan 2026 01:59:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769219955; cv=none; b=gfmgSiw43st5UNrad43nqBkUgO4E5Hkmdlzv3KzLEH0rLzWUk3oWbQCULwhoEUZaLxtFbWP/oSRipiajhVyb8eJYJ2RSQ86vBKKt+9/orK4pZ9dalikacJFuizoI/j52+myIyizaiO3sGOfLj9FrZbOmyyKT9y8tnPjhYVkfmCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769219955; c=relaxed/simple; bh=OCJU2vpdT/7PiTBRvu0u+kvTGeLbGrvB3Q3qIKois1E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K5NRUpJKGrriXvcKqqfQG+0eTNk2NI0ms1YBMpfdfWSJhnQWEMYUWRU7yNM+N9ZLSxff7aY69xkkfLeC9W37/S0PZf4aJgCloQ9vaYDwrylZ8W49dq8Hq53LpMiwCWQ2zyoRdmrGR6znWqGdknQmZYcpUYekPn9uMF5cAfMRpJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FngTmR2Z; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FngTmR2Z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769219952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5ZFqGGMnofk6KsFaA45jYNnk78K7dfGatWnS4VfY3WQ=; b=FngTmR2ZeQVOkpHkhVP6MNh0PGuz1XhY9/ggLFNf6l31M3uBSq+cnL7+XM4JIYwEvU2amc GmKZrVmZOM6qQ1QGyT5guRHQwlaDiwru6CREn5MMJoa/zouJCxfh9sFqQ0+0tBNgP8xzv6 HUhzG9+2cMglMPjAa+jmutCE8DLuWqs= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-321-R_Ou61ZJM_SE7OmFz9qJ9g-1; Fri, 23 Jan 2026 20:59:07 -0500 X-MC-Unique: R_Ou61ZJM_SE7OmFz9qJ9g-1 X-Mimecast-MFC-AGG-ID: R_Ou61ZJM_SE7OmFz9qJ9g_1769219945 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 249E31956050; Sat, 24 Jan 2026 01:59:05 +0000 (UTC) Received: from localhost (unknown [10.72.112.13]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EEA9A1958DC4; Sat, 24 Jan 2026 01:59:03 +0000 (UTC) Date: Sat, 24 Jan 2026 09:58:59 +0800 From: Baoquan He To: Andrew Morton , Breno Leitao Cc: vgoyal@redhat.com, dyoung@redhat.com, xueshuai@linux.alibaba.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, osandov@osandov.com, kernel-team@meta.com Subject: Re: [PATCH v2] vmcoreinfo: make hwerr_data visible for debugging Message-ID: References: <20260122-fix_vmcoreinfo-v2-1-2d6311f9e36c@debian.org> <20260123164950.6988b5fe7e11d5986e399752@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260123164950.6988b5fe7e11d5986e399752@linux-foundation.org> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On 01/23/26 at 04:49pm, Andrew Morton wrote: > On Fri, 23 Jan 2026 01:24:17 -0800 Breno Leitao wrote: > > > Hello Baoquan, > > > > On Fri, Jan 23, 2026 at 08:19:40AM +0800, Baoquan He wrote: > > > On 01/22/26 at 02:39am, Breno Leitao wrote: > > > > If the kernel is compiled with LTO, hwerr_data symbol might be lost, and > > > > vmcoreinfo doesn't have it dumped. This is currently seen in some > > > > production kernels with LTO enabled. > > > > > > > > Remove the static qualifier from hwerr_data so that the information is > > > > still preserved when the kernel is built with LTO. Making hwerr_data > > > > a global symbol ensures its debug info survives the LTO link process and > > > > appears in kallsyms. Also document it, so, it doesn't get removed in the > > > > future as suggested by akpm. > > > > > > > > Signed-off-by: Breno Leitao > > > > --- > > > > Changes in v2: > > > > - Add a comment to explain why the array is global (akpm) > > > > - Link to v1: https://patch.msgid.link/20260121-fix_vmcoreinfo-v1-1-39e96fab670e@debian.org > > > > --- > > > > kernel/vmcore_info.c | 6 +++++- > > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > LGTM, > > > > > > Acked-by: Baoquan He > > > > > > BTW, is it worth a 'Fixes' tag? > > > > I am not sure, but, if we prefer to, this is the correct tag: > > > > Fixes: 3fa805c37dd4d ("vmcoreinfo: track and log recoverable hardware errors") > > 3fa805c37dd4d was added in 6.19-rc1, so this patch is a fixup against > this rc series. So yes, it should go into 6.19-rcX also. Ah, then no need. thanks.