From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E86673EBF02; Sun, 25 Jan 2026 07:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769325936; cv=none; b=DKVw03cKUaq3BsfkRb99Yj03ZklSy769YvMO7XvRZwS0HeGZbCqnH/a2T41gOH6oYzibdwn1c865hsS2rTubHXmOf5qrK0mabION4FYXNd4kMNQL+6KnzzTGstD6h0Idn4R/2f4Ga/CROv00fBqwD6gMbm7gp4zAG9ptOEvy+Aw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769325936; c=relaxed/simple; bh=UeqZaPacbBiLN6/QCJWKI3nT4CbD1MdBgoyPgiithzE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=br8TgaRjTLKeDh/BJLsBv00DB86tfFp3TRFB6huV4a5E/lYlga1QFIeZY7QXut/xOiYjrQkgdTXCtETjXm2Yf8+8fBNAHKSziB285Y4o/QdRJXMDSQ3uiWSDBlSYJ2ZOsFTntVExn9bUFzv0AqWPtkIvLtKuo9A9vi8wewTB2c8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MI9qfpfR; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MI9qfpfR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769325934; x=1800861934; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UeqZaPacbBiLN6/QCJWKI3nT4CbD1MdBgoyPgiithzE=; b=MI9qfpfRWgzHHSlzKagWyk87BH0ANFBfh6fPOPwSS2QjCSuFXVrsrKRJ YRB9uLDM7/bovOus1gZ/jKNo9Zq1dl25ZOLEFAD794LKncCjz6pOz0Tk3 n/XD1QJBazRGyQAOaHvywInwgnQPoSbKGn9+ws4kcCIH7p5I/PNL4rM1w 6nRXbdsbUqQTXYpwrZASMhQZnP3yMMTmxMMFV8SYDeTnY7uPRpFEY/Xtd w8J/BDnIlzuNFGD7brPve6Eh4Tx8+dXGNhuPrbGB5+4vmIIm+QoLVETkf 2oMpgIQAd82jtf0fsqc/E2CevjultIApxRqvaxlRInkvhPvDBxPWN4cPw Q==; X-CSE-ConnectionGUID: cGKk0/wLRBCDbO4tE1hNTg== X-CSE-MsgGUID: RgpV11TIQFCXvt8at+IqGg== X-IronPort-AV: E=McAfee;i="6800,10657,11681"; a="70497334" X-IronPort-AV: E=Sophos;i="6.21,252,1763452800"; d="scan'208";a="70497334" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2026 23:25:34 -0800 X-CSE-ConnectionGUID: FfAeQEwsQ66HYg1q/+rMrg== X-CSE-MsgGUID: U6xvTIYWQ6uFsgXZimpItQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,252,1763452800"; d="scan'208";a="211905597" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.39]) by orviesa004.jf.intel.com with ESMTP; 24 Jan 2026 23:25:30 -0800 Date: Sun, 25 Jan 2026 15:51:03 +0800 From: Zhao Liu To: Sean Christopherson Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Gao , Xudong Hao Subject: Re: [PATCH 2/4] KVM: x86: Advertise AMX CPUIDs in subleaf 0x1E.0x1 to userspace Message-ID: References: <20251120050720.931449-1-zhao1.liu@intel.com> <20251120050720.931449-3-zhao1.liu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > Unless someone feels *very* strongly about the "mirror" terminology, I'm going to > use ALIAS instead of MIRROR when applying, to match KVM's existing terminology for > the 8000_0001.EDX => 1.EDX aliases. > > /* > * Intel-defined sub-features, CPUID level 0x0000001E:1 (EAX). Note, several > * of the bits are aliases to features of the same name that are enumerated via > * various CPUID.0x7 sub-leafs. > */ > #define X86_FEATURE_AMX_INT8_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 0) > #define X86_FEATURE_AMX_BF16_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 1) > #define X86_FEATURE_AMX_COMPLEX_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 2) > #define X86_FEATURE_AMX_FP16_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 3) LGTM, yes, ALIAS sounds better than MIRROR. Thanks, Zhao