From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C33423EAAD for ; Sun, 25 Jan 2026 11:51:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769341865; cv=none; b=SN8JLZfaa58cvzjD1KGobzRJSi3h4JsvnrctpZrymCih9FG6WRUi87HVQqDpKB/fOS36F5eXD9AuNlGFJ+8R1XZFlpyfT8OkMjrdJE2ynsrqlaUAr8WXR3MK+epVxJiGd705m6D2fE3cbxMTQE31MWf0B3Hb5dzH5j+VQlRmzkA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769341865; c=relaxed/simple; bh=6TAiQebVh1oHpaGV4OnDP/LH0lIQ9CGxw6VodtIwayY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O7pfmoQy3nJ7v/Zu0+vCNHNcuCIHf3UxFKWNtHU73/Du8rFgrZePFH/p/IjHhFHESk5DufLUy2ZH+gqmEzANiHEPUZ+mTvODaSV8UDlOx8cBAi01H1jsfM4SrH8JFc1vJk9rZPb6NymmP5iBfZCH3ymIWD/R8UnWi8zQJbFNtjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=q0ZMoQno; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q0ZMoQno" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16513C4CEF1; Sun, 25 Jan 2026 11:51:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769341864; bh=6TAiQebVh1oHpaGV4OnDP/LH0lIQ9CGxw6VodtIwayY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q0ZMoQnoT6qLr0kWpr2fmisUihk0K+he89tFOWATBNMW0H+/p5iE0vjMW5LUKLuBY a06+SfVmC8JYdAbJKa60U5rbi8DgEHGil9QfJD88bWZRIEzYyL4ysQxALbEc1Bkp3X m8IvjGt6dOE8edZHeIJI849An14dyi/Hpe9AgYOS/oNKWODUAgtolCSeOMv6mWEaKV Jy49n7cfaHoj7ifPB+YQAbxSfF++0gxnizvxkyQql5453LypHgWfY9n8FAhzuzuNzI Hv+u8Yvicv/m+AxetAHAPRSiUCPP/sSR21D/lkRag1expC6f4l5FXi081y6E/o2e+b EdJx0kPJ25/kQ== Date: Sun, 25 Jan 2026 13:50:58 +0200 From: Mike Rapoport To: Tycho Andersen Cc: Alexander Graf , Pasha Tatashin , Pratyush Yadav , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kho: fix doc for kho_restore_pages() Message-ID: References: <20260123190506.1058669-1-tycho@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260123190506.1058669-1-tycho@kernel.org> On Fri, Jan 23, 2026 at 12:05:06PM -0700, Tycho Andersen wrote: > From: "Tycho Andersen (AMD)" > > This function returns NULL if kho_restore_page() returns NULL, which > happens in a couple of corner cases. It never returns an error code. > > Signed-off-by: Tycho Andersen (AMD) Reviewed-by: Mike Rapoport (Microsoft) > --- > kernel/liveupdate/kexec_handover.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c > index d4482b6e3cae..4c38ea7987c8 100644 > --- a/kernel/liveupdate/kexec_handover.c > +++ b/kernel/liveupdate/kexec_handover.c > @@ -281,7 +281,7 @@ EXPORT_SYMBOL_GPL(kho_restore_folio); > * Restore a contiguous list of order 0 pages that was preserved with > * kho_preserve_pages(). > * > - * Return: 0 on success, error code on failure > + * Return: the first page on success, NULL on failure. > */ > struct page *kho_restore_pages(phys_addr_t phys, unsigned int nr_pages) > { > > base-commit: c072629f05d7bca1148ab17690d7922a31423984 > -- > 2.52.0 > -- Sincerely yours, Mike.