From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
"Boris Brezillon" <boris.brezillon@collabora.com>,
"Christian König" <christian.koenig@amd.com>,
"Felix Kuehling" <felix.kuehling@amd.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Steven Price" <steven.price@arm.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org
Subject: [PATCH v2 2/7] android/binder: use same_thread_group(proc->tsk, current) in binder_mmap()
Date: Sun, 25 Jan 2026 17:07:20 +0100 [thread overview]
Message-ID: <aXY_uPYyUg4rwNOg@redhat.com> (raw)
In-Reply-To: <aXY_h8i78n6yD9JY@redhat.com>
With or without this change the checked condition can be falsely true
if proc->tsk execs, but this is fine: binder_alloc_mmap_handler() checks
vma->vm_mm == alloc->mm.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
---
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index dea701daabb0..b3b73303f84d 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -6015,7 +6015,7 @@ static int binder_mmap(struct file *filp, struct vm_area_struct *vma)
{
struct binder_proc *proc = filp->private_data;
- if (proc->tsk != current->group_leader)
+ if (!same_thread_group(proc->tsk, current))
return -EINVAL;
binder_debug(BINDER_DEBUG_OPEN_CLOSE,
--
2.52.0
next prev parent reply other threads:[~2026-01-25 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 16:06 [PATCH v2 0/7] don't abuse task_struct.group_leader Oleg Nesterov
2026-01-25 16:07 ` [PATCH v2 1/7] android/binder: don't abuse current->group_leader Oleg Nesterov
2026-01-25 16:07 ` Oleg Nesterov [this message]
2026-01-25 16:07 ` [PATCH v2 3/7] drm/amdgpu: " Oleg Nesterov
2026-01-25 16:07 ` [PATCH v2 4/7] drm/amd: kill the outdated "Only the pthreads threading model is supported" checks Oleg Nesterov
2026-01-25 16:07 ` [PATCH v2 5/7] drm/pan*: don't abuse current->group_leader Oleg Nesterov
2026-01-25 16:07 ` [PATCH v2 6/7] RDMA/umem: " Oleg Nesterov
2026-01-25 16:08 ` [PATCH v2 7/7] netclassid: use thread_group_leader(p) in update_classid_task() Oleg Nesterov
2026-01-25 19:37 ` Jakub Kicinski
2026-01-26 20:50 ` Andrew Morton
2026-01-26 20:53 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXY_uPYyUg4rwNOg@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=boris.brezillon@collabora.com \
--cc=christian.koenig@amd.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=felix.kuehling@amd.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox