From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DB462DF151 for ; Mon, 26 Jan 2026 21:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.77.166.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769464583; cv=none; b=mlTmypJay+omXC9BYI5WiJuwdwDjh7aaj9Sspz8Crokau/O8QSN/SlPHYhSTCczni1nafRknZjoY9ElmcpGoQdOEv2ddH9HCbFHMvIt9iCKQenrBmSIr7gF2S6OSDt8jvsWcW+YlBoSz745gGEquA5BJAPkFR0VkDHWTdzU9IIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769464583; c=relaxed/simple; bh=Eskd56toZaov8Ac2PLfdyauRDzx4PyOHfS2t8TEbC+c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oE+mEIsbv/HrVKXRzPXE1kO24DFdvZWfK1wR0nGDNBTh2bxt5OapRmvt+n/0UuaDe0+uPevYCR5yIisTM54S9MixrYPTeqk7eSr/Gv9emYjF8Cos1sjOK5teHpwK42m9fTxxeS9lPkF/Y4EFZ7XiZAIp0D1lLeDyXoJIH+BEPPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org; arc=none smtp.client-ip=140.77.166.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 3E71AA73FA; Mon, 26 Jan 2026 22:49:59 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SphISBZoXXy9; Mon, 26 Jan 2026 22:49:59 +0100 (CET) Received: from end (aamiens-653-1-40-48.w83-192.abo.wanadoo.fr [83.192.199.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id B5831A73E6; Mon, 26 Jan 2026 22:49:58 +0100 (CET) Received: from samy by end with local (Exim 4.99.1) (envelope-from ) id 1vkUT7-0000000BnTE-3LJJ; Mon, 26 Jan 2026 22:49:57 +0100 Date: Mon, 26 Jan 2026 22:49:57 +0100 From: Samuel Thibault To: Henry Zhang Cc: speakup@linux-speakup.org, w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Henry Zhang Subject: Re: [PATCH] speakup: Clarify bleep_time unit is milliseconds Message-ID: Mail-Followup-To: Samuel Thibault , Henry Zhang , speakup@linux-speakup.org, w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Henry Zhang References: <20260126201707.1297665-1-zeri@umich.edu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260126201707.1297665-1-zeri@umich.edu> Organization: I am not organized Henry Zhang, le lun. 26 janv. 2026 15:17:07 -0500, a ecrit: > The documentation had a TODO questioning whether the unit was in > jiffies. The implementation in drivers/accessibility/speakup/main.c > passes spk_bleep_time to msecs_to_jiffies(), confirming the unit is > in milliseconds. > > Signed-off-by: Henry Zhang Reviewed-by: Samuel Thibault Thanks! > --- > Documentation/ABI/stable/sysfs-driver-speakup | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Documentation/ABI/stable/sysfs-driver-speakup b/Documentation/ABI/stable/sysfs-driver-speakup > index bcb6831aa114..8b508b4a7a00 100644 > --- a/Documentation/ABI/stable/sysfs-driver-speakup > +++ b/Documentation/ABI/stable/sysfs-driver-speakup > @@ -23,8 +23,7 @@ What: /sys/accessibility/speakup/bleep_time > KernelVersion: 2.6 > Contact: speakup@linux-speakup.org > Description: This controls the duration of the PC speaker beeps speakup > - produces. > - TODO: What are the units? Jiffies? > + produces, in milliseconds. > > What: /sys/accessibility/speakup/cursor_time > KernelVersion: 2.6 > -- > 2.34.1 >