Re: [PATCH v2 8/8] iio: dac: ds4424: ratelimit read errors and use device context

Andy Shevchenko
2026-01-27T10:47:45Z

On Tue, Jan 27, 2026 at 07:09:39AM +0100, Oleksij Rempel wrote:
> Replace pr_err() with dev_err_ratelimited() in the RAW read path to avoid
> log spam on repeated I2C failures and to include the device context.
>
> Use %pe to print errno names for faster debugging.

This should have been done before touching this line in the other patch.

...

> if (ret < 0) {
> - pr_err("%s : regmap_read returned %d\n",
> - __func__, ret);
> + dev_err_ratelimited(&indio_dev->dev,

Why not physical device?

> + "Failed to read channel %d: %pe\n",

Too many spaces.

> + chan->channel, ERR_PTR(ret));
> return ret;
> }

--
With Best Regards,
Andy Shevchenko